From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>,
"Git List" <git@vger.kernel.org>,
"Elia Pinto" <gitter.spiros@gmail.com>
Subject: Re: [PATCH] test-lib.sh: use awk instead of expr for a POSIX non integer check
Date: Wed, 09 Mar 2022 09:47:33 -0800 [thread overview]
Message-ID: <xmqqv8wnm30q.fsf@gitster.g> (raw)
In-Reply-To: <CAPig+cSUTaPRvALJyJ8AxNB4wMFLyaWBOa8f+_8K6quPbxTT5A@mail.gmail.com> (Eric Sunshine's message of "Tue, 8 Mar 2022 19:05:47 -0500")
Eric Sunshine <sunshine@sunshineco.com> writes:
> On Tue, Mar 8, 2022 at 6:58 PM Eric Sunshine <sunshine@sunshineco.com> wrote:
>> On Tue, Mar 8, 2022 at 6:55 PM Eric Sunshine <sunshine@sunshineco.com> wrote:
>> > On Tue, Mar 8, 2022 at 6:44 PM Carlo Marcelo Arenas Belón
>> > <carenas@gmail.com> wrote:
>> > > + local _GLIBC_VERSION=$(getconf GNU_LIBC_VERSION 2>/dev/null)
>> > > + if echo "$_GLIBC_VERSION" | cut -d. -f1-2 |
>> > > + awk '{ if ($2 - 2.34 < 0) exit 1 }'
>> >
>> > No need for `cut` since `awk` can accomplish the same by itself.
>> >
>> > if echo "$_GLIBC_VERSION" | awk '/^glibc / { if ($2 - 2.34 < 0) exit 1 }'
>> >
>> > should work, I would think.
>>
>> Nevermind, I forgot you want to better support "2.34.9000" matches.
>> Though, awk should still be able to do so on its own, one would
>> expect, but not too important.
>
> This seems to work, though it's getting a bit verbose:
>
> awk '/^glibc / { split($2,v,"."); if (sprintf("%s.%s", v[1], v[2])
> - 2.34 < 0) exit 1 }'
If we are losing "cut" (which I think is a good thing to do), we
probably can lose the pipe, too and refer to $_GLIBC_VERSION as an
element in ARGV[] and make the command used as "if" condition to a
single "awk" script?
In general it is a good discipline to question a pipeline that
preprocesses input fed to a script written in a language with full
programming power like awk and perl (and to lessor extent, sed) to
see if we can come up with a simpler solution without pipeline
helping to solve what these languages are invented to solve, and I
very much appreciate your exploration ;-)
Thanks.
next prev parent reply other threads:[~2022-03-09 17:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 13:37 [PATCH v3] test-lib.sh: Use GLIBC_TUNABLES instead of MALLOC_CHECK_ on glibc >= 2.34 Elia Pinto
2022-03-04 19:59 ` Junio C Hamano
2022-03-08 11:33 ` [PATCH] test-lib.sh: use awk instead of expr for a POSIX non integer check Carlo Marcelo Arenas Belón
2022-03-08 23:55 ` Eric Sunshine
2022-03-08 23:58 ` Eric Sunshine
2022-03-09 0:05 ` Eric Sunshine
2022-03-09 17:47 ` Junio C Hamano [this message]
2022-03-09 20:07 ` Ævar Arnfjörð Bjarmason
2022-03-11 23:06 ` Eric Sunshine
2022-03-12 10:38 ` Ævar Arnfjörð Bjarmason
2022-03-13 2:20 ` Junio C Hamano
2022-03-13 2:37 ` Carlo Arenas
2022-03-13 7:34 ` Junio C Hamano
2022-03-11 23:02 ` Eric Sunshine
2022-03-13 19:02 ` Elia Pinto
2022-04-04 20:39 ` [PATCH v3] test-lib.sh: Use GLIBC_TUNABLES instead of MALLOC_CHECK_ on glibc >= 2.34 Phillip Wood
2022-04-05 10:03 ` Making the tests ~2.5x faster (was: [PATCH v3] test-lib.sh: Use GLIBC_TUNABLES instead of MALLOC_CHECK_ on glibc >= 2.34) Ævar Arnfjörð Bjarmason
2022-04-05 13:36 ` Phillip Wood
2022-04-05 19:59 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv8wnm30q.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitter.spiros@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).