From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Emily Shaffer <emilyshaffer@google.com>
Subject: Re: ab/config-based-hooks-2
Date: Mon, 01 Nov 2021 13:17:58 -0700 [thread overview]
Message-ID: <xmqqv91bbpft.fsf@gitster.g> (raw)
In-Reply-To: <211101.861r3z4qyb.gmgdl@evledraar.gmail.com> (=?utf-8?B?IsOG?= =?utf-8?B?dmFyIEFybmZqw7Zyw7A=?= Bjarmason"'s message of "Mon, 01 Nov 2021 20:26:14 +0100")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> On Fri, Oct 29 2021, Junio C Hamano wrote:
>
>> * ab/config-based-hooks-2 (2021-10-20) 14 commits
>> - run-command: remove old run_hook_{le,ve}() hook API
>> - receive-pack: convert push-to-checkout hook to hook.h
>> - read-cache: convert post-index-change to use hook.h
>> - commit: convert {pre-commit,prepare-commit-msg} hook to hook.h
>> - git-p4: use 'git hook' to run hooks
>> - send-email: use 'git hook run' for 'sendemail-validate'
>> - git hook run: add an --ignore-missing flag
>> - merge: convert post-merge to use hook.h
>> - hooks: convert 'post-checkout' hook to hook library
>> - am: convert applypatch to use hook.h
>> - rebase: convert pre-rebase to use hook.h
>> - gc: use hook library for pre-auto-gc hook
>> - hook: add 'run' subcommand
>> - Merge branch 'ab/config-based-hooks-1' into ab/config-based-hooks-2
>>
>> More "config-based hooks".
>
> Re-rolled with the simplifications you requested, and now with a smaller
> diffstat:
> https://lore.kernel.org/git/cover-v4-00.17-00000000000-20211101T184938Z-avarab@gmail.com/
Heh, I didn't request anything. I just gave an observation or two,
and all the rest happened in your head ;-).
I do find that the new run_hooks() that takes a single hook name
makes the resulting callers much cleaner and simpler to follow.
No callers have to call find_hook() before run_hooks() anymore,
which looks good.
The new _l() variant, not so much contributing to the clarity,
unfortunately.
next prev parent reply other threads:[~2021-11-01 20:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-30 0:17 What's cooking in git.git (Oct 2021, #07; Fri, 29) Junio C Hamano
2021-11-01 19:26 ` ab/config-based-hooks-2 (was: What's cooking in git.git (Oct 2021, #07; Fri, 29)) Ævar Arnfjörð Bjarmason
2021-11-01 20:17 ` Junio C Hamano [this message]
2021-11-01 19:27 ` ab/only-single-progress-at-once " Ævar Arnfjörð Bjarmason
2021-11-01 19:30 ` tb/plug-pack-bitmap-leaks " Ævar Arnfjörð Bjarmason
2021-11-01 19:32 ` tp/send-email-completion " Ævar Arnfjörð Bjarmason
2021-11-01 19:34 ` js/scalar " Ævar Arnfjörð Bjarmason
2021-11-01 19:39 ` ms/customizable-ident-expansion " Ævar Arnfjörð Bjarmason
2021-11-01 20:23 ` ms/customizable-ident-expansion Junio C Hamano
[not found] ` <CABFYoQA82u8Um6L439_bU4a+WpkdXOcbU8foPjqnVw+4MnNU0A@mail.gmail.com>
2021-11-08 19:14 ` ms/customizable-ident-expansion Ævar Arnfjörð Bjarmason
2021-11-08 20:01 ` ms/customizable-ident-expansion Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2022-01-15 4:37 What's cooking in git.git (Jan 2022, #04; Fri, 14) Junio C Hamano
2022-01-18 15:59 ` ab/config-based-hooks-2 (was: What's cooking in git.git (Jan 2022, #04; Fri, 14)) Ævar Arnfjörð Bjarmason
2022-01-18 20:26 ` ab/config-based-hooks-2 Junio C Hamano
2021-10-19 6:48 What's cooking in git.git (Oct 2021, #05; Mon, 18) Junio C Hamano
2021-10-20 11:37 ` ab/config-based-hooks-2 Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv91bbpft.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).