git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* What's cooking in git.git (Aug 2021, #06; Mon, 16)
@ 2021-08-16 23:06 Junio C Hamano
  2021-08-16 23:43 ` Azeem Bande-Ali
                   ` (4 more replies)
  0 siblings, 5 replies; 17+ messages in thread
From: Junio C Hamano @ 2021-08-16 23:06 UTC (permalink / raw)
  To: git

Here are the topics that have been cooking in my tree.  Commits
prefixed with '+' are in 'next' (being in 'next' is a sign that a
topic is stable enough to be used and are candidate to be in a
future release).  Commits prefixed with '-' are only in 'seen',
which means nothing more than that I have found them of interest for
some reason (like "it may have hard-to-resolve conflicts with
another topic already in flight" or "this may turn out to be
useful").  Do not read too much into a topic being in (or not in)
'seen'.  The ones marked with '.' do not appear in any of the
integration branches, but I am still holding onto them.

Git 2.33 (final) has been tagged.  As it was a shorter cycle that
lasted only for 10 weeks, we may see some regression post release,
so let's see how it goes for a few days before starting the next
round.

Copies of the source code to Git live in many repositories, and the
following is a list of the ones I push into or their mirrors.  Some
repositories have only a subset of branches.

With maint, master, next, seen, todo:

	git://git.kernel.org/pub/scm/git/git.git/
	git://repo.or.cz/alt-git.git/
	https://kernel.googlesource.com/pub/scm/git/git/
	https://github.com/git/git/
	https://gitlab.com/git-vcs/git/

With all the integration branches and topics broken out:

	https://github.com/gitster/git/

Even though the preformatted documentation in HTML and man format
are not sources, they are published in these repositories for
convenience (replace "htmldocs" with "manpages" for the manual
pages):

	git://git.kernel.org/pub/scm/git/git-htmldocs.git/
	https://github.com/gitster/git-htmldocs.git/

Release tarballs are available at:

	https://www.kernel.org/pub/software/scm/git/

--------------------------------------------------
[Graduated to 'master']

* rs/oidtree-alignment-fix (2021-08-15) 1 commit
  (merged to 'next' on 2021-08-15 at f03b174faa)
 + oidtree: avoid unaligned access to crit-bit tree

 Codepath to access recently added oidtree data structure had
 to make unaligned accesses to oids, which has been corrected.

--------------------------------------------------
[New Topics]

* ar/submodule-run-update-procedure (2021-08-13) 1 commit
 - submodule--helper: run update procedures from C

 Reimplementation of parts of "git submodule" in C continues.


* cb/ci-use-upload-artifacts-v1 (2021-08-15) 1 commit
 - ci: use upload-artifacts v1 for dockerized jobs

 Use upload-artifacts v1 (instead of v2) for 32-bit linux, as the
 new version has a blocker bug for that architecture.

 Will merge to 'next'.


* pw/rebase-skip-final-fix (2021-08-13) 3 commits
 - rebase --continue: remove .git/MERGE_MSG
 - rebase --apply: restore some tests
 - t3403: fix commit authorship

 Checking out all the paths from HEAD during the last conflicted
 step in "git rebase" and continuing would cause the step to be
 skipped (which is expected), but leaves MERGE_HEAD file behind in
 $GIT_DIR and confuses the next "git commit", which has been
 corrected.

 Will merge to 'next'.


* ab/help-autocorrect-prompt (2021-08-14) 1 commit
 - help.c: help.autocorrect=prompt waits for user action

 The logic for auto-correction of misspelt subcommands learned to go
 interactive when the help.autocorrect configuration variable is set
 to true.


* pw/rebase-r-fixes (2021-08-15) 4 commits
 - rebase -r: fix merge -c with a merge strategy
 - rebase -r: don't write .git/MERGE_MSG when fast-forwarding
 - rebase -i: Add another reword test
 - rebase -r: make 'merge -c' behave like reword

 Various bugs in "git rebase -r" have been fixed.

--------------------------------------------------
[Stalled]

* gh/gitweb-branch-sort (2021-06-10) 1 commit
 - gitweb: use HEAD as secondary sort key in git_get_heads_list()

 Tie-break branches that point at the same object in the list of
 branches on GitWeb to show the one pointed at by HEAD early.

 Waiting for reviews.


* lh/systemd-timers (2021-07-02) 3 commits
 - maintenance: add support for systemd timers on Linux
 - maintenance: `git maintenance run` learned `--scheduler=<scheduler>`
 - cache.h: Introduce a generic "xdg_config_home_for(…)" function

 "git maintenance" scheduler learned to use systemd timers as a
 possible backend.

 Waiting for reviews.


* fc/completion-updates (2021-06-07) 4 commits
 - completion: bash: add correct suffix in variables
 - completion: bash: fix for multiple dash commands
 - completion: bash: fix for suboptions with value
 - completion: bash: fix prefix detection in branch.*

 Command line completion updates.

 Expecting a reroll.
 cf. <60be6f7fa4435_db80d208f2@natae.notmuch>


* es/superproject-aware-submodules (2021-06-16) 5 commits
 - SQUASH???
 - submodule: cache superproject gitdir during 'update'
 - submodule: cache superproject gitdir during absorbgitdirs
 - introduce submodule.superprojectGitDir cache
 - t7400-submodule-basic: modernize inspect() helper

 A configuration variable in a submodule points at the location of
 the superproject it is bound to (RFC).

 Waiting for reviews.


* en/zdiff3 (2021-06-15) 2 commits
 - update documentation for new zdiff3 conflictStyle
 - xdiff: implement a zealous diff3, or "zdiff3"

 "Zealous diff3" style of merge conflict presentation has been added.

 Expecting a reroll.
 cf. <CABPp-BE7-E03+x38EK-=AE5mwwdST+d50hiiud2eY2Nsf3rM5g@mail.gmail.com>


* ao/p4-avoid-decoding (2021-04-12) 2 commits
 - git-p4: do not decode data from perforce by default
 - git-p4: avoid decoding more data from perforce

 "git p4" in Python-2 days used to accept a lot more kinds of data
 from Perforce server as uninterrupted byte sequence, but after
 switching to Python-3, too many things are expected to be in UTF-8,
 which broke traditional use cases.

 Waiting for reviews.


* tv/p4-fallback-encoding (2021-04-30) 1 commit
 - git-p4: git-p4.fallbackEncoding to specify non UTF-8 charset

 "git p4" learns the fallbackEncoding configuration variable to
 safely accept changeset descriptions that aren't written in UTF-8.

 Waiting for reviews.

--------------------------------------------------
[Cooking]

* th/userdiff-more-java (2021-08-11) 1 commit
 - userdiff: improve java hunk header regex

 The userdiff pattern for "java" language has been updated.

 Will merge to 'next'.


* zh/cherry-pick-advice (2021-08-14) 1 commit
 - cherry-pick: use better advice message

 The advice message that "git cherry-pick" gives when it asks
 conflicted replay of a commit to be resolved by the end user has
 been updated.


* es/config-based-hooks (2021-08-11) 7 commits
 - hook: allow out-of-repo 'git hook' invocations
 - hook: include hooks from the config
 - hook: allow running non-native hooks
 - hook: introduce "git hook list"
 - hook: allow parallel hook execution
 - hook: run a list of hooks instead
 - Merge branch 'ab/config-based-hooks-base' into es/config-based-hooks
 (this branch uses ab/config-based-hooks-base.)

 Revamp the hooks subsystem to allow multiple of them to trigger
 upon the same event and control via the configuration variables.


* mk/clone-recurse-submodules (2021-08-14) 1 commit
 - clone: set submodule.recurse=true if submodule.stickyRecursiveClone enabled

 After "git clone --recurse-submodules", all submodules are cloned
 but they are not by default recursed into by other commands.  With
 submodule.stickyRecursiveClone configuration set, submodule.recurse
 configuration is set to true in a repository created by "clone"
 with "--recurse-submodules" option.


* bc/t5607-avoid-broken-test-fail-prereqs (2021-08-11) 1 commit
 - t5607: avoid using prerequisites to select algorithm

 The current implementation of GIT_TEST_FAIL_PREREQS is broken in
 that checking for the lack of a prerequisite would not work.  Avoid
 the use of "if ! test_have_prereq X" in a test script.

 Will merge to 'next'.


* jk/commit-edit-fixup-fix (2021-08-15) 1 commit
 - commit: restore --edit when combined with --fixup

 "git commit --fixup" now works with "--edit" again, after it was
 broken in v2.32.

 Will merge to 'next'?


* tl/traverse-non-commits-rename (2021-08-12) 1 commit
 - list-objects.c: rename "traverse_trees_and_blobs" to "traverse_non_commits"

 Meh.

 Will merge to 'next'.


* cb/ci-freebsd-update (2021-08-12) 1 commit
 - ci: update freebsd 12 cirrus job

 Update FreeBSD CI job

 Will merge to 'next'.


* cb/builtin-merge-format-string-fix (2021-08-09) 1 commit
 - builtin/merge: avoid -Wformat-extra-args from ancient Xcode

 Code clean-up.

 Will merge to 'next'.


* ka/want-ref-in-namespace (2021-08-13) 3 commits
 - docs: clarify the interaction of transfer.hideRefs and namespaces
 - upload-pack.c: treat want-ref relative to namespace
 - t5730: introduce fetch command helper

 "git upload-pack" which runs on the other side of "git fetch"
 forgot to take the ref namespaces into account when handling
 want-ref requests.


* np/blame-ignore-revs-file-may-be-optional (2021-08-09) 1 commit
 - blame: add config `blame.ignoreRevsFileIsOptional`

 When the file named by blame.ignoreRevsFile configuration variable
 does not exist, it causes "git blame" to die.  Sometimes, it is
 useful if the files named by configuration variables can be made
 optional (it would allow ~/.gitconfig to give a filename, and make
 it effective only in repositories that have a file with that name).

 This uses an extra variable that marks that the variable is
 optional.  Yet another alternative is being discussed to define
 syntax for "optional" filename values, so that the same mechanism
 can be used for not just blame.ignoreRevsFile but other filenames.

 Queued just as a reminder of the theme.


* cb/ci-build-pedantic (2021-08-11) 1 commit
 - ci: run a pedantic build as part of the GitHub workflow

 CI update.

 Expecting a reroll.


* ds/sparse-index-ignored-files (2021-08-10) 9 commits
 - sparse-checkout: clear tracked sparse dirs
 - sparse-index: add SPARSE_INDEX_IGNORE_CONFIG flag
 - attr: be careful about sparse directories
 - sparse-checkout: create helper methods
 - unpack-trees: fix nested sparse-dir search
 - sparse-index: silently return when cache tree fails
 - sparse-index: silently return when not using cone-mode patterns
 - t7519: rewrite sparse index test
 - Merge branch 'ds/add-with-sparse-index' into ds/sparse-index-ignored-files
 (this branch uses ds/add-with-sparse-index.)

 In cone mode, the sparse-index codepath learned to remove ignored
 files (like build artifacts) outside the sparse cone, allowing the
 entire directory outside the sparse cone to be removed, which is
 especially useful when the sparse patterns change.


* jc/userdiff-pattern-hint (2021-08-11) 1 commit
 - userdiff: comment on the builtin patterns

 Remind developers that the userdiff patterns should be kept simple
 and permissive, assuming that the contents they apply are always
 syntactically correct.

 Will merge to 'next'.


* jk/apply-binary-hunk-parsing-fix (2021-08-10) 1 commit
 - apply: keep buffer/size pair in sync when parsing binary hunks

 "git apply" miscounted the bytes and failed to read to the end of
 binary hunks.

 Will merge to 'next'.


* jk/range-diff-fixes (2021-08-10) 3 commits
 - range-diff: use ssize_t for parsed "len" in read_patches()
 - range-diff: handle unterminated lines in read_patches()
 - range-diff: drop useless "offset" variable from read_patches()

 "git range-diff" code clean-up.

 Will merge to 'next'.


* js/advise-when-skipping-cherry-picked (2021-08-10) 2 commits
 - SQUASH???
 - sequencer: advise if skipping cherry-picked commit

 "git rebase" by default skips changes that are equivalent to
 commits that are already in the history the branch is rebased onto;
 give messages when this happens to let the users be aware of
 skipped commits, and also teach them how to tell "rebase" to keep
 duplicated changes.


* jt/grep-wo-submodule-odb-as-alternate (2021-08-13) 8 commits
 - t7814: show lack of alternate ODB-adding
 - submodule-config: pass repo upon blob config read
 - grep: add repository to OID grep sources
 - grep: allocate subrepos on heap
 - grep: read submodule entry with explicit repo
 - grep: typesafe versions of grep_source_init
 - grep: use submodule-ODB-as-alternate lazy-addition
 - submodule: lazily add submodule ODBs as alternates

 The code to make "git grep" recurse into submodules has been
 updated to migrate away from the "add submodule's object store as
 an alternate object store" mechanism (which is suboptimal).


* ps/fetch-pack-load-refs-optim (2021-08-04) 1 commit
  (merged to 'next' on 2021-08-09 at 4744a01fd5)
 + fetch-pack: speed up loading of refs via commit graph

 Loading of ref tips to prepare for common ancestry negotiation in
 "git fetch-pack" has been optimized by taking advantage of the
 commit graph when available.

 Will cook in 'next'.


* ps/connectivity-optim (2021-08-09) 5 commits
 - revision: avoid hitting packfiles when commits are in commit-graph
 - commit-graph: split out function to search commit position
 - revision: stop retrieving reference twice
 - connected: do not sort input revisions
 - revision: separate walk and unsorted flags

 The revision traversal API has been optimized by taking advantage
 of the commit-graph, when available, to determine if a commit is
 reachable from any of the existing refs.

 Will merge to 'next'.


* ar/submodule-add-more (2021-08-10) 10 commits
 - submodule--helper: rename compute_submodule_clone_url()
 - submodule--helper: remove resolve-relative-url subcommand
 - submodule--helper: remove add-config subcommand
 - submodule--helper: remove add-clone subcommand
 - submodule--helper: convert the bulk of cmd_add() to C
 - dir: libify and export helper functions from clone.c
 - submodule--helper: remove repeated code in sync_submodule()
 - submodule--helper: refactor resolve_relative_url() helper
 - submodule--helper: add options for compute_submodule_clone_url()
 - Merge branch 'ar/submodule-add-config' into ar/submodule-add
 (this branch uses ar/submodule-add-config.)

 More parts of "git submoudle add" has been rewritten in C.


* cb/makefile-apple-clang (2021-08-06) 3 commits
 - build: catch clang that identifies itself as "$VENDOR clang"
 - build: clang version may not be followed by extra words
 - build: update detect-compiler for newer Xcode version

 Build update.


* jk/refs-files-cleanup-cleanup (2021-08-06) 1 commit
  (merged to 'next' on 2021-08-09 at 37b0b8c910)
 + refs: drop unused "flags" parameter to lock_ref_oid_basic()
 (this branch uses ab/refs-files-cleanup.)

 Code cleanup.

 Will cook in 'next'.


* en/merge-strategy-docs (2021-08-05) 10 commits
 - Update error message and code comment
 - merge-strategies.txt: add coverage of the `ort` merge strategy
 - git-rebase.txt: correct out-of-date and misleading text about renames
 - merge-strategies.txt: fix simple capitalization error
 - merge-strategies.txt: avoid giving special preference to patience algorithm
 - merge-strategies.txt: do not imply using copy detection is desired
 - merge-strategies.txt: update wording for the resolve strategy
 - Documentation: edit awkward references to `git merge-recursive`
 - directory-rename-detection.txt: small updates due to merge-ort optimizations
 - git-rebase.txt: correct antiquated claims about --rebase-merges
 (this branch is used by en/ort-becomes-the-default.)

 Documentation updates.

 Will merge to 'next'.


* en/ort-becomes-the-default (2021-08-05) 2 commits
 - Update docs for change of default merge backend
 - Change default merge backend from recursive to ort
 (this branch uses en/merge-strategy-docs.)

 Use `ort` instead of `recursive` as the default merge strategy.

 Will merge to 'next'.


* js/log-protocol-version (2021-08-10) 1 commit
 - connect, protocol: log negotiated protocol version

 Debugging aid.

 Will merge to 'next'.


* ow/clone-bare-origin (2021-08-03) 1 commit
 - clone: Allow combining --bare and --origin

 "git clone" did not like to take "--bare" and "--origin=X" at the
 same time; loosen the restriction.

 Under discussion.  This may require some follow-on work.
 cf. <20210802174944.53745-1-oystwa@gmail.com>


* jc/bisect-sans-show-branch (2021-07-28) 2 commits
  (merged to 'next' on 2021-08-02 at 89a8d9a47b)
 + bisect: simplify return code from bisect_checkout()
 + bisect: do not run show-branch just to show the current commit

 "git bisect" spawned "git show-branch" only to pretty-print the
 title of the commit after checking out the next version to be
 tested; this has been rewritten in C.

 Will cook in 'next'.


* jc/trivial-threeway-binary-merge (2021-07-28) 1 commit
 - ll-merge: teach ll_binary_merge() a trivial three-way merge

 The built-in merge driver for binary files learned to resolve
 trivial three-way merges (e.g. apply change, which turns A into B,
 to content A) by itself, which would help "git apply --3way" used
 when there is no need to use "--3way".

 Will discard.
 Replace with a trivial-merge logic in apply.c::try_treeway() or
 apply.c::three_way_merge().


* ab/http-drop-old-curl (2021-07-30) 5 commits
  (merged to 'next' on 2021-08-02 at b382ac042f)
 + http: rename CURLOPT_FILE to CURLOPT_WRITEDATA
 + http: drop support for curl < 7.19.3 and < 7.17.0 (again)
 + http: drop support for curl < 7.19.4
 + http: drop support for curl < 7.16.0
 + http: drop support for curl < 7.11.1

 Support for ancient versions of cURL library has been dropped.

 Will cook in 'next'.


* ab/lib-subtest (2021-08-05) 11 commits
 - test-lib tests: assert 1 exit code, not non-zero
 - test-lib tests: refactor common part of check_sub_test_lib_test*()
 - test-lib tests: avoid subshell for "test_cmp" for readability
 - test-lib tests: assert no copy/pasted mock test code
 - test-lib tests: get rid of copy/pasted mock test code
 - test-lib tests: don't provide a description for the sub-tests
 - test-lib tests: stop using a subshell in write_sub_test_lib_test()
 - test-lib tests: split up "write and run" into two functions
 - test-lib tests: move "run_sub_test" to a new lib-subtest.sh
 - Merge branch 'ps/t0000-output-directory-fix' into ab/lib-subtest
 - Merge branch 'jk/t0000-subtests-fix' into ab/lib-subtest

 Updates to the tests in t0000 to test the test framework.


* ds/add-with-sparse-index (2021-07-29) 5 commits
  (merged to 'next' on 2021-08-02 at ee3e1323bb)
 + add: remove ensure_full_index() with --renormalize
 + add: ignore outside the sparse-checkout in refresh()
 + pathspec: stop calling ensure_full_index
 + add: allow operating on a sparse-only index
 + t1092: test merge conflicts outside cone
 (this branch is used by ds/sparse-index-ignored-files.)

 "git add" can work better with the sparse index.

 Will cook in 'next'.


* ab/only-single-progress-at-once (2021-07-23) 8 commits
 - progress.c: add & assert a "global_progress" variable
 - pack-bitmap-write.c: add a missing stop_progress()
 - progress.c: add temporary variable from progress struct
 - progress.c: stop eagerly fflush(stderr) when not a terminal
 - progress.c: call progress_interval() from progress_test_force_update()
 - progress.c: move signal handler functions lower
 - progress.c tests: test some invalid usage
 - progress.c tests: make start/stop verbs on stdin

 Further tweaks on progress API.


* ab/progress-users-adjust-counters (2021-08-05) 3 commits
 - entry: show finer-grained counter in "Filtering content" progress line
 - midx: don't provide a total for QSORT() progress
 - commit-graph: fix bogus counter in "Scanning merged commits" progress line

 The code to show progress indicator in a few codepaths did not
 cover between 0-100%, which has been corrected.

 The middle one wants to be discarded.
 cf. <87v94jzoxj.fsf@evledraar.gmail.com>


* ar/submodule-add-config (2021-08-10) 1 commit
 - submodule--helper: introduce add-config subcommand
 (this branch is used by ar/submodule-add-more.)

 Large part of "git submodule add" gets rewritten in C.


* en/ort-perf-batch-15 (2021-08-03) 9 commits
  (merged to 'next' on 2021-08-04 at 87fc290e71)
 + merge-ort: remove compile-time ability to turn off usage of memory pools
 + merge-ort: reuse path strings in pool_alloc_filespec
 + merge-ort: store filepairs and filespecs in our mem_pool
 + diffcore-rename, merge-ort: add wrapper functions for filepair alloc/dealloc
 + merge-ort: switch our strmaps over to using memory pools
 + merge-ort: set up a memory pool
 + merge-ort: add pool_alloc, pool_calloc, and pool_strndup wrappers
 + diffcore-rename: use a mem_pool for exact rename detection's hashmap
 + merge-ort: rename str{map,intmap,set}_func()

 Final batch for "merge -sort" optimization.

 Will cook in 'next'.


* js/expand-runtime-prefix (2021-07-26) 6 commits
  (merged to 'next' on 2021-08-04 at b95a81a004)
 + expand_user_path: allow in-flight topics to keep using the old name
 + interpolate_path(): allow specifying paths relative to the runtime prefix
 + Use a better name for the function interpolating paths
 + expand_user_path(): clarify the role of the `real_home` parameter
 + expand_user_path(): remove stale part of the comment
 + tests: exercise the RUNTIME_PREFIX feature

 Pathname expansion (like "~username/") learned a way to specify a
 location relative to Git installation (e.g. its $sharedir which is
 $(prefix)/share), with "%(prefix)".

 Will cook in 'next'.


* zh/cherry-pick-help-is-only-for-sequencer (2021-08-03) 2 commits
  (merged to 'next' on 2021-08-04 at 9ea14ed106)
 + cherry-pick: use better advice message
 + cherry-pick: fix bug when used with GIT_CHERRY_PICK_HELP

 "git cherry-pick" loses its state file when a stray
 GIT_CHERRY_PICK_HELP environment is present, which has been
 corrected.

 Will cook in 'next'.


* dt/submodule-diff-fixes (2021-08-11) 3 commits
 - diff --submodule=diff: don't print failure message twice
 - diff --submodule=diff: do not fail on ever-initialied deleted submodules
 - t4060: remove unused variable

 "git diff --submodule=diff" showed failure from run_command() when
 trying to run diff inside a submodule, when the user manually
 removes the submodule directory.

 Will merge to 'next'?
 cf. <20210812001332.715876-1-dturner@twosigma.com>


* fs/ssh-signing (2021-08-03) 9 commits
 - ssh signing: test that gpg fails for unkown keys
 - ssh signing: tests for logs, tags & push certs
 - ssh signing: duplicate t7510 tests for commits
 - ssh signing: verify signatures using ssh-keygen
 - ssh signing: provide a textual signing_key_id
 - ssh signing: retrieve a default key from ssh-agent
 - ssh signing: add ssh key format and signing code
 - ssh signing: add test prereqs
 - ssh signing: preliminary refactoring and clean-up

 Use ssh public crypto for object and push-cert signing.

 Comments?


* hn/refs-test-cleanup (2021-08-02) 11 commits
  (merged to 'next' on 2021-08-04 at 5651c32f4b)
 + t6001: avoid direct file system access
 + t6500: use "ls -1" to snapshot ref database state
 + t7064: use update-ref -d to remove upstream branch
 + t1410: mark test as REFFILES
 + t1405: mark test for 'git pack-refs' as REFFILES
 + t1405: use 'git reflog exists' to check reflog existence
 + t2402: use ref-store test helper to create broken symlink
 + t3320: use git-symbolic-ref rather than filesystem access
 + t6120: use git-update-ref rather than filesystem access
 + t1503: mark symlink test as REFFILES
 + t6050: use git-update-ref rather than filesystem access

 A handful of tests that assumed implementation details of files
 backend for refs have been cleaned up.

 Will cook in 'next'.


* hn/reftable (2021-08-16) 25 commits
 - t1404: annotate test cases with REFFILES
 - t1401,t2011: parameterize HEAD.lock for REFFILES
 - t1301: document what needs to be done for reftable
 - Add "test-tool dump-reftable" command.
 - git-prompt: prepare for reftable refs backend
 - refs: RFC: Reftable support for git-core
 - reftable: add dump utility
 - reftable: implement stack, a mutable database of reftable files.
 - reftable: implement refname validation
 - reftable: add merged table view
 - reftable: add a heap-based priority queue for reftable records
 - reftable: reftable file level tests
 - reftable: read reftable files
 - reftable: generic interface to tables
 - reftable: write reftable files
 - reftable: a generic binary tree implementation
 - reftable: reading/writing blocks
 - Provide zlib's uncompress2 from compat/zlib-compat.c
 - reftable: (de)serialization for the polymorphic record type.
 - reftable: add blocksource, an abstraction for random access reads
 - reftable: utility functions
 - reftable: add error related functionality
 - reftable: RFC: add LICENSE
 - init-db: set the_repository->hash_algo early on
 - hash.h: provide constants for the hash IDs

 The "reftable" backend for the refs API.


* ab/refs-files-cleanup (2021-08-02) 11 commits
  (merged to 'next' on 2021-08-04 at 8ca0ef1b6e)
 + refs/files: remove unused "errno != ENOTDIR" condition
 + refs/files: remove unused "errno == EISDIR" code
 + refs/files: remove unused "oid" in lock_ref_oid_basic()
 + reflog expire: don't lock reflogs using previously seen OID
 + refs/files: add a comment about refs_reflog_exists() call
 + refs: make repo_dwim_log() accept a NULL oid
 + refs/debug: re-indent argument list for "prepare"
 + refs/files: remove unused "skip" in lock_raw_ref() too
 + refs/files: remove unused "extras/skip" in lock_ref_oid_basic()
 + refs/files: remove unused REF_DELETING in lock_ref_oid_basic()
 + refs/packet: add missing BUG() invocations to reflog callbacks
 (this branch is used by hn/refs-errno-cleanup and jk/refs-files-cleanup-cleanup.)

 Will cook in 'next'.


* en/pull-conflicting-options (2021-07-22) 8 commits
 - pull: fix handling of multiple heads
 - pull: update docs & code for option compatibility with rebasing
 - pull: abort by default when fast-forwarding is not possible
 - pull: make --rebase and --no-rebase override pull.ff=only
 - pull: since --ff-only overrides, handle it first
 - pull: abort if --ff-only is given and fast-forwarding is impossible
 - t7601: add tests of interactions with multiple merge heads and config
 - t7601: test interaction of merge/rebase/fast-forward flags and options

 "git pull" had various corner cases that were not well thought out
 around its --rebase backend, e.g. "git pull --ff-only" did not stop
 but went ahead and rebased when the history on other side is not a
 descendant of our history.  The series tries to fix them up.

 Will merge to 'next'.


* cf/fetch-set-upstream-while-detached (2021-07-06) 1 commit
 - fetch: fix segfault on --set-upstream while on a detached HEAD

 "git fetch --set-upstream" while on detached HEAD segfaulted
 instead of noticing that such an operation did not make sense.

 Expecting a reroll.
 cf. <xmqqsg0ri5mq.fsf@gitster.g>


* ab/bundle-doc (2021-08-02) 4 commits
  (merged to 'next' on 2021-08-04 at b3b3b0fa98)
 + bundle doc: replace "basis" with "prerequsite(s)"
 + bundle doc: elaborate on rev<->ref restriction
 + bundle doc: elaborate on object prerequisites
 + bundle doc: rewrite the "DESCRIPTION" section

 Doc update.

 Will cook in 'next'.


* ab/pack-stdin-packs-fix (2021-07-09) 2 commits
  (merged to 'next' on 2021-08-04 at f464b74a6f)
 + pack-objects: fix segfault in --stdin-packs option
 + pack-objects tests: cover blindspots in stdin handling

 Input validation of "git pack-objects --stdin-packs" has been
 corrected.

 Will cook in 'next'.


* jt/push-negotiation-fixes (2021-07-15) 3 commits
  (merged to 'next' on 2021-08-09 at ea7da8239c)
 + fetch: die on invalid --negotiation-tip hash
 + send-pack: fix push nego. when remote has refs
 + send-pack: fix push.negotiate with remote helper

 Bugfix for common ancestor negotiation recently introduced in "git
 push" codepath.

 Will cook in 'next'.


* ab/make-tags-cleanup (2021-08-05) 5 commits
 - Makefile: normalize clobbering & xargs for tags targets
 - Makefile: remove "cscope.out", not "cscope*" in cscope.out target
 - Makefile: don't use "FORCE" for tags targets
 - Makefile: add QUIET_GEN to "cscope" target
 - Makefile: move ".PHONY: cscope" near its target

 Build clean-up for "make tags" and friends.

 Expecting a reroll.
 4/5 may want a minor tweak to the log and the patch text but otherwise looks good.


* tb/multi-pack-bitmaps (2021-07-27) 25 commits
 - p5326: perf tests for MIDX bitmaps
 - p5310: extract full and partial bitmap tests
 - midx: respect 'GIT_TEST_MULTI_PACK_INDEX_WRITE_BITMAP'
 - t7700: update to work with MIDX bitmap test knob
 - t5319: don't write MIDX bitmaps in t5319
 - t5310: disable GIT_TEST_MULTI_PACK_INDEX_WRITE_BITMAP
 - t0410: disable GIT_TEST_MULTI_PACK_INDEX_WRITE_BITMAP
 - t5326: test multi-pack bitmap behavior
 - t/helper/test-read-midx.c: add --checksum mode
 - t5310: move some tests to lib-bitmap.sh
 - pack-bitmap: write multi-pack bitmaps
 - pack-bitmap: read multi-pack bitmaps
 - pack-bitmap.c: avoid redundant calls to try_partial_reuse
 - pack-bitmap.c: introduce 'bitmap_is_preferred_refname()'
 - pack-bitmap.c: introduce 'nth_bitmap_object_oid()'
 - pack-bitmap.c: introduce 'bitmap_num_objects()'
 - midx: avoid opening multiple MIDXs when writing
 - midx: close linked MIDXs, avoid leaking memory
 - midx: infer preferred pack when not given one
 - midx: reject empty `--preferred-pack`'s
 - midx: clear auxiliary .rev after replacing the MIDX
 - Documentation: describe MIDX-based bitmaps
 - pack-bitmap-write.c: free existing bitmaps
 - pack-bitmap-write.c: gracefully fail to write non-closed bitmaps
 - pack-bitmap.c: harden 'test_bitmap_walk()' to check type bitmaps

 The reachability bitmap file used to be generated only for a single
 pack, but now we've learned to generate bitmaps for history that
 span across multiple packfiles.

 Comments?


* ab/config-based-hooks-base (2021-08-03) 36 commits
 - hooks: fix a TOCTOU in "did we run a hook?" heuristic
 - receive-pack: convert receive hooks to hook.h
 - post-update: use hook.h library
 - receive-pack: convert 'update' hook to hook.h
 - hooks: allow callers to capture output
 - run-command: allow capturing of collated output
 - reference-transaction: use hook.h to run hooks
 - hook tests: use a modern style for "pre-push" tests
 - hook tests: test for exact "pre-push" hook input
 - transport: convert pre-push hook to hook.h
 - hook: convert 'post-rewrite' hook in sequencer.c to hook.h
 - hook: provide stdin by string_list or callback
 - run-command: add stdin callback for parallelization
 - am: convert 'post-rewrite' hook to hook.h
 - hook: support passing stdin to hooks
 - run-command: allow stdin for run_processes_parallel
 - run-command: remove old run_hook_{le,ve}() hook API
 - receive-pack: convert push-to-checkout hook to hook.h
 - read-cache: convert post-index-change to use hook.h
 - commit: convert {pre-commit,prepare-commit-msg} hook to hook.h
 - git-p4: use 'git hook' to run hooks
 - send-email: use 'git hook run' for 'sendemail-validate'
 - git hook run: add an --ignore-missing flag
 - merge: convert post-merge to use hook.h
 - hooks: convert 'post-checkout' hook to hook library
 - am: convert applypatch to use hook.h
 - rebase: convert pre-rebase to use hook.h
 - gc: use hook library for pre-auto-gc hook
 - hook: add 'run' subcommand
 - hook-list.h: add a generated list of hooks, like config-list.h
 - hook.c users: use "hook_exists()" insted of "find_hook()"
 - hook.c: add a hook_exists() wrapper and use it in bugreport.c
 - hook.[ch]: move find_hook() to this new library
 - Makefile: remove an out-of-date comment
 - Makefile: stop hardcoding {command,config}-list.h
 - Makefile: mark "check" target as .PHONY
 (this branch is used by es/config-based-hooks.)

 Restructuring of (a subset of) Emily's config-based-hooks series,
 to demonstrate that a series can be presented as a more logical and
 focused progression.

 Waiting for reviews.


* ab/serve-cleanup (2021-08-05) 10 commits
 - upload-pack: document and rename --advertise-refs
 - serve.[ch]: remove "serve_options", split up --advertise-refs code
 - {upload,receive}-pack tests: add --advertise-refs tests
 - serve.c: move version line to advertise_capabilities()
 - serve: move transfer.advertiseSID check into session_id_advertise()
 - serve.[ch]: don't pass "struct strvec *keys" to commands
 - serve: use designated initializers
 - transport: use designated initializers
 - transport: rename "fetch" in transport_vtable to "fetch_refs"
 - serve: mark has_capability() as static

 Code clean-up around "git serve".

 Expecting a reroll.


* pw/diff-color-moved-fix (2021-08-05) 13 commits
  (merged to 'next' on 2021-08-05 at 7b5e312aac)
 + diff: drop unused options parameter from cmp_in_block_with_wsd()
  (merged to 'next' on 2021-08-04 at 4de4a451e0)
 + diff --color-moved: intern strings
 + diff: use designated initializers for emitted_diff_symbol
 + diff --color-moved-ws=allow-indentation-change: improve hash lookups
 + diff --color-moved: stop clearing potential moved blocks
 + diff --color-moved: shrink potential moved blocks as we go
 + diff --color-moved: unify moved block growth functions
 + diff --color-moved: call comparison function directly
 + diff --color-moved-ws=allow-indentation-change: simplify and optimize
 + diff: simplify allow-indentation-change delta calculation
 + diff --color-moved: avoid false short line matches and bad zerba coloring
 + diff --color-moved=zebra: fix alternate coloring
 + diff --color-moved: add perf tests

 Long-overdue correctness and performance update to "diff
 --color-moved" feature.

 Will cook in 'next'.


* hn/refs-errno-cleanup (2021-08-02) 7 commits
  (merged to 'next' on 2021-08-04 at 7fe3c31e7f)
 + refs: make errno output explicit for refs_resolve_ref_unsafe
 + refs: explicitly return failure_errno from parse_loose_ref_contents
 + refs: add failure_errno to refs_read_raw_ref() signature
 + refs: make errno output explicit for read_raw_ref_fn
 + refs/files-backend: stop setting errno from lock_ref_oid_basic
 + refs: remove EINVAL errno output from specification of read_raw_ref_fn
 + refs file backend: move raceproof_create_file() here
 (this branch uses ab/refs-files-cleanup.)

 Futz with the way 'errno' is relied on in the refs API to carry the
 failure modes up the callchain.

 Will cook in 'next'.


* ab/test-tool-cache-cleanup (2021-06-08) 4 commits
 - read-cache perf: add a perf test for refresh_index()
 - test-tool: migrate read-cache-again to parse_options()
 - test-tool: migrate read-cache-perf to parse_options()
 - test-tool: split up test-tool read-cache

 Test code shuffling.

 Expecting a reroll.


* ab/pack-objects-stdin (2021-07-09) 5 commits
 - pack-objects.c: make use of REV_INFO_STDIN_LINE_PROCESS
 - pack-objects.c: do stdin parsing via revision.c's API
 - revision.[ch]: add a "handle_stdin_line" API
 - revision.h: refactor "disable_stdin" and "read_from_stdin"
 - upload-pack: run is_repository_shallow() before setup_revisions()

 Introduce handle_stdin_line callback to revision API and uses it.

 Waiting for reviews.


* zh/ref-filter-raw-data (2021-07-26) 6 commits
  (merged to 'next' on 2021-08-04 at 4c4529d8d0)
 + ref-filter: add %(rest) atom
 + ref-filter: use non-const ref_format in *_atom_parser()
 + ref-filter: --format=%(raw) support --perl
 + ref-filter: add %(raw) atom
 + ref-filter: add obj-type check in grab contents
 + Merge branch 'zh/cat-file-batch-fix' into zh/ref-filter-raw-data

 Prepare the "ref-filter" machinery that drives the "--format"
 option of "git for-each-ref" and its friends to be used in "git
 cat-file --batch".

 Will cook in 'next'.


* jh/builtin-fsmonitor (2021-07-12) 35 commits
 - BANDAID: sparse fixes
 - t7527: test FS event reporing on MacOS WRT case and Unicode
 - fsmonitor: handle shortname for .git
 - t7527: test status with untracked-cache and fsmonitor--daemon
 - fsmonitor: force update index after large responses
 - fsmonitor: enhance existing comments
 - fsmonitor--daemon: use a cookie file to sync with file system
 - fsmonitor--daemon: periodically truncate list of modified files
 - t7527: create test for fsmonitor--daemon
 - t/perf/p7519: add fsmonitor--daemon test cases
 - t/perf: avoid copying builtin fsmonitor files into test repo
 - t/perf/p7519: speed up test using "test-tool touch"
 - t/helper/test-touch: add helper to touch a series of files
 - fsmonitor--daemon: implement handle_client callback
 - fsmonitor-fs-listen-macos: implement FSEvent listener on MacOS
 - fsmonitor-fs-listen-macos: add macos header files for FSEvent
 - fsmonitor-fs-listen-win32: implement FSMonitor backend on Windows
 - fsmonitor--daemon: create token-based changed path cache
 - fsmonitor--daemon: define token-ids
 - fsmonitor--daemon: add pathname classification
 - fsmonitor: do not try to operate on bare repos
 - fsmonitor--daemon: implement 'start' command
 - fsmonitor--daemon: implement 'run' command
 - fsmonitor-fs-listen-macos: stub in backend for MacOS
 - fsmonitor-fs-listen-win32: stub in backend for Windows
 - t/helper/fsmonitor-client: create IPC client to talk to FSMonitor Daemon
 - fsmonitor--daemon: implement 'stop' and 'status' commands
 - fsmonitor--daemon: add a built-in fsmonitor daemon
 - fsmonitor: use IPC to query the builtin FSMonitor daemon
 - fsmonitor: config settings are repository-specific
 - help: include fsmonitor--daemon feature flag in version info
 - fsmonitor-ipc: create client routines for git-fsmonitor--daemon
 - fsmonitor--daemon: update fsmonitor documentation
 - fsmonitor--daemon: man page
 - simple-ipc: preparations for supporting binary messages.

 An attempt to write and ship with a watchman equivalent tailored
 for our use.

 Expecting a reroll post 2.33 release.


* es/trace2-log-parent-process-name (2021-07-22) 2 commits
  (merged to 'next' on 2021-08-04 at 47e35c31b0)
 + tr2: log parent process name
 + tr2: make process info collection platform-generic

 trace2 logs learned to show parent process name to see in what
 context Git was invoked.

 Will cook in 'next'.


* ab/fsck-unexpected-type (2021-07-12) 21 commits
 - fsck: report invalid object type-path combinations
 - fsck: report invalid types recorded in objects
 - object-store.h: move read_loose_object() below 'struct object_info'
 - fsck: don't hard die on invalid object types
 - object-file.c: return -2 on "header too long" in unpack_loose_header()
 - object-file.c: return -1, not "status" from unpack_loose_header()
 - object-file.c: guard against future bugs in loose_object_info()
 - object-file.c: stop dying in parse_loose_header()
 - object-file.c: split up ternary in parse_loose_header()
 - object-file.c: simplify unpack_loose_short_header()
 - object-file.c: add missing braces to loose_object_info()
 - object-file.c: make parse_loose_header_extended() public
 - object-file.c: don't set "typep" when returning non-zero
 - cache.h: move object functions to object-store.h
 - cat-file tests: test for current --allow-unknown-type behavior
 - cat-file tests: add corrupt loose object test
 - rev-list tests: test for behavior with invalid object types
 - cat-file tests: test that --allow-unknown-type isn't on by default
 - cat-file tests: test for missing object with -t and -s
 - fsck tests: add test for fsck-ing an unknown type
 - fsck tests: refactor one test to use a sub-repo

 "git fsck" has been taught to report mismatch between expected and
 actual types of an object better.

 Needs review.

--------------------------------------------------
[Discarded]

* ab/test-columns (2021-08-05) 3 commits
 . test-lib.sh: use GIT_TEST_COLUMNS over COLUMNS
 . test-lib-functions.sh: add a test_with_columns function
 . test-lib-functions.sh: rename test_must_fail_acceptable()

 Shells that adjust COLUMNS (e.g. bash with checkwinsize shell
 option), affect and break tests on progress meters and anything
 that depends on term_columns().  An test-only environment variable
 has been introduced as a workaround.

 Seems too involved for a last-minute fix.
 cf. <20210804212825.GH23408@szeder.dev>


* cb/reftable-fixup (2021-08-02) 3 commits
 . openbsd: allow reftable building with zlib 1.2.3
 . reftable: clarify zlib version dependency
 . fixup! Provide zlib's uncompress2 from compat/zlib-compat.c

 Fix-up for hn/reftable topic (no longer applicable).


* bc/inactive-submodules (2021-07-02) 1 commit
 . submodule: mark submodules with update=none as inactive

 Usability update for inactive submodules.

 Retracted for now.
 cf. <YRMpEV/uuHrxcOug@camp.crustytoothpaste.net>

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: What's cooking in git.git (Aug 2021, #06; Mon, 16)
  2021-08-16 23:06 What's cooking in git.git (Aug 2021, #06; Mon, 16) Junio C Hamano
@ 2021-08-16 23:43 ` Azeem Bande-Ali
  2021-08-17 16:39   ` Junio C Hamano
  2021-08-17 10:20 ` Phillip Wood
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 17+ messages in thread
From: Azeem Bande-Ali @ 2021-08-16 23:43 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git

On Mon, Aug 16, 2021 at 7:06 PM Junio C Hamano <gitster@pobox.com> wrote:

> * ab/help-autocorrect-prompt (2021-08-14) 1 commit
>  - help.c: help.autocorrect=prompt waits for user action
>
>  The logic for auto-correction of misspelt subcommands learned to go
>  interactive when the help.autocorrect configuration variable is set
>  to true.

Just a minor correction, the help.autocorrect configuration variable
has to be set to "prompt" for this behavior.

I wasn't sure if this description is propagated further (like in a
changelog) so thought it was better to point it out.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: What's cooking in git.git (Aug 2021, #06; Mon, 16)
  2021-08-16 23:06 What's cooking in git.git (Aug 2021, #06; Mon, 16) Junio C Hamano
  2021-08-16 23:43 ` Azeem Bande-Ali
@ 2021-08-17 10:20 ` Phillip Wood
  2021-08-17 17:00   ` Philippe Blain
       [not found]   ` <20210817193255.e7-9qhD5EZyGJNFbpSx2zPp6pXXRq5aMFbInG-_RoCk@z>
  2021-08-17 21:48 ` Junio C Hamano
                   ` (2 subsequent siblings)
  4 siblings, 2 replies; 17+ messages in thread
From: Phillip Wood @ 2021-08-17 10:20 UTC (permalink / raw)
  To: Junio C Hamano, git

On 17/08/2021 00:06, Junio C Hamano wrote:
> Here are the topics that have been cooking in my tree.  Commits
> prefixed with '+' are in 'next' (being in 'next' is a sign that a
> topic is stable enough to be used and are candidate to be in a
> future release).  Commits prefixed with '-' are only in 'seen',
> which means nothing more than that I have found them of interest for
> some reason (like "it may have hard-to-resolve conflicts with
> another topic already in flight" or "this may turn out to be
> useful").  Do not read too much into a topic being in (or not in)
> 'seen'.  The ones marked with '.' do not appear in any of the
> integration branches, but I am still holding onto them.
> 
> Git 2.33 (final) has been tagged.  As it was a shorter cycle that
> lasted only for 10 weeks, we may see some regression post release,
> so let's see how it goes for a few days before starting the next
> round.
> 
> * pw/rebase-skip-final-fix (2021-08-13) 3 commits
>   - rebase --continue: remove .git/MERGE_MSG
>   - rebase --apply: restore some tests
>   - t3403: fix commit authorship
> 
>   Checking out all the paths from HEAD during the last conflicted
>   step in "git rebase" and continuing would cause the step to be
>   skipped (which is expected), but leaves MERGE_HEAD file behind in
>   $GIT_DIR and confuses the next "git commit", which has been
>   corrected.
> 
>   Will merge to 'next'.

Thanks

> * lh/systemd-timers (2021-07-02) 3 commits
>   - maintenance: add support for systemd timers on Linux
>   - maintenance: `git maintenance run` learned `--scheduler=<scheduler>`
>   - cache.h: Introduce a generic "xdg_config_home_for(…)" function
> 
>   "git maintenance" scheduler learned to use systemd timers as a
>   possible backend.
> 
>   Waiting for reviews.

I'd really like to see this merged, there was some discussion a couple 
of weeks ago (cf <4aed0293-6a48-d370-3b72-496b7c631cb5@gmail.com>), it 
petered out but no one seemed to be objecting to merging it.

> * zh/cherry-pick-advice (2021-08-14) 1 commit
>   - cherry-pick: use better advice message
> 
>   The advice message that "git cherry-pick" gives when it asks
>   conflicted replay of a commit to be resolved by the end user has
>   been updated.

I think this is getting there now, I need to look at the tests in v5 but 
the changes to sequencer.c looked good to me.

> * jk/commit-edit-fixup-fix (2021-08-15) 1 commit
>   - commit: restore --edit when combined with --fixup
> 
>   "git commit --fixup" now works with "--edit" again, after it was
>   broken in v2.32.
> 
>   Will merge to 'next'?

Yes please, there was a new version posted at the weekend but I've just 
checked and you've already picked it up in seen.

Best Wishes

Phillip

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: What's cooking in git.git (Aug 2021, #06; Mon, 16)
  2021-08-16 23:43 ` Azeem Bande-Ali
@ 2021-08-17 16:39   ` Junio C Hamano
  0 siblings, 0 replies; 17+ messages in thread
From: Junio C Hamano @ 2021-08-17 16:39 UTC (permalink / raw)
  To: Azeem Bande-Ali; +Cc: git

Azeem Bande-Ali <me@azeemba.com> writes:

> On Mon, Aug 16, 2021 at 7:06 PM Junio C Hamano <gitster@pobox.com> wrote:
>
>> * ab/help-autocorrect-prompt (2021-08-14) 1 commit
>>  - help.c: help.autocorrect=prompt waits for user action
>>
>>  The logic for auto-correction of misspelt subcommands learned to go
>>  interactive when the help.autocorrect configuration variable is set
>>  to true.
>
> Just a minor correction, the help.autocorrect configuration variable
> has to be set to "prompt" for this behavior.

Thanks for your sharp eyes---you're absolutely correct.  Will fix.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: What's cooking in git.git (Aug 2021, #06; Mon, 16)
  2021-08-17 10:20 ` Phillip Wood
@ 2021-08-17 17:00   ` Philippe Blain
  2021-08-17 19:40     ` Junio C Hamano
       [not found]   ` <20210817193255.e7-9qhD5EZyGJNFbpSx2zPp6pXXRq5aMFbInG-_RoCk@z>
  1 sibling, 1 reply; 17+ messages in thread
From: Philippe Blain @ 2021-08-17 17:00 UTC (permalink / raw)
  To: phillip.wood, Junio C Hamano, git

Hi Junio and Phillip,

Le 2021-08-17 à 06:20, Phillip Wood a écrit :
> On 17/08/2021 00:06, Junio C Hamano wrote:
>>
>> * pw/rebase-skip-final-fix (2021-08-13) 3 commits
>>   - rebase --continue: remove .git/MERGE_MSG
>>   - rebase --apply: restore some tests
>>   - t3403: fix commit authorship
>>
>>   Checking out all the paths from HEAD during the last conflicted
>>   step in "git rebase" and continuing would cause the step to be
>>   skipped (which is expected), but leaves MERGE_HEAD file behind in

This should be MERGE_MSG, no ?

>>   $GIT_DIR and confuses the next "git commit", which has been
>>   corrected.
>>
>>   Will merge to 'next'.
> 

Philippe.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: What's cooking in git.git (Aug 2021, #06; Mon, 16)
  2021-08-17 19:32     ` Junio C Hamano
@ 2021-08-17 17:12       ` Derrick Stolee
  2021-08-18  5:15         ` Eric Sunshine
  2021-08-19 10:06       ` Phillip Wood
  1 sibling, 1 reply; 17+ messages in thread
From: Derrick Stolee @ 2021-08-17 17:12 UTC (permalink / raw)
  To: Junio C Hamano, Phillip Wood; +Cc: git, Lénaïc Huard

On 8/17/2021 12:47 PM, Junio C Hamano wrote:
> Phillip Wood <phillip.wood123@gmail.com> writes:
...
>>> * lh/systemd-timers (2021-07-02) 3 commits
>>>   - maintenance: add support for systemd timers on Linux
>>>   - maintenance: `git maintenance run` learned `--scheduler=<scheduler>`
>>>   - cache.h: Introduce a generic "xdg_config_home_for(…)" function
>>>   "git maintenance" scheduler learned to use systemd timers as a
>>>   possible backend.
>>>   Waiting for reviews.
>>
>> I'd really like to see this merged, there was some discussion a couple
>> of weeks ago (cf <4aed0293-6a48-d370-3b72-496b7c631cb5@gmail.com>), it 
>> petered out but no one seemed to be objecting to merging it.
> 
> Thanks for paying attention to this item.
> 
> My impression was that everybody likes the ability to use systemd
> timers as an alternative to cron, but as Derrick summarised in the
> message you pointed at, I think the implementation is not quite
> there.
> 
> So "Waiting for reviews" is a mislabel; we are waiting for a reroll.
I think a lot of our comments were "We would hold an established
contributor to a higher standard, but this is sufficient for a new
contributor. The rest can be forward-fixed." We also have not heard
from the original contributor since that discussion.

Perhaps enough time has passed that we can expect Lénaïc will not
get back to us, I could give an attempt to forward-fix the comments
with a patch series on top of these. We could then hold
lh/systemd-timers in 'next' (or even 'seen') until it can be joined
with those fixes.

If preferred, I could restart the series by inserting some patches
and editing some of the ones in the list currently.

Thanks,
-Stolee

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: What's cooking in git.git (Aug 2021, #06; Mon, 16)
       [not found]   ` <20210817193255.e7-9qhD5EZyGJNFbpSx2zPp6pXXRq5aMFbInG-_RoCk@z>
@ 2021-08-17 19:32     ` Junio C Hamano
  2021-08-17 17:12       ` Derrick Stolee
  2021-08-19 10:06       ` Phillip Wood
  0 siblings, 2 replies; 17+ messages in thread
From: Junio C Hamano @ 2021-08-17 19:32 UTC (permalink / raw)
  To: Phillip Wood; +Cc: git, Lénaïc Huard, Joel Klinghed, ZheNing Hu

Phillip Wood <phillip.wood123@gmail.com> writes:

>> * pw/rebase-skip-final-fix (2021-08-13) 3 commits
>>   - rebase --continue: remove .git/MERGE_MSG
>>   - rebase --apply: restore some tests
>>   - t3403: fix commit authorship
>>   Checking out all the paths from HEAD during the last conflicted
>>   step in "git rebase" and continuing would cause the step to be
>>   skipped (which is expected), but leaves MERGE_HEAD file behind in
>>   $GIT_DIR and confuses the next "git commit", which has been
>>   corrected.
>>   Will merge to 'next'.
>
> Thanks

Thank *you* for the series, and you do not need to comment on your
topic only to say that.  But if you need to _stop_ me from merging a
topic to 'next' (because you want to replace it one more time, or
you see something wrong with it), please don't hesitate to do so.

>> * lh/systemd-timers (2021-07-02) 3 commits
>>   - maintenance: add support for systemd timers on Linux
>>   - maintenance: `git maintenance run` learned `--scheduler=<scheduler>`
>>   - cache.h: Introduce a generic "xdg_config_home_for(…)" function
>>   "git maintenance" scheduler learned to use systemd timers as a
>>   possible backend.
>>   Waiting for reviews.
>
> I'd really like to see this merged, there was some discussion a couple
> of weeks ago (cf <4aed0293-6a48-d370-3b72-496b7c631cb5@gmail.com>), it 
> petered out but no one seemed to be objecting to merging it.

Thanks for paying attention to this item.

My impression was that everybody liked the ability to use systemd
timers as an alternative to cron, but as Derrick summarised in the
message you pointed at, the implementation is not quite there, I
think.

So "Waiting for reviews" was a mislabel; we are waiting for a
reroll.

>> * zh/cherry-pick-advice (2021-08-14) 1 commit
>>   - cherry-pick: use better advice message
>>   The advice message that "git cherry-pick" gives when it asks
>>   conflicted replay of a commit to be resolved by the end user has
>>   been updated.
>
> I think this is getting there now, I need to look at the tests in v5
> but the changes to sequencer.c looked good to me.

Yes.

>> * jk/commit-edit-fixup-fix (2021-08-15) 1 commit
>>   - commit: restore --edit when combined with --fixup
>>   "git commit --fixup" now works with "--edit" again, after it was
>>   broken in v2.32.
>>   Will merge to 'next'?
>
> Yes please, there was a new version posted at the weekend but I've
> just checked and you've already picked it up in seen.

Yes, this looked good to me, too.

Thanks.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: What's cooking in git.git (Aug 2021, #06; Mon, 16)
  2021-08-17 17:00   ` Philippe Blain
@ 2021-08-17 19:40     ` Junio C Hamano
  0 siblings, 0 replies; 17+ messages in thread
From: Junio C Hamano @ 2021-08-17 19:40 UTC (permalink / raw)
  To: Philippe Blain; +Cc: phillip.wood, git

Philippe Blain <levraiphilippeblain@gmail.com> writes:

> Hi Junio and Phillip,
>
> Le 2021-08-17 à 06:20, Phillip Wood a écrit :
>> On 17/08/2021 00:06, Junio C Hamano wrote:
>>>
>>> * pw/rebase-skip-final-fix (2021-08-13) 3 commits
>>>   - rebase --continue: remove .git/MERGE_MSG
>>>   - rebase --apply: restore some tests
>>>   - t3403: fix commit authorship
>>>
>>>   Checking out all the paths from HEAD during the last conflicted
>>>   step in "git rebase" and continuing would cause the step to be
>>>   skipped (which is expected), but leaves MERGE_HEAD file behind in
>
> This should be MERGE_MSG, no ?

Yup, you're absolutely right.  Will update.

>>>   $GIT_DIR and confuses the next "git commit", which has been
>>>   corrected.
>>>
>>>   Will merge to 'next'.
>> 
>
> Philippe.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: What's cooking in git.git (Aug 2021, #06; Mon, 16)
  2021-08-16 23:06 What's cooking in git.git (Aug 2021, #06; Mon, 16) Junio C Hamano
  2021-08-16 23:43 ` Azeem Bande-Ali
  2021-08-17 10:20 ` Phillip Wood
@ 2021-08-17 21:48 ` Junio C Hamano
  2021-08-19 18:55 ` Phillip Wood
  2021-08-20  6:09 ` Giving priority to the reftable topic (was Re: What's cooking in git.git (Aug 2021, #06; Mon, 16)) Junio C Hamano
  4 siblings, 0 replies; 17+ messages in thread
From: Junio C Hamano @ 2021-08-17 21:48 UTC (permalink / raw)
  To: git

Junio C Hamano <gitster@pobox.com> writes:

> Git 2.33 (final) has been tagged.  As it was a shorter cycle that
> lasted only for 10 weeks, we may see some regression post release,
> so let's see how it goes for a few days before starting the next
> round.

Those with eagle-eyes may have noticed that tinyurl.com/gitCal marks
this week as "2.33 fix-up week".

I'll give priority to reports of regression, and better yet, patches
that fixes them.  I'd appreciate others to do the same.

The next up in the priority order are patches that replace topics
that have been in 'next', but I expect it to be rare.

Thanks.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: What's cooking in git.git (Aug 2021, #06; Mon, 16)
  2021-08-17 17:12       ` Derrick Stolee
@ 2021-08-18  5:15         ` Eric Sunshine
  0 siblings, 0 replies; 17+ messages in thread
From: Eric Sunshine @ 2021-08-18  5:15 UTC (permalink / raw)
  To: Derrick Stolee
  Cc: Junio C Hamano, Phillip Wood, Git List, Lénaïc Huard

On Tue, Aug 17, 2021 at 1:13 PM Derrick Stolee <stolee@gmail.com> wrote:
> On 8/17/2021 12:47 PM, Junio C Hamano wrote:
> > Phillip Wood <phillip.wood123@gmail.com> writes:
> >>> * lh/systemd-timers (2021-07-02) 3 commits
> >>>   Waiting for reviews.
> >>
> >> I'd really like to see this merged, there was some discussion a couple
> >> of weeks ago (cf <4aed0293-6a48-d370-3b72-496b7c631cb5@gmail.com>), it
> >> petered out but no one seemed to be objecting to merging it.
> >
> > Thanks for paying attention to this item.
> >
> > My impression was that everybody likes the ability to use systemd
> > timers as an alternative to cron, but as Derrick summarised in the
> > message you pointed at, I think the implementation is not quite
> > there.
> >
> > So "Waiting for reviews" is a mislabel; we are waiting for a reroll.
>
> I think a lot of our comments were "We would hold an established
> contributor to a higher standard, but this is sufficient for a new
> contributor. The rest can be forward-fixed." We also have not heard
> from the original contributor since that discussion.

Yes, this summarizes the situation well. I gave v6 a thorough
readthrough and although I found a single minor test-time bug -- which
Lénaïc addressed in v7 -- there were no show-stoppers at all. Although
there may be a few warts in v7 (such as non-ASCII comment blocks) they
are minor and can be addressed by follow-on patches (from anyone who
steps up, not necessarily Lénaïc who, as a relative newcomer, has
patiently re-rolled repeatedly).

> Perhaps enough time has passed that we can expect Lénaïc will not
> get back to us, I could give an attempt to forward-fix the comments
> with a patch series on top of these. We could then hold
> lh/systemd-timers in 'next' (or even 'seen') until it can be joined
> with those fixes.
>
> If preferred, I could restart the series by inserting some patches
> and editing some of the ones in the list currently.

That would be nice. It would be good to see this series land.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: What's cooking in git.git (Aug 2021, #06; Mon, 16)
  2021-08-17 19:32     ` Junio C Hamano
  2021-08-17 17:12       ` Derrick Stolee
@ 2021-08-19 10:06       ` Phillip Wood
  1 sibling, 0 replies; 17+ messages in thread
From: Phillip Wood @ 2021-08-19 10:06 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git

Hi Junio

On 17/08/2021 20:32, Junio C Hamano wrote:
> Phillip Wood <phillip.wood123@gmail.com> writes:
> 
>>> * pw/rebase-skip-final-fix (2021-08-13) 3 commits
>>>    - rebase --continue: remove .git/MERGE_MSG
>>>    - rebase --apply: restore some tests
>>>    - t3403: fix commit authorship
>>>    Checking out all the paths from HEAD during the last conflicted
>>>    step in "git rebase" and continuing would cause the step to be
>>>    skipped (which is expected), but leaves MERGE_HEAD file behind in
>>>    $GIT_DIR and confuses the next "git commit", which has been
>>>    corrected.
>>>    Will merge to 'next'.
>>
>> Thanks
> 
> Thank *you* for the series, and you do not need to comment on your
> topic only to say that.  But if you need to _stop_ me from merging a
> topic to 'next' (because you want to replace it one more time, or
> you see something wrong with it), please don't hesitate to do so.

Sure, I would not have replied just to say thanks but as I was writing 
anyway I thought I would.

Best Wishes

Phillip

>>> * lh/systemd-timers (2021-07-02) 3 commits
>>>    - maintenance: add support for systemd timers on Linux
>>>    - maintenance: `git maintenance run` learned `--scheduler=<scheduler>`
>>>    - cache.h: Introduce a generic "xdg_config_home_for(…)" function
>>>    "git maintenance" scheduler learned to use systemd timers as a
>>>    possible backend.
>>>    Waiting for reviews.
>>
>> I'd really like to see this merged, there was some discussion a couple
>> of weeks ago (cf <4aed0293-6a48-d370-3b72-496b7c631cb5@gmail.com>), it
>> petered out but no one seemed to be objecting to merging it.
> 
> Thanks for paying attention to this item.
> 
> My impression was that everybody liked the ability to use systemd
> timers as an alternative to cron, but as Derrick summarised in the
> message you pointed at, the implementation is not quite there, I
> think.
> 
> So "Waiting for reviews" was a mislabel; we are waiting for a
> reroll.
> 
>>> * zh/cherry-pick-advice (2021-08-14) 1 commit
>>>    - cherry-pick: use better advice message
>>>    The advice message that "git cherry-pick" gives when it asks
>>>    conflicted replay of a commit to be resolved by the end user has
>>>    been updated.
>>
>> I think this is getting there now, I need to look at the tests in v5
>> but the changes to sequencer.c looked good to me.
> 
> Yes.
> 
>>> * jk/commit-edit-fixup-fix (2021-08-15) 1 commit
>>>    - commit: restore --edit when combined with --fixup
>>>    "git commit --fixup" now works with "--edit" again, after it was
>>>    broken in v2.32.
>>>    Will merge to 'next'?
>>
>> Yes please, there was a new version posted at the weekend but I've
>> just checked and you've already picked it up in seen.
> 
> Yes, this looked good to me, too.
> 
> Thanks.
> 


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: What's cooking in git.git (Aug 2021, #06; Mon, 16)
  2021-08-16 23:06 What's cooking in git.git (Aug 2021, #06; Mon, 16) Junio C Hamano
                   ` (2 preceding siblings ...)
  2021-08-17 21:48 ` Junio C Hamano
@ 2021-08-19 18:55 ` Phillip Wood
  2021-08-19 19:38   ` Junio C Hamano
  2021-08-20  6:09 ` Giving priority to the reftable topic (was Re: What's cooking in git.git (Aug 2021, #06; Mon, 16)) Junio C Hamano
  4 siblings, 1 reply; 17+ messages in thread
From: Phillip Wood @ 2021-08-19 18:55 UTC (permalink / raw)
  To: Junio C Hamano, git

On 17/08/2021 00:06, Junio C Hamano wrote:
> Here are the topics that have been cooking in my tree.  Commits
> prefixed with '+' are in 'next' (being in 'next' is a sign that a
> topic is stable enough to be used and are candidate to be in a
> future release).  Commits prefixed with '-' are only in 'seen',
> which means nothing more than that I have found them of interest for
> some reason (like "it may have hard-to-resolve conflicts with
> another topic already in flight" or "this may turn out to be
> useful").  Do not read too much into a topic being in (or not in)
> 'seen'.  The ones marked with '.' do not appear in any of the
> integration branches, but I am still holding onto them.
> 
> * pw/diff-color-moved-fix (2021-08-05) 13 commits
>    (merged to 'next' on 2021-08-05 at 7b5e312aac)
>   + diff: drop unused options parameter from cmp_in_block_with_wsd()
>    (merged to 'next' on 2021-08-04 at 4de4a451e0)
>   + diff --color-moved: intern strings
>   + diff: use designated initializers for emitted_diff_symbol
>   + diff --color-moved-ws=allow-indentation-change: improve hash lookups
>   + diff --color-moved: stop clearing potential moved blocks
>   + diff --color-moved: shrink potential moved blocks as we go
>   + diff --color-moved: unify moved block growth functions
>   + diff --color-moved: call comparison function directly
>   + diff --color-moved-ws=allow-indentation-change: simplify and optimize
>   + diff: simplify allow-indentation-change delta calculation
>   + diff --color-moved: avoid false short line matches and bad zerba coloring
>   + diff --color-moved=zebra: fix alternate coloring
>   + diff --color-moved: add perf tests
> 
>   Long-overdue correctness and performance update to "diff
>   --color-moved" feature.
> 
>   Will cook in 'next'.

I found a couple of regressions in diff 
--color-moved=allow-indention-change with this series today. One of them 
is a simple fix, but I think I will need a bit of time to understand the 
other (there's a change to the way it handles lines consisting of 
'\f\n'). Would it be possible to kick this out of next when you rewind 
it please.

Thanks

Phillip

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: What's cooking in git.git (Aug 2021, #06; Mon, 16)
  2021-08-19 18:55 ` Phillip Wood
@ 2021-08-19 19:38   ` Junio C Hamano
  0 siblings, 0 replies; 17+ messages in thread
From: Junio C Hamano @ 2021-08-19 19:38 UTC (permalink / raw)
  To: Phillip Wood; +Cc: git

Phillip Wood <phillip.wood123@gmail.com> writes:

>> * pw/diff-color-moved-fix (2021-08-05) 13 commits
>> ...
>
> I found a couple of regressions in diff
> --color-moved=allow-indention-change with this series today. One of
> them is a simple fix, but I think I will need a bit of time to
> understand the other (there's a change to the way it handles lines
> consisting of '\f\n'). Would it be possible to kick this out of next
> when you rewind it please.

Will do.  Thanks for a heads-up.


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Giving priority to the reftable topic (was Re: What's cooking in git.git (Aug 2021, #06; Mon, 16))
  2021-08-16 23:06 What's cooking in git.git (Aug 2021, #06; Mon, 16) Junio C Hamano
                   ` (3 preceding siblings ...)
  2021-08-19 18:55 ` Phillip Wood
@ 2021-08-20  6:09 ` Junio C Hamano
  2021-08-20 22:08   ` Ramsay Jones
       [not found]   ` <CACBZZX41gwo=pv_4fn2VcLz0Qq7Av-CWsnNXfXSuzmwZnu-Q3w@mail.gmail.com>
  4 siblings, 2 replies; 17+ messages in thread
From: Junio C Hamano @ 2021-08-20  6:09 UTC (permalink / raw)
  To: Han-Wen Nienhuys, Ævar Arnfjörð Bjarmason,
	Jeff King, Carlo Marcelo Arenas Belón
  Cc: git

Junio C Hamano <gitster@pobox.com> writes:

> * hn/reftable (2021-08-16) 25 commits
>  - t1404: annotate test cases with REFFILES
>  ...
>  - hash.h: provide constants for the hash IDs
>
>  The "reftable" backend for the refs API.

As discussed in the thread that leads to [*1*], this topic has been
blocked by the "clean-up errno use in the refs subsystem" topic for
too long.  I think it deserves to have its own chance to be looked
at by more eyes.

I've reverted the three topics around "errno" out of 'next', while
rebasing them into a single strand of pearls, and queued them near
the tip of 'seen'.  The hn/reftable topic is merged into 'seen' 
earlier then these "errno" topics.

'seen' that has this topic, without merging known CI breakers (the
three "errno" topics are known to break when they are with the
hn/reftable topic, and the "builtin fsmonitor" also breaks CI),
passes the usual tests [*2*], except for the "pedantic" test we
recently added [*3*].

The breakage flagged by the compiler are all:

	char *fn = get_tmp_template(__FUNCTION__);

where the code expects that __FUNCTION__ is unconditionally
available.

With that problem fixed (which I would imagine should be easier than
brain surgery), we should be able to move the topic lower in 'seen',
hopefully touching 'next' soon to give it a wider exposure.

And when hn/reftable gets stable enough, the "errno clean-up" topic
can perhaps be rebased on top of it to work better together.

Thanks.


[Reference]

*1* https://lore.kernel.org/git/xmqqbl5syhiu.fsf@gitster.g/

*2* https://github.com/git/git/actions/runs/1148914175

*3* https://github.com/git/git/runs/3377289487?check_suite_focus=true#step:5:639

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: Giving priority to the reftable topic (was Re: What's cooking in git.git (Aug 2021, #06; Mon, 16))
  2021-08-20  6:09 ` Giving priority to the reftable topic (was Re: What's cooking in git.git (Aug 2021, #06; Mon, 16)) Junio C Hamano
@ 2021-08-20 22:08   ` Ramsay Jones
  2021-10-07 17:27     ` Han-Wen Nienhuys
       [not found]   ` <CACBZZX41gwo=pv_4fn2VcLz0Qq7Av-CWsnNXfXSuzmwZnu-Q3w@mail.gmail.com>
  1 sibling, 1 reply; 17+ messages in thread
From: Ramsay Jones @ 2021-08-20 22:08 UTC (permalink / raw)
  To: Junio C Hamano, Han-Wen Nienhuys,
	Ævar Arnfjörð Bjarmason, Jeff King,
	Carlo Marcelo Arenas Belón
  Cc: git



On 20/08/2021 07:09, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
> 
>> * hn/reftable (2021-08-16) 25 commits
>>  - t1404: annotate test cases with REFFILES
>>  ...
>>  - hash.h: provide constants for the hash IDs
>>
>>  The "reftable" backend for the refs API.
> 
> As discussed in the thread that leads to [*1*], this topic has been
> blocked by the "clean-up errno use in the refs subsystem" topic for
> too long.  I think it deserves to have its own chance to be looked
> at by more eyes.
> 
> I've reverted the three topics around "errno" out of 'next', while
> rebasing them into a single strand of pearls, and queued them near
> the tip of 'seen'.  The hn/reftable topic is merged into 'seen' 
> earlier then these "errno" topics.

Just a gentle reminder that this topic tickles my 'static-check.pl'
script, like so:

  $ diff nsc ssc
  ...
  88a91,98
  > reftable/generic.o	- reftable_table_seek_log
  > reftable/merged.o	- reftable_merged_table_hash_id
  > reftable/merged.o	- reftable_merged_table_min_update_index
  > reftable/merged.o	- reftable_merged_table_seek_log_at
  > reftable/publicbasics.o	- reftable_set_alloc
  > reftable/reader.o	- reader_seek
  > reftable/reader.o	- reftable_reader_seek_log_at
  > reftable/stack.o	- reftable_stack_auto_compact
  ...
  $ 

Which is to say, all of the above symbols are defined (and called) in
the '.c' file corresponding to the given object file, but not called
anywhere outside that file. I have not even looked at those functions,
but (with the possible exception of reftable_set_alloc()) they don't
strike me as 'public API functions'. So, maybe they should be marked
as 'static'?

ATB,
Ramsay Jones



^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: Giving priority to the reftable topic    (was Re: What's cooking in git.git (Aug 2021, #06; Mon, 16))
       [not found]   ` <CACBZZX41gwo=pv_4fn2VcLz0Qq7Av-CWsnNXfXSuzmwZnu-Q3w@mail.gmail.com>
@ 2021-08-23 10:21     ` Ævar Arnfjörð Bjarmason
  0 siblings, 0 replies; 17+ messages in thread
From: Ævar Arnfjörð Bjarmason @ 2021-08-23 10:21 UTC (permalink / raw)
  To: Junio C Hamano
  Cc: Han-Wen Nienhuys, Jeff King, Carlo Marcelo Arenas Belón,
	Git Mailing List


On Fri, Aug 20 2021, Ævar Arnfjörð Bjarmason wrote:

> On Fri, Aug 20, 2021, 08:09 Junio C Hamano <gitster@pobox.com> wrote:
>
>  Junio C Hamano <gitster@pobox.com> writes:
>
>  > * hn/reftable (2021-08-16) 25 commits
>  >  - t1404: annotate test cases with REFFILES
>  >  ...
>  >  - hash.h: provide constants for the hash IDs
>  >
>  >  The "reftable" backend for the refs API.
>
>  As discussed in the thread that leads to [*1*], this topic has been
>  blocked by the "clean-up errno use in the refs subsystem" topic for
>  too long.  I think it deserves to have its own chance to be looked
>  at by more eyes.
>
>  I've reverted the three topics around "errno" out of 'next', while
>  rebasing them into a single strand of pearls, and queued them near
>  the tip of 'seen'.  The hn/reftable topic is merged into 'seen' 
>  earlier then these "errno" topics.
>
>  'seen' that has this topic, without merging known CI breakers (the
>  three "errno" topics are known to break when they are with the
>  hn/reftable topic, and the "builtin fsmonitor" also breaks CI),
>  passes the usual tests [*2*], except for the "pedantic" test we
>  recently added [*3*].
>
>  The breakage flagged by the compiler are all:
>
>          char *fn = get_tmp_template(__FUNCTION__);
>
>  where the code expects that __FUNCTION__ is unconditionally
>  available.
>
>  With that problem fixed (which I would imagine should be easier than
>  brain surgery), we should be able to move the topic lower in 'seen',
>  hopefully touching 'next' soon to give it a wider exposure.
>
>  And when hn/reftable gets stable enough, the "errno clean-up" topic
>  can perhaps be rebased on top of it to work better together.
>
>  Thanks.
>
> (In the Gmail app, so this'll probably not make the list, sorry, feel free to quote it)
>
> I've been on vacation for a couple of weeks, am back Monday.
>
> I haven't been able to look at these breakages in detail but it looked like there was a fix-up plus a logic error in reftable in combination with it with
> the now dead NULL parameter, perhaps something else I missed. I've only skimmed the list.
>
> I had a subsequent fixup topic ready on top to remove that parameter, can include in in a reroll. Then the segfault will be caught at compile time via a
> signature check.
>
> As I noted on list before we can do it with reftable first if you'd like, but I don't think the end result will be easier to review or should be fast
> tracked. We'll have the same questions about how reftable uses those ref APIs, but will need to review it against a basis that has more API action at a
> distance.
>
> So if you're willing to give me a few days I think d can sort it out to everyone's satisfaction with the refs API fixes first, if not I'll try to review
> the reftable topic again, but will probably use a local merger of it and my topics as the basis for that.

I should have a re-roll of these topics ready soon, but aside from the
broken-ness of my "base" topics I don't see how the reftable topic is
anywhere near ready for "next" per my
https://lore.kernel.org/git/877dgch4rn.fsf@evledraar.gmail.com/; whether
it's based on my "base" topics or not.

>  [Reference]
>
>  *1* https://lore.kernel.org/git/xmqqbl5syhiu.fsf@gitster.g/
>
>  *2* https://github.com/git/git/actions/runs/1148914175
>
>  *3* https://github.com/git/git/runs/3377289487?check_suite_focus=true#step:5:639


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: Giving priority to the reftable topic (was Re: What's cooking in git.git (Aug 2021, #06; Mon, 16))
  2021-08-20 22:08   ` Ramsay Jones
@ 2021-10-07 17:27     ` Han-Wen Nienhuys
  0 siblings, 0 replies; 17+ messages in thread
From: Han-Wen Nienhuys @ 2021-10-07 17:27 UTC (permalink / raw)
  To: Ramsay Jones
  Cc: Junio C Hamano, Ævar Arnfjörð Bjarmason,
	Jeff King, Carlo Marcelo Arenas Belón, git

On Sat, Aug 21, 2021 at 12:08 AM Ramsay Jones
<ramsay@ramsayjones.plus.com> wrote:
> Just a gentle reminder that this topic tickles my 'static-check.pl'
> script, like so:
>
>   $ diff nsc ssc
>   ...
>   88a91,98
>   > reftable/generic.o  - reftable_table_seek_log
>   > reftable/merged.o   - reftable_merged_table_hash_id
>   > reftable/merged.o   - reftable_merged_table_min_update_index
>   > reftable/merged.o   - reftable_merged_table_seek_log_at
>   > reftable/publicbasics.o     - reftable_set_alloc
>   > reftable/reader.o   - reader_seek
>   > reftable/reader.o   - reftable_reader_seek_log_at
>   > reftable/stack.o    - reftable_stack_auto_compact
>   ...
>   $
>
> Which is to say, all of the above symbols are defined (and called) in
> the '.c' file corresponding to the given object file, but not called
> anywhere outside that file. I have not even looked at those functions,
> but (with the possible exception of reftable_set_alloc()) they don't
> strike me as 'public API functions'. So, maybe they should be marked
> as 'static'?

They're all public except reader_seek().
I added some more coverage, in v4 of the library topic.

--
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado

^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2021-10-07 17:27 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-16 23:06 What's cooking in git.git (Aug 2021, #06; Mon, 16) Junio C Hamano
2021-08-16 23:43 ` Azeem Bande-Ali
2021-08-17 16:39   ` Junio C Hamano
2021-08-17 10:20 ` Phillip Wood
2021-08-17 17:00   ` Philippe Blain
2021-08-17 19:40     ` Junio C Hamano
     [not found]   ` <20210817193255.e7-9qhD5EZyGJNFbpSx2zPp6pXXRq5aMFbInG-_RoCk@z>
2021-08-17 19:32     ` Junio C Hamano
2021-08-17 17:12       ` Derrick Stolee
2021-08-18  5:15         ` Eric Sunshine
2021-08-19 10:06       ` Phillip Wood
2021-08-17 21:48 ` Junio C Hamano
2021-08-19 18:55 ` Phillip Wood
2021-08-19 19:38   ` Junio C Hamano
2021-08-20  6:09 ` Giving priority to the reftable topic (was Re: What's cooking in git.git (Aug 2021, #06; Mon, 16)) Junio C Hamano
2021-08-20 22:08   ` Ramsay Jones
2021-10-07 17:27     ` Han-Wen Nienhuys
     [not found]   ` <CACBZZX41gwo=pv_4fn2VcLz0Qq7Av-CWsnNXfXSuzmwZnu-Q3w@mail.gmail.com>
2021-08-23 10:21     ` Ævar Arnfjörð Bjarmason

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).