git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Andrey Bienkowski via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Andrey Bienkowski <hexagonrecursion@gmail.com>
Subject: Re: [PATCH] doc: clarify the filename encoding in git diff
Date: Mon, 19 Apr 2021 14:33:50 -0700	[thread overview]
Message-ID: <xmqqwnsy7ydd.fsf@gitster.g> (raw)
In-Reply-To: <pull.996.git.git.1618838856399.gitgitgadget@gmail.com> (Andrey Bienkowski via GitGitGadget's message of "Mon, 19 Apr 2021 13:27:35 +0000")

"Andrey Bienkowski via GitGitGadget" <gitgitgadget@gmail.com>
writes:

> Signed-off-by: Andrey Bienkowski <hexagonrecursion@gmail.com>
> ---
>     My takeaway was to always parse it as utf8 regardless of platform or
>     environment.
>     
>     Changes since v1:

I do not think the readers on the list have seen the "v1", but
anyway, the 

>      * Replace "always" with "often"

"often" here sound more measured than ...

>  --name-only::
> -	Show only names of changed files.
> +	Show only names of changed files. The file names are usually encoded in UTF-8.
> +	For more information see the discussion about encoding in the linkgit:git-log[1]
> +	manual page.

... "usually" here ...

>  --name-status::
>  	Show only names and status of changed files. See the description
>  	of the `--diff-filter` option on what the status letters mean.
> +	Just like `--name-only` the file names are usually encoded in UTF-8.

... and here.

Thanks.

  reply	other threads:[~2021-04-19 21:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-19 13:27 [PATCH] doc: clarify the filename encoding in git diff Andrey Bienkowski via GitGitGadget
2021-04-19 21:33 ` Junio C Hamano [this message]
2021-04-20 11:24 ` [PATCH v2] " Andrey Bienkowski via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqwnsy7ydd.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=hexagonrecursion@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).