git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Denton Liu <liu.denton@gmail.com>
Cc: Shourya Shukla <shouryashukla.oo@gmail.com>,
	git@vger.kernel.org, christian.couder@gmail.com, peff@peff.net,
	heba.waly@gmail.com
Subject: Re: [PATCH v2] submodule: port subcommand 'set-url' from shell to C
Date: Fri, 01 May 2020 11:54:57 -0700	[thread overview]
Message-ID: <xmqqwo5vlc3i.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200501100109.GA55820@generichostname> (Denton Liu's message of "Fri, 1 May 2020 06:01:09 -0400")

Denton Liu <liu.denton@gmail.com> writes:

> On Fri, May 01, 2020 at 01:02:32PM +0530, Shourya Shukla wrote:
>> This aims to convert submodule subcommand 'set-url' to a builtin.
>> 'set-url' is ported to 'submodule--helper.c' and the latter is called
>> via 'git-submodule.sh'.
>
> Commit messages should be written in imperative mood. This could be
> rewritten as
>
> 	Convert submodule subcommand 'set-url' to a builtin. Port
> 	'set-url' to 'submodule--helper.c' and call the latter via
> 	'git-submodule.sh'.
> ...
>>  		esac
>> -		shift
>
> Hmmm, I don't understand why the above hunk and this line are necessary.
>
> ...
>
> This looks good, though :)

Thanks for giving a pretty good review.  I think we covered many
issues pretty much the same way.


  reply	other threads:[~2020-05-01 18:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-01  7:32 [PATCH v2] submodule: port subcommand 'set-url' from shell to C Shourya Shukla
2020-05-01 10:01 ` Denton Liu
2020-05-01 18:54   ` Junio C Hamano [this message]
2020-05-01 18:27 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqwo5vlc3i.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=heba.waly@gmail.com \
    --cc=liu.denton@gmail.com \
    --cc=peff@peff.net \
    --cc=shouryashukla.oo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).