From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Elijah Newren <newren@gmail.com>,
Phillip Wood <phillip.wood@dunelm.org.uk>,
Elijah Newren via GitGitGadget <gitgitgadget@gmail.com>,
Git Mailing List <git@vger.kernel.org>,
Jonathan Nieder <jrnieder@gmail.com>,
Paul Gevers <elbrus@debian.org>,
Ian Jackson <ijackson@chiark.greenend.org.uk>,
Alban Gruin <alban.gruin@gmail.com>
Subject: Re: [PATCH] sequencer: honor GIT_REFLOG_ACTION
Date: Tue, 07 Apr 2020 16:05:00 -0700 [thread overview]
Message-ID: <xmqqwo6qrj6r.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.2004080037080.46@tvgsbejvaqbjf.bet> (Johannes Schindelin's message of "Wed, 8 Apr 2020 00:37:24 +0200 (CEST)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>> > FWIW I was also about to comment on that. Maybe that warrants even a code
>> > comment above the `prev_reflog_action`?
>>
>> Yeah, if it tripped you both up, I'll add such a comment to the code
>> to help explain it.
>
> Thank you!
Thanks, all.
next prev parent reply other threads:[~2020-04-07 23:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 20:31 [PATCH] sequencer: honor GIT_REFLOG_ACTION Elijah Newren via GitGitGadget
2020-04-01 20:46 ` Junio C Hamano
2020-04-01 23:29 ` Ian Jackson
2020-04-02 5:15 ` Elijah Newren
2020-04-02 9:39 ` Phillip Wood
2020-04-02 17:40 ` Elijah Newren
2020-04-02 9:25 ` Phillip Wood
2020-04-02 17:01 ` Elijah Newren
2020-04-02 19:05 ` Phillip Wood
2020-04-07 14:50 ` Johannes Schindelin
2020-04-07 15:18 ` Elijah Newren
2020-04-07 22:37 ` Johannes Schindelin
2020-04-07 23:05 ` Junio C Hamano [this message]
2020-04-07 16:59 ` [PATCH v2] " Elijah Newren via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwo6qrj6r.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=alban.gruin@gmail.com \
--cc=elbrus@debian.org \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=ijackson@chiark.greenend.org.uk \
--cc=jrnieder@gmail.com \
--cc=newren@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).