From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75037C3B1BF for ; Sun, 16 Feb 2020 23:34:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 32D692086A for ; Sun, 16 Feb 2020 23:34:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b="gGpGE52P" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726962AbgBPXeS (ORCPT ); Sun, 16 Feb 2020 18:34:18 -0500 Received: from pb-smtp1.pobox.com ([64.147.108.70]:56579 "EHLO pb-smtp1.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726059AbgBPXeR (ORCPT ); Sun, 16 Feb 2020 18:34:17 -0500 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id A094B57FDF; Sun, 16 Feb 2020 18:34:15 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=ylAgawULDd+FyMSRhC9GnY0QIRM=; b=gGpGE5 2P4ssJQzvGqnXFKAJ87tb/E1T53GjjnptpUSxVG6o/lHaRBdn76vG06moAyiibGL CU5xYcziM315ewn806iZyVEN30yhY+kcyuXNieVp9isfeXCQTd/T+VLUjAxPheZx OOIenAv1FnSzWqfxk+JHly/bOyaMzjNlTJ/P0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=q1rsTW10hpjAXkdU/4dPYq8u6j1XUNtW 99Y3fUa1eD8B+XpHzb5zDm9dTMZlPapQMlWKrw/DRBFfGDSP98UKu1z4NM9/S66r 3zoeTL/1xhMXHWovglX5DE52hBFNgebvGKhpXr1DKa7KgvbMzwYE1oANGfbQEPhF DAClrWmIuBM= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 9683757FDE; Sun, 16 Feb 2020 18:34:15 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.76.80.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id F052457FD3; Sun, 16 Feb 2020 18:34:14 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Jeff King Cc: Taylor Blau , git@vger.kernel.org Subject: Re: [PATCH v2 06/15] rev-list: make --count work with --objects References: <20200214182147.GA654525@coredump.intra.peff.net> <20200214182220.GF150965@coredump.intra.peff.net> <20200215004216.GA15192@syl.local> <20200215064818.GB1633703@coredump.intra.peff.net> Date: Sun, 16 Feb 2020 15:34:13 -0800 In-Reply-To: <20200215064818.GB1633703@coredump.intra.peff.net> (Jeff King's message of "Sat, 15 Feb 2020 01:48:18 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: D7CDB508-5114-11EA-B76B-C28CBED8090B-77302942!pb-smtp1.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Jeff King writes: >> > + if (revs->count) { >> > + revs->count_right++; >> > + return; >> > + } >> > + >> >> Hmm. This puzzled me at first. Do you think that it could benefit from a >> comment? > > What would it say (i.e., I'm not sure what confused you)? I think the question reader had was "why *right*?"