git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Johannes.Schindelin@gmx.de,
	plroskin@gmail.com, Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH 1/2] am: pay attention to user-defined context size
Date: Fri, 20 Dec 2019 11:28:02 -0800	[thread overview]
Message-ID: <xmqqwoaq94ql.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <e1870f3fee8be6ebbecdd618ae1803afb878e67e.1576868036.git.gitgitgadget@gmail.com> (Elijah Newren via GitGitGadget's message of "Fri, 20 Dec 2019 18:53:55 +0000")

"Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Elijah Newren <newren@gmail.com>
>
> am previously only checked gpg-related config options and the default
> config options while ignoring any diff-related options.  This meant that
> when users tried to set diff.context to something larger than the
> default value of 3, it was ignored.  Pay attention to the diff settings
> too.

Can the benefit brought in by this change demonstrated by a new test
or two?


Puzzled.  "am" accepts whatever patch somebody else prepared and
has no control over how the incoming "diff" was produced by that
somebody else.  

Besides, I do not think it should be affected by any diff_*UI*_config()
in the first place.

  reply	other threads:[~2019-12-20 19:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-20 18:53 [PATCH 0/2] Rebase am fixes Elijah Newren via GitGitGadget
2019-12-20 18:53 ` [PATCH 1/2] am: pay attention to user-defined context size Elijah Newren via GitGitGadget
2019-12-20 19:28   ` Junio C Hamano [this message]
2019-12-20 19:38     ` Elijah Newren
2019-12-20 22:22       ` Elijah Newren
2019-12-20 22:34         ` Junio C Hamano
2019-12-21  5:37           ` Elijah Newren
2019-12-20 18:53 ` [PATCH 2/2] rebase: fix saving of --signoff state for am-based rebases Elijah Newren via GitGitGadget
2019-12-20 19:29   ` Junio C Hamano
2020-01-01 22:01     ` Johannes Schindelin
2023-09-03 21:29 [PATCH 1/2] am: pay attention to user-defined context size tony raynes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqwoaq94ql.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=newren@gmail.com \
    --cc=plroskin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).