From: Junio C Hamano <gitster@pobox.com>
To: Rosen Penev <rosenp@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] imap-send: Fix compilation without deprecated OpenSSL APIs
Date: Wed, 26 Dec 2018 22:32:05 -0800 [thread overview]
Message-ID: <xmqqwonvpjiy.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20181227023548.396-1-rosenp@gmail.com> (Rosen Penev's message of "Wed, 26 Dec 2018 18:35:48 -0800")
Rosen Penev <rosenp@gmail.com> writes:
> Initialization in OpenSSL has been deprecated in version 1.1.
https://www.openssl.org/docs/man1.0.2/ssl/SSL_library_init.html says
SSL_library_init() must be called before any other action takes
place.
https://www.openssl.org/docs/man1.1.0/ssl/SSL_library_init.html says
the same.
Which makes it necessary for us to defend the following claim
> This makes
> compilation fail when deprecated APIs for OpenSSL are compile-time
> disabled.
as a valid problem description more rigorously. To me, the cursory
web-serfing I did above makes me suspect that an OpenSSL
implementation with such a compile-time disabling _is_ buggy, as it
forbids the API users to call an API function they are told to call
before doing anything else.
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
> imap-send.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/imap-send.c b/imap-send.c
> index b4eb886e2..21f741c8c 100644
> --- a/imap-send.c
> +++ b/imap-send.c
> @@ -284,8 +284,10 @@ static int ssl_socket_connect(struct imap_socket *sock, int use_tls_only, int ve
> int ret;
> X509 *cert;
>
> +#if (OPENSSL_VERSION_NUMBER < 0x10000000L)
https://www.openssl.org/docs/man1.1.0/crypto/OPENSSL_VERSION_NUMBER.html
says that OPENSSL_VERSION_NUMBER is of form 0xMNNFFPPS where M is
major, NN is minor, FF is fix, PP is patch and S is status, and
gives an example that 0x00906023 stands for 0.9.6.b beta 3 (M=0,
NN=09, FF=06, PP=02 and S=3). So "< 0x10000000L" means "anything
with M smaller than 1". IOW, we would no longer call _init() for
e.g. "version 1.0.0 beta 0". That contradicts with the first claim
of the proposed log message ("deprecated in 1.1" implying that it is
not yet deprecated in say 1.0.2).
> SSL_library_init();
> SSL_load_error_strings();
> +#endif
>
> meth = SSLv23_method();
> if (!meth) {
next prev parent reply other threads:[~2018-12-27 6:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-27 2:35 [PATCH] imap-send: Fix compilation without deprecated OpenSSL APIs Rosen Penev
2018-12-27 6:32 ` Junio C Hamano [this message]
2018-12-27 17:55 ` Rosen Penev
2018-12-28 19:20 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwonvpjiy.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).