From: Junio C Hamano <gitster@pobox.com>
To: "Stephen P. Smith" <ischis2@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3 4/4] wt-status.c: Set the committable flag in the collect phase.
Date: Tue, 11 Sep 2018 10:22:26 -0700 [thread overview]
Message-ID: <xmqqworsosod.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <1827990.xjSgEIESZI@thunderbird> (Stephen P. Smith's message of "Fri, 07 Sep 2018 16:55:41 -0700")
"Stephen P. Smith" <ischis2@cox.net> writes:
> On Friday, September 7, 2018 3:31:55 PM MST you wrote:
>> Junio C Hamano <gitster@pobox.com> writes:
>
>> The patch is mostly for illustration of the idea.
>>
>> The result seems to compile and pass the test suite, but I haven't
>> carefully thought about what else I may be breaking with this
>> mechanical change. For example, I noticed that both of the old
>> callsites of wt_status_get_state() have free() of a few fiedls in
>> the structure, and I kept the code as close to the original, but I
>> suspect they should not be freed there in the functions in the
>> "print" phase, but rather the caller of the "collect" and "print"
>> should be made responsible for deciding when to dispose the entire
>> wt_status (and wt_status_state as part of it). This illustration
>> patch does not address that kind of details (yet).
>
> If we use this as a basis of a follow on patch, how do I handle credit. You
> obviously wrote this patch and I did not.
Often people just mention "This was based on an earlier work by ..."
at/near the end of the log message. When the result ends up to be
very different from the earlier work, just adding "Helped-by: ..."
before your sign-off is often sufficient.
next prev parent reply other threads:[~2018-09-11 17:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 0:53 [PATCH v3 0/4] wt-status.c: commitable flag Stephen P. Smith
2018-09-06 0:53 ` [PATCH v3 1/4] Move has_unmerged earlier in the file Stephen P. Smith
2018-09-06 0:53 ` [PATCH v3 2/4] wt-status: rename commitable to committable Stephen P. Smith
2018-09-07 21:38 ` Junio C Hamano
2018-09-06 0:53 ` [PATCH v3 3/4] t7501: add test of "commit --dry-run --short" Stephen P. Smith
2018-09-06 0:53 ` [PATCH v3 4/4] wt-status.c: Set the committable flag in the collect phase Stephen P. Smith
2018-09-07 22:01 ` Junio C Hamano
2018-09-07 22:31 ` Junio C Hamano
2018-09-28 4:49 ` [PATCH 0/1] wt-status-state-cleanup Stephen P. Smith
2018-09-28 4:49 ` [PATCH 1/1] roll wt_status_state into wt_status and populate in the collect phase Stephen P. Smith
2018-09-28 13:55 ` Taylor Blau
2018-09-28 18:34 ` Junio C Hamano
2018-09-29 18:55 ` [PATCH v2 0/1] wt-status-state-cleanup Stephen P. Smith
2018-09-29 18:55 ` [PATCH v2 1/1] roll wt_status_state into wt_status and populate in the collect phase Stephen P. Smith
2018-09-30 4:41 ` Eric Sunshine
2018-09-30 14:12 ` [PATCH v3 0/1] wt-status-state-cleanup Stephen P. Smith
2018-09-30 14:12 ` [PATCH v3 1/1] roll wt_status_state into wt_status and populate in the collect phase Stephen P. Smith
2018-09-30 4:40 ` [PATCH " Eric Sunshine
2018-09-07 23:55 ` [PATCH v3 4/4] wt-status.c: Set the committable flag " Stephen P. Smith
2018-09-11 17:22 ` Junio C Hamano [this message]
2018-09-24 3:15 ` Stephen Smith
2018-09-24 21:02 ` Junio C Hamano
2018-09-06 7:38 ` [PATCH v3 0/4] wt-status.c: commitable flag Ævar Arnfjörð Bjarmason
2018-09-06 16:06 ` Stephen & Linda Smith
2018-09-07 21:40 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqworsosod.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ischis2@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).