From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: "Jeff King" <peff@peff.net>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
git@vger.kernel.org, "Eric Sunshine" <sunshine@sunshineco.com>,
"Carlo Arenas" <carenas@gmail.com>
Subject: Re: [PATCH v2 1/1] git-compat-util: add a test balloon for C99 support
Date: Thu, 18 Nov 2021 11:10:49 -0800 [thread overview]
Message-ID: <xmqqy25lwa86.fsf@gitster.g> (raw)
In-Reply-To: <YZWNumAlsek9Gi22@camp.crustytoothpaste.net> (brian m. carlson's message of "Wed, 17 Nov 2021 23:18:18 +0000")
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
> On 2021-11-17 at 03:01:57, Jeff King wrote:
>> Yes, but I'm not at all worried about breaking our CI. That's just a
>> patch away from fixing. I'm much more worried about confused users
>> building from source, because helping them is more difficult to scale.
>
> That's one of the reasons I had proposed the current patch, because it
> pukes in a very noticeable way with directives on where to look to
> continue. Just using C99 features means that Git breaks in a very
> subtle way where the user compiling may not be familiar with C and may
> not know how to fix it otherwise. For example, my previous employer
> ships Git, but many of the folks who are doing the package updates are
> not C programmers.
I wonder if this would work, then.
Makefile | 3 ++-
revision.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git c/Makefile w/Makefile
index 201437e9d4..454118d86b 100644
--- c/Makefile
+++ w/Makefile
@@ -1218,7 +1218,8 @@ endif
# Set CFLAGS, LDFLAGS and other *FLAGS variables. These might be
# tweaked by config.* below as well as the command-line, both of
# which'll override these defaults.
-CFLAGS = -g -O2 -Wall -std=gnu99
+# Older versions of GCC may require adding "-std=gnu99" at the end.
+CFLAGS = -g -O2 -Wall
LDFLAGS =
CC_LD_DYNPATH = -Wl,-rpath,
BASIC_CFLAGS = -I.
diff --git c/revision.c w/revision.c
index 78c1ceea7b..5390a479b3 100644
--- c/revision.c
+++ w/revision.c
@@ -49,7 +49,8 @@ void show_object_with_name(FILE *out, struct object *obj, const char *name)
* This "for (const char *p = ..." is made as a first step towards
* making use of such declarations elsewhere in our codebase. If
* it causes compilation problems on your platform, please report
- * it to the Git mailing list at git@vger.kernel.org.
+ * it to the Git mailing list at git@vger.kernel.org. In the meantime,
+ * adding -std=gnu99 to CFLAGS may help if you are with older GCC.
*/
for (const char *p = name; *p && *p != '\n'; p++)
fputc(*p, out);
next prev parent reply other threads:[~2021-11-18 19:10 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-14 21:24 [PATCH 0/1] Add a test balloon for C99 brian m. carlson
2021-11-14 21:24 ` [PATCH 1/1] git-compat-util: add a test balloon for C99 support brian m. carlson
2021-11-15 1:14 ` Ævar Arnfjörð Bjarmason
2021-11-15 1:54 ` brian m. carlson
2021-11-15 3:16 ` Eric Sunshine
2021-11-16 1:53 ` brian m. carlson
2021-11-22 11:47 ` Johannes Schindelin
2021-11-14 21:43 ` [PATCH 0/1] Add a test balloon for C99 brian m. carlson
2021-11-15 7:00 ` Junio C Hamano
2021-11-15 22:41 ` brian m. carlson
2021-11-16 19:02 ` Junio C Hamano
2021-11-17 1:51 ` brian m. carlson
2021-11-16 2:12 ` [PATCH v2 0/1] Add a test balloon for C99 support brian m. carlson
2021-11-16 2:12 ` [PATCH v2 1/1] git-compat-util: add " brian m. carlson
2021-11-16 12:19 ` Jeff King
2021-11-16 12:54 ` Ævar Arnfjörð Bjarmason
2021-11-16 14:54 ` Jeff King
2021-11-17 2:53 ` brian m. carlson
2021-11-17 3:01 ` Jeff King
2021-11-17 23:18 ` brian m. carlson
2021-11-17 23:45 ` Carlo Arenas
2021-11-18 2:26 ` Ævar Arnfjörð Bjarmason
2021-11-18 19:10 ` Junio C Hamano [this message]
2021-11-17 8:49 ` Junio C Hamano
2021-11-16 19:44 ` Phillip Wood
2021-11-17 1:44 ` brian m. carlson
2021-11-17 2:58 ` Jeff King
2021-11-30 20:43 ` Microsoft's C language policy (was: [PATCH 0/1] Add a test balloon for C99) Ævar Arnfjörð Bjarmason
2021-11-30 22:37 ` brian m. carlson
2021-12-01 1:40 ` [PATCH v3 0/1] Add a test balloon for C99 support brian m. carlson
2021-12-01 1:40 ` [PATCH v3 1/1] git-compat-util: add " brian m. carlson
2021-12-02 17:38 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy25lwa86.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).