From: Junio C Hamano <gitster@pobox.com>
To: Naveen Nathan <naveen@lastninja.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] doc: improve readability of --rebase-merges in git-rebase
Date: Tue, 12 Nov 2019 13:18:17 +0900 [thread overview]
Message-ID: <xmqqy2wlg22e.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20191111232137.GA29586@a.local> (Naveen Nathan's message of "Tue, 12 Nov 2019 10:21:37 +1100")
Naveen Nathan <naveen@lastninja.net> writes:
> When --preserve-merges was deprecated in 427c3bd28a a sentence
> was introduced describing the difference between --rebase-merges and
> --preserve-merges which is a little unclear and difficult to parse.
> This patch improves readability while retaining original meaning.
I notice that the above also was rewritten since v1 and I think it
is a very good change.
Thanks, will queue.
prev parent reply other threads:[~2019-11-12 4:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-10 9:59 [PATCH] doc: improve readability of --rebase-merges in git-rebase Naveen Nathan
2019-11-11 8:49 ` Johannes Schindelin
2019-11-11 9:08 ` Junio C Hamano
2019-11-11 21:44 ` Naveen Nathan
2019-11-11 23:21 ` [PATCH v2] " Naveen Nathan
2019-11-12 4:18 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy2wlg22e.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=naveen@lastninja.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).