From: Junio C Hamano <gitster@pobox.com>
To: "Force.Charlie-I via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3 0/4] http: add support selecting http version
Date: Thu, 08 Nov 2018 15:14:22 +0900 [thread overview]
Message-ID: <xmqqy3a46qpt.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <pull.69.v3.git.gitgitgadget@gmail.com> (Force Charlie-I via GitGitGadget's message of "Wed, 07 Nov 2018 20:54:57 -0800 (PST)")
"Force.Charlie-I via GitGitGadget" <gitgitgadget@gmail.com> writes:
> Normally, git doesn't need to set curl to select the HTTP version, it works
> fine without HTTP/2. Adding HTTP/2 support is a icing on the cake.
>
> This patch support force enable HTTP/2 or HTTP/1.1.
>
> example:
>
> GIT_CURL_VERBOSE=1 git2 -c http.version=HTTP/2 ls-remote https://bitbucket.org/aquariusjay/deeplab-public-ver2.git
>
> Force Charlie (4):
> http: add support selecting http version
> support force use http 1.1
> fix curl version to support CURL_HTTP_VERSION_2TLS
> http: change http.version value type
When somebody reads over these four patches as a first-time reader,
I think s/he notices a couple of things:
- In the proposed log messages, there is no explanation on the
reason why we are doing these changes.
- Each of the steps n/4 (n > 1) looks more like "oops, it was a
mistake that we did not do this in earlier patch, and here is to
correct that".
- There is no test or documentation.
I suspect that a single patch that updates http.c, Documentation/
and t/ at the same time should be sufficient for a change of this
size.
Thanks.
> http.c | 36 ++++++++++++++++++++++++++++++++++++
> 1 file changed, 36 insertions(+)
>
>
> base-commit: 8858448bb49332d353febc078ce4a3abcc962efe
> Published-As: https://github.com/gitgitgadget/git/releases/tags/pr-69%2Ffcharlie%2Fmaster-v3
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-69/fcharlie/master-v3
> Pull-Request: https://github.com/gitgitgadget/git/pull/69
>
> Range-diff vs v2:
>
> 1: 4f5a935c43 = 1: 4f5a935c43 http: add support selecting http version
> 2: 06e9685d2b = 2: 06e9685d2b support force use http 1.1
> 3: eee67d8356 = 3: eee67d8356 fix curl version to support CURL_HTTP_VERSION_2TLS
> -: ---------- > 4: ef975b6093 http: change http.version value type
prev parent reply other threads:[~2018-11-08 6:14 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 13:33 [PATCH 0/1] http: add support selecting http version Force.Charlie-I via GitGitGadget
2018-11-07 13:33 ` [PATCH 1/1] " Force Charlie via GitGitGadget
2018-11-08 1:48 ` Junio C Hamano
2018-11-07 13:44 ` [PATCH 0/1] " Daniel Stenberg
2018-11-08 1:18 ` brian m. carlson
2018-11-08 3:35 ` Junio C Hamano
2018-11-08 1:35 ` [PATCH v2 0/3] " Force.Charlie-I via GitGitGadget
2018-11-08 1:35 ` [PATCH v2 1/3] " Force Charlie via GitGitGadget
2018-11-08 1:35 ` [PATCH v2 2/3] support force use http 1.1 Force Charlie via GitGitGadget
2018-11-08 1:35 ` [PATCH v2 3/3] fix curl version to support CURL_HTTP_VERSION_2TLS Force Charlie via GitGitGadget
2018-11-08 4:54 ` [PATCH v3 0/4] http: add support selecting http version Force.Charlie-I via GitGitGadget
2018-11-08 4:54 ` [PATCH v3 1/4] " Force Charlie via GitGitGadget
2018-11-08 4:55 ` [PATCH v3 2/4] support force use http 1.1 Force Charlie via GitGitGadget
2018-11-08 4:55 ` [PATCH v3 3/4] fix curl version to support CURL_HTTP_VERSION_2TLS Force Charlie via GitGitGadget
2018-11-08 4:55 ` [PATCH v3 4/4] http: change http.version value type Force Charlie via GitGitGadget
2018-11-08 6:14 ` [PATCH v4 0/4] http: add support selecting http version Force.Charlie-I via GitGitGadget
2018-11-08 6:14 ` [PATCH v4 1/4] " Force Charlie via GitGitGadget
2018-11-08 6:14 ` [PATCH v4 2/4] support force use http 1.1 Force Charlie via GitGitGadget
2018-11-08 6:14 ` [PATCH v4 3/4] fix curl version to support CURL_HTTP_VERSION_2TLS Force Charlie via GitGitGadget
2018-11-08 6:14 ` [PATCH v4 4/4] http: change http.version value type Force Charlie via GitGitGadget
2018-11-08 6:18 ` [PATCH v5 0/1] http: add support selecting http version Force.Charlie-I via GitGitGadget
2018-11-08 6:18 ` [PATCH v5 1/1] " Force Charlie via GitGitGadget
2018-11-08 7:00 ` [PATCH v6 0/1] " Force.Charlie-I via GitGitGadget
2018-11-08 7:00 ` [PATCH v6 1/1] " Force Charlie via GitGitGadget
2018-11-08 18:02 ` Eric Sunshine
2018-11-09 2:57 ` Junio C Hamano
2018-11-09 2:56 ` Junio C Hamano
2018-11-08 23:15 ` [PATCH v7 0/1] " Force.Charlie-I via GitGitGadget
2018-11-08 23:15 ` [PATCH v7 1/1] " Force Charlie via GitGitGadget
2018-11-09 3:52 ` Junio C Hamano
2018-11-09 3:44 ` [PATCH v8 0/1] " Force.Charlie-I via GitGitGadget
2018-11-09 3:44 ` [PATCH v8 1/1] " Force Charlie via GitGitGadget
2018-11-08 6:14 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy3a46qpt.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).