git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Ralf Thielow via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org,
	Corentin BOMPARD <corentin.bompard@etu.univ-lyon1.fr>,
	Ralf Thielow <ralf.thielow@gmail.com>
Subject: Re: [PATCH 1/1] fetch.c: fix typo in a warning message
Date: Sat, 02 Nov 2019 14:50:36 +0900	[thread overview]
Message-ID: <xmqqzhhe3jyr.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20191031225310.GA211076@google.com> (Jonathan Nieder's message of "Thu, 31 Oct 2019 15:53:10 -0700")

Jonathan Nieder <jrnieder@gmail.com> writes:

> Ralf Thielow wrote:
>
>> Signed-off-by: Ralf Thielow <ralf.thielow@gmail.com>
>> ---
>>  builtin/fetch.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
>>  				if (source_ref) {
>> -					warning(_("multiple branch detected, incompatible with --set-upstream"));
>> +					warning(_("multiple branches detected, incompatible with --set-upstream"));
>
> Long line.


Thanks, both.  This close to the final, I am reluctant to touch any
string inside _(), so let's postpone it to the next cycle, though.

      parent reply	other threads:[~2019-11-02  5:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-31 20:41 [PATCH 0/1] fetch.c: fix typo in a warning message Ralf Thielow via GitGitGadget
2019-10-31 20:41 ` [PATCH 1/1] " Ralf Thielow via GitGitGadget
2019-10-31 22:53   ` Jonathan Nieder
2019-11-01  9:48     ` Ralf Thielow
2019-11-02  5:50     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqzhhe3jyr.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=corentin.bompard@etu.univ-lyon1.fr \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=jrnieder@gmail.com \
    --cc=ralf.thielow@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).