git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Denton Liu <liu.denton@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>, Danh Doan <congdanhqx@gmail.com>
Subject: Re: [PATCH v3] submodule: teach set-url subcommand
Date: Sat, 02 Nov 2019 13:25:10 +0900	[thread overview]
Message-ID: <xmqqzhhe52hl.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20191030175817.GA5120@generichostname> (Denton Liu's message of "Wed, 30 Oct 2019 10:58:17 -0700")

Denton Liu <liu.denton@gmail.com> writes:

> I think that the problem is that it's a common enough use-case but not
> common enough that people often forget to "sync" after editing the
> .gitmodules.

Which means that far from deprecating "sync", we should strive for
imprinting the need for the use of the subcommand deeper in users'
minds.  I wonder if it makes sense to make sure that .gitmodules
file starts with something like

	# Note that after updating this file, you may want to
	# run "git submodule sync" so that the URL for the remote
	# repository etc. are propagated down.

when we create it (via, say "git submodule add")?  Or alternatively,
warn the users when "git status" notices a local modification, or
something along that line?

      reply	other threads:[~2019-11-02  4:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-17 20:03 [PATCH] " Denton Liu
2019-10-29  8:34 ` [PATCH v2] " Denton Liu
2019-10-29  9:15   ` Danh Doan
2019-10-29 17:01   ` [PATCH v3] " Denton Liu
2019-10-30  5:54     ` Junio C Hamano
2019-10-30 17:58       ` Denton Liu
2019-11-02  4:25         ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqzhhe52hl.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=congdanhqx@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=liu.denton@gmail.com \
    --subject='Re: [PATCH v3] submodule: teach set-url subcommand' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).