From: "Maciej Wieczór-Retman" <maciej.wieczor-retman@intel.com>
To: Reinette Chatre <reinette.chatre@intel.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>, Shuah Khan <shuah@kernel.org>,
<ilpo.jarvinen@linux.intel.com>, <linux-kernel@vger.kernel.org>,
<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH RESEND v3 2/2] selftests/resctrl: Move run_benchmark() to a more fitting file
Date: Tue, 12 Sep 2023 08:34:21 +0200 [thread overview]
Message-ID: <gjyv2lwrrw3n5n3olcedjjvhbyqqikic5fvuquc74srybgylq5@uxpvgadeuhhp> (raw)
In-Reply-To: <e0fa9375-0b50-af89-81d3-eaaecf19a788@intel.com>
Hi,
On 2023-09-11 at 09:59:31 -0700, Reinette Chatre wrote:
>Hi Maciej,
>
>On 9/1/2023 6:42 AM, Wieczor-Retman Maciej wrote:
>> resctrlfs.c file contains mostly functions that interact in some way
>
>This can just be "resctrlfs.c contains ..." (no need for "file")
Right, sorry, I'll correct this and the one below.
>> with resctrl FS entries while functions inside resctrl_val.c deal with
>> measurements and benchmarking.
>>
>> run_benchmark() is located in resctrlfs.c file even though it's
>
>same here
>
>> purpose is not interacting with the resctrl FS but to execute cache
>> checking logic.
>>
>> Move run_benchmark() to resctrl_val.c just before resctrl_val() that
>> makes use of run_benchmark(). Make run_benchmark() static since it's
>> not used between multiple files anymore.
>>
>> Remove return comment from kernel-doc since the function is type void.
>>
>> Signed-off-by: Wieczor-Retman Maciej <maciej.wieczor-retman@intel.com>
>> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
>
>Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
>
>Reinette
Thank you for the review!
--
Kind regards
Maciej Wieczór-Retman
prev parent reply other threads:[~2023-09-12 6:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 13:41 [PATCH RESEND v3 0/2] selftests/resctrl: Bug fix and optimization Wieczor-Retman Maciej
2023-09-01 13:42 ` [PATCH RESEND v3 1/2] selftests/resctrl: Fix schemata write error check Wieczor-Retman Maciej
2023-09-11 16:59 ` Reinette Chatre
2023-09-12 6:32 ` Maciej Wieczór-Retman
2023-09-12 16:00 ` Reinette Chatre
2023-09-13 5:59 ` Maciej Wieczór-Retman
2023-09-13 18:49 ` Reinette Chatre
2023-09-14 6:01 ` Maciej Wieczór-Retman
2023-09-14 15:14 ` Reinette Chatre
2023-09-15 8:16 ` Maciej Wieczór-Retman
2023-09-01 13:42 ` [PATCH RESEND v3 2/2] selftests/resctrl: Move run_benchmark() to a more fitting file Wieczor-Retman Maciej
2023-09-11 16:59 ` Reinette Chatre
2023-09-12 6:34 ` Maciej Wieczór-Retman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gjyv2lwrrw3n5n3olcedjjvhbyqqikic5fvuquc74srybgylq5@uxpvgadeuhhp \
--to=maciej.wieczor-retman@intel.com \
--cc=fenghua.yu@intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.