From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bp@suse.de>
Received: from mail.linutronix.de (193.142.43.55:993) by
  crypto-ml.lab.linutronix.de with IMAP4-SSL for <speck@linutronix.de>; 22 Oct
  2019 15:08:03 -0000
Received: from mx2.suse.de ([195.135.220.15] helo=mx1.suse.de)
	by Galois.linutronix.de with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256)
	(Exim 4.80)
	(envelope-from <bp@suse.de>)
	id 1iMvlR-0000Zz-Nm
	for speck@linutronix.de; Tue, 22 Oct 2019 17:08:02 +0200
Received: from relay2.suse.de (unknown [195.135.220.254])
	by mx1.suse.de (Postfix) with ESMTP id E0DD7AC3F
	for <speck@linutronix.de>; Tue, 22 Oct 2019 15:07:54 +0000 (UTC)
Date: Tue, 22 Oct 2019 17:07:47 +0200
From: Borislav Petkov <bp@suse.de>
Subject: [MODERATED] Re: [PATCH v7 03/10] TAAv7 3
Message-ID: <20191022150747.GG31458@zn.tnic>
References: <cover.1571688957.git.pawan.kumar.gupta@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
To: speck@linutronix.de
List-ID: <speck.linutronix.de>

On Mon, Oct 21, 2019 at 01:25:02PM -0700, speck for Pawan Gupta wrote:
> +void __init tsx_init(void)
> +{
> +	char arg[20];

Why 20? Magic?

Why not simply 4? We have "on" and "off" + '\0' AFAICT, no?

Also, you better clear that stack buffer:

	char arg[4] =3D {};

before use.

--=20
Regards/Gruss,
    Boris.

SUSE Software Solutions Germany GmbH, GF: Felix Imend=C3=B6rffer, HRB 36809, =
AG N=C3=BCrnberg
--=20