From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linutronix.de (193.142.43.55:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 22 Oct 2019 16:54:14 -0000 Received: from mga11.intel.com ([192.55.52.93]) by Galois.linutronix.de with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1iMxQD-0002MR-Np for speck@linutronix.de; Tue, 22 Oct 2019 18:54:14 +0200 Date: Tue, 22 Oct 2019 09:48:01 -0700 From: Pawan Gupta Subject: [MODERATED] Re: [PATCH v7 03/10] TAAv7 3 Message-ID: <20191022164801.GA29216@guptapadev.amr> References: <20191022081534.GA9379@dhcp22.suse.cz> <20191022144226.lbxywrikxwcjxjyf@treble> MIME-Version: 1.0 In-Reply-To: <20191022144226.lbxywrikxwcjxjyf@treble> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: speck@linutronix.de List-ID: On Tue, Oct 22, 2019 at 09:42:26AM -0500, speck for Josh Poimboeuf wrote: > On Tue, Oct 22, 2019 at 10:15:34AM +0200, speck for Michal Hocko wrote: > > On Mon 21-10-19 13:25:02, speck for Pawan Gupta wrote: > > [...] > > > + tsx= [X86] Control Transactional Synchronization > > > + Extensions (TSX) feature in Intel processors that > > > + support TSX control. > > > + > > > + This parameter controls the TSX feature. The options are: > > > + > > > + on - Enable TSX on the system. > > > + off - Disable TSX on the system. > > > > Please explicitly mention that off is active only if TSX there is ucode > > support for that (aka MSR_IA32_TSX_CTRL). > > I'm pretty sure I already asked for this in the last revision. And this > is not the first time I've seen ignored feedback. Pawan, please try to > take all feedback into account so we don't have to keep repeating > ourselves. I am sorry to have missed it. All of the operation on|off|auto are dependent on TSX control being present. The tsx= description states that processors need TSX control support. I would extend it to specifically say ucode update adds TSX control support (aka MSR_IA32_TSX_CTRL). tsx= [X86] Control Transactional Synchronization Extensions (TSX) feature in Intel processors that support TSX control. Thanks, Pawan