From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linutronix.de (193.142.43.55:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 22 Oct 2019 17:02:37 -0000 Received: from mx2.suse.de ([195.135.220.15] helo=mx1.suse.de) by Galois.linutronix.de with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1iMxYK-0002jg-9K for speck@linutronix.de; Tue, 22 Oct 2019 19:02:36 +0200 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id CE7F9B550 for ; Tue, 22 Oct 2019 17:02:30 +0000 (UTC) Date: Tue, 22 Oct 2019 19:02:30 +0200 From: Borislav Petkov Subject: [MODERATED] Re: [PATCH v7 04/10] TAAv7 4 Message-ID: <20191022170230.GM31458@zn.tnic> References: <20191022165112.GK31458@zn.tnic> MIME-Version: 1.0 In-Reply-To: <20191022165112.GK31458@zn.tnic> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable To: speck@linutronix.de List-ID: On Tue, Oct 22, 2019 at 06:51:12PM +0200, Borislav Petkov wrote: > > +{ > > + if (!boot_cpu_has_bug(X86_BUG_TAA)) > > + return 0; > > + > > + if (!str) > > + return -EINVAL; > > + > > + if (!strcmp(str, "off")) { > > + taa_mitigation =3D TAA_MITIGATION_OFF; > > + } else if (!strcmp(str, "full")) { > > + taa_mitigation =3D TAA_MITIGATION_VERW; > > + } else if (!strcmp(str, "full,nosmt")) { > > + taa_mitigation =3D TAA_MITIGATION_VERW; > > + taa_nosmt =3D true; > > + } > > + > > + return 0; > > +} > > +early_param("tsx_async_abort", tsx_async_abort_cmdline); >=20 > Say what now?! >=20 > The previous patch added this: >=20 > tsx=3D [X86] Control Transactional Synchronization > Extensions (TSX) feature in Intel processors that > support TSX control. >=20 > This parameter controls the TSX feature. The option= s are: >=20 > on - Enable TSX on the system. > off - Disable TSX on the system. >=20 > So what is the final name of command line option now? Yah, Josh just set me straight: there's two flags. Yuck. I'm willing to bet I won't be the only one to get confused by this. tsx=3D taa=3D is probably marginally better but someone might have a better idea. --=20 Regards/Gruss, Boris. SUSE Software Solutions Germany GmbH, GF: Felix Imend=C3=B6rffer, HRB 36809, = AG N=C3=BCrnberg --=20