From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linutronix.de (193.142.43.55:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 22 Oct 2019 17:16:25 -0000 Received: from mx2.suse.de ([195.135.220.15] helo=mx1.suse.de) by Galois.linutronix.de with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1iMxlg-0003Bh-58 for speck@linutronix.de; Tue, 22 Oct 2019 19:16:24 +0200 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 47140AFBB for ; Tue, 22 Oct 2019 17:16:18 +0000 (UTC) Date: Tue, 22 Oct 2019 19:16:11 +0200 From: Borislav Petkov Subject: [MODERATED] Re: Re: [PATCH v7 03/10] TAAv7 3 Message-ID: <20191022171611.GN31458@zn.tnic> References: <20191022144853.GF31458@zn.tnic> <20191022170046.GD29216@guptapadev.amr> MIME-Version: 1.0 In-Reply-To: <20191022170046.GD29216@guptapadev.amr> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable To: speck@linutronix.de List-ID: On Tue, Oct 22, 2019 at 10:00:46AM -0700, speck for Pawan Gupta wrote: > Again this is as per the feedback to create a new file for TSX as it is > a feature. TAA stuff stays in bugs.c. Well, with patchsets like that, it is always good to write a more detailed changelog so that questions like that are answered from it. Your 0/x message has "- Refactor TSX code into new tsx.c" but it would be a lot more helpful if it had the "why" you did it: " - Carve out the TSX disabling functionality into a separate compilation unit because it is a CPU feature." This sentence could be a part of the patch commit message even. This patchset has been going back'n'forth since May so people like me forgetting things is kinda normal. Thx. --=20 Regards/Gruss, Boris. SUSE Software Solutions Germany GmbH, GF: Felix Imend=C3=B6rffer, HRB 36809, = AG N=C3=BCrnberg --=20