From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linutronix.de (193.142.43.55:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 22 Oct 2019 21:53:29 -0000 Received: from mx2.suse.de ([195.135.220.15] helo=mx1.suse.de) by Galois.linutronix.de with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1iN25o-0007oA-Fi for speck@linutronix.de; Tue, 22 Oct 2019 23:53:28 +0200 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 7E972B28E for ; Tue, 22 Oct 2019 21:53:22 +0000 (UTC) Date: Tue, 22 Oct 2019 23:53:21 +0200 From: Borislav Petkov Subject: [MODERATED] Re: [PATCH v7 04/10] TAAv7 4 Message-ID: <20191022215321.GY31458@zn.tnic> References: <20191022165112.GK31458@zn.tnic> <20191022174452.GE29216@guptapadev.amr> <20191022190434.GR31458@zn.tnic> <20191022212902.GA30440@guptapadev.amr> MIME-Version: 1.0 In-Reply-To: <20191022212902.GA30440@guptapadev.amr> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable To: speck@linutronix.de List-ID: On Tue, Oct 22, 2019 at 02:29:02PM -0700, speck for Pawan Gupta wrote: > Side effect of RTM check ahead of X86_BUG_TAA will be a dmesg print > "Mitigation: TSX disabled" when X86_BUG_TAA is not set. So what you're trying to tell me is that you don't want to print that message at all? if (!boot_cpu_has(X86_FEATURE_RTM)) { taa_mitigation =3D TAA_MITIGATION_TSX_DISABLE; return; } How's that? > > Also, from all the possible settings: > >=20 > > [TAA_MITIGATION_OFF] =3D "Vulnerable", > > [TAA_MITIGATION_UCODE_NEEDED] =3D "Vulnerable: Clear CPU buffer= s attempted, no microcode", > > [TAA_MITIGATION_VERW] =3D "Mitigation: Clear CPU buffer= s", > > [TAA_MITIGATION_TSX_DISABLE] =3D "Mitigation: TSX disabled", > >=20 > > TAA_MITIGATION_TSX_DISABLE is the one that fits best for the !RTM case, > > no? >=20 > When X86_BUG_TAA is not set sysfs shows "Not affected" irrespective of > value of taa_mitigation. >=20 > cpu_show_common() > { > if (!boot_cpu_has_bug(bug)) > return sprintf(buf, "Not affected\n"); > [...] Sorry, I can't follow what you're trying to tell me here. --=20 Regards/Gruss, Boris. SUSE Software Solutions Germany GmbH, GF: Felix Imend=C3=B6rffer, HRB 36809, = AG N=C3=BCrnberg --=20