historical-speck.lore.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joerg Roedel <jroedel@suse.de>
To: speck@linutronix.de
Subject: [MODERATED] Re: ***UNCHECKED*** Re: [PATCH v7 3/5] NX 3
Date: Fri, 25 Oct 2019 11:03:31 +0200	[thread overview]
Message-ID: <20191025090331.GD7069@suse.de> (raw)
In-Reply-To: <a5f3f0dd-2eb8-6bf7-ae08-6bb45e8a4c68@redhat.com>

On Fri, Oct 25, 2019 at 10:48:04AM +0200, speck for Paolo Bonzini wrote:
> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
> index e7970a2e8eae..1f923dee99e5 100644
> --- a/arch/x86/kvm/vmx/vmx.c
> +++ b/arch/x86/kvm/vmx/vmx.c
> @@ -992,6 +992,9 @@ static bool update_transition_efer(struct vcpu_vmx *vmx, int efer_offset)
>  		ignore_bits &= ~(u64)EFER_SCE;
>  #endif
>  
> +	guest_efer &= ~ignore_bits;
> +	guest_efer |= host_efer & ignore_bits;
> +
>  	/*
>  	 * On EPT, we can't emulate NX, so we must switch EFER atomically.
>  	 * On CPUs that support "load IA32_EFER", always switch EFER
> @@ -1010,9 +1013,6 @@ static bool update_transition_efer(struct vcpu_vmx *vmx, int efer_offset)
>  	} else {
>  		clear_atomic_switch_msr(vmx, MSR_EFER);
>  
> -		guest_efer &= ~ignore_bits;
> -		guest_efer |= host_efer & ignore_bits;
> -
>  		vmx->guest_msrs[efer_offset].data = guest_efer;
>  		vmx->guest_msrs[efer_offset].mask = ~ignore_bits;
>  
> 
> 

This works on my machine with ept=0 but breaks with ept=1:

	KVM: entry failed, hardware error 0x80000021

Regards,

	Joerg

  reply	other threads:[~2019-10-25  9:03 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-24 16:34 [MODERATED] [PATCH v7 0/5] NX 0 Paolo Bonzini
2019-10-24 16:34 ` [MODERATED] [PATCH v7 1/5] NX 1 Paolo Bonzini
2019-10-30 18:38   ` [MODERATED] " Josh Poimboeuf
2019-10-31 11:05     ` Paolo Bonzini
2019-10-24 16:34 ` [MODERATED] [PATCH v7 2/5] NX 2 Paolo Bonzini
2019-10-24 16:34 ` [MODERATED] [PATCH v7 3/5] NX 3 Paolo Bonzini
2019-10-25  8:37   ` [MODERATED] Re: ***UNCHECKED*** " Joerg Roedel
2019-10-25  8:48     ` Paolo Bonzini
2019-10-25  9:03       ` Joerg Roedel [this message]
2019-10-25  9:08         ` [MODERATED] Re: ***UNCHECKED*** " Paolo Bonzini
2019-10-25  9:45           ` [MODERATED] Re: ***UNCHECKED*** " Joerg Roedel
2019-10-25 10:39             ` Paolo Bonzini
2019-10-29 20:33               ` mark gross
2019-10-31 11:02                 ` Paolo Bonzini
2019-10-24 16:34 ` [MODERATED] [PATCH v7 4/5] NX 4 Paolo Bonzini
2019-10-24 16:34 ` [MODERATED] [PATCH v7 5/5] NX 5 Paolo Bonzini
2019-10-24 18:27 ` [MODERATED] Re: [PATCH v7 0/5] NX 0 Ben Hutchings
2019-10-24 18:56   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191025090331.GD7069@suse.de \
    --to=jroedel@suse.de \
    --cc=speck@linutronix.de \
    --subject='[MODERATED] Re: ***UNCHECKED*** Re: [PATCH v7 3/5] NX 3' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).