historical-speck.lore.kernel.org archive mirror
 help / color / mirror / Atom feed
From: mark gross <mgross@linux.intel.com>
To: speck@linutronix.de
Subject: [MODERATED] Re: [PATCH 1/2] more sampling fun 1
Date: Fri, 21 Feb 2020 14:10:51 -0800	[thread overview]
Message-ID: <20200221221051.GA87914@mtg-dev.jf.intel.com> (raw)
In-Reply-To: <2847e79bd70becdc174a4bd890c1be6b37247e43.camel@decadent.org.uk>

On Thu, Feb 20, 2020 at 07:08:45PM +0000, speck for Ben Hutchings wrote:
> On Thu, 2020-02-06 at 14:11 -0800, speck for mark gross wrote:
> > From: mark gross <mgross@linux.intel.com>
> > Subject: [PATCH 1/2] Add capability to specify a range of steppings in the
> [...]
> > --- a/arch/x86/include/asm/cpu_device_id.h
> > +++ b/arch/x86/include/asm/cpu_device_id.h
> > @@ -35,7 +35,19 @@ struct x86_cpu_desc {
> >  	.x86_microcode_rev	= (revision),			\
> >  }
> >  
> > +/*
> > + * Match a range of steppings
> > + */
> > +
> > +struct x86_cpu_id_ext {
> > +	struct x86_cpu_id id;
> > +	__u16 steppings; /* bit map of steppings to match against */
> > +};
> > +
> > +#define X86_STEPPING_ANY 0
> [...]
> 
> Minor point, but wouldn't it make more sense to define X86_STEPPING_ANY
> as GENMASK(15, 0)?  Then it's no longer a special case.
> 
Right, I had initialy used basicaly the equivelent (-1 or 0xFFFF) for
X86_STEPPING_ANY but, it was pointed out that other similar usages use 0 as a
flag for "ANY" and was encuraged to mimic that logic.  See X86_FAMILY_ANY,
X86_MODEL_ANY, X86_FEATURE_ANY.

I'm cool with either way.

Given this background do you still encurage using GENMASK(15,0)?

--mark

  reply	other threads:[~2020-02-21 22:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <c79feecdb14c62e3dd8f2680bc68292f99882aeb.158215=?utf-8?q?2322?= .git.mgross@linux.intel.com>
2020-02-20 19:08 ` Ben Hutchings
2020-02-21 22:10   ` mark gross [this message]
2020-02-20 10:07 Borislav Petkov
2020-02-20 10:10 ` Andrew Cooper
2020-02-20 10:13   ` [MODERATED] " Borislav Petkov
2020-02-20 11:00     ` [MODERATED] " Andrew Cooper
2020-02-20 12:39       ` Greg KH
2020-02-20 17:53 ` mark gross
2020-02-20 18:26   ` Borislav Petkov
2020-02-20 19:24     ` mark gross
2020-02-21 22:12     ` mark gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200221221051.GA87914@mtg-dev.jf.intel.com \
    --to=mgross@linux.intel.com \
    --cc=speck@linutronix.de \
    --subject='[MODERATED] Re: [PATCH 1/2] more sampling fun 1' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).