From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linutronix.de (193.142.43.55:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 26 Feb 2020 11:07:53 -0000 Received: from mx2.suse.de ([195.135.220.15]) by Galois.linutronix.de with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1j6uXg-0005Ml-LZ for speck@linutronix.de; Wed, 26 Feb 2020 12:07:53 +0100 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id D9F49ADFE for ; Wed, 26 Feb 2020 11:07:45 +0000 (UTC) Date: Wed, 26 Feb 2020 12:07:37 +0100 From: Borislav Petkov Subject: [MODERATED] Re: [PATCH v2 1/2] v2: more sampling fun 1 Message-ID: <20200226110737.GB17448@zn.tnic> References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable To: speck@linutronix.de List-ID: On Thu, Feb 06, 2020 at 02:11:02PM -0800, speck for mark gross wrote: > From: mark gross > Subject: [PATCH v2 1/2] Add capability to specify a range of steppings in t= he > vulnerability white list structure. >=20 > From: mark gross > Subject: [PATCH v2 1/2] Add capability to specify a range of steppings in t= he That second subject is incomplete. Do just one pls. Also, you need a subject prefix: x86/CPU: Add ... git log arch/x86/ is your friend if you're wondering what to call it. > Intel has produced processors with the same CPUID family+model. Code > may need to check the stepping when programming model specific behavior. >=20 > Add an API to allow easy specification of stepping or range of steppings > with a 16 bit bitmask. >=20 > Update cpu_vuln_whitelist using this new API. >=20 > I implemented this in the way I did to avoid modifying x86_cpu_id as > that structure is an exported ABI and any change would impact user mode > code using the structure. Exported ABI? Which usermode code uses this? The module loading tools? Even if, we do add new struct members at the end of exported structs just fine. So what is the problem here? > Signed-off-by: mark gross > Reviewed-by: tony luck Please write names capitalized. --=20 Regards/Gruss, Boris. SUSE Software Solutions Germany GmbH, GF: Felix Imend=C3=B6rffer, HRB 36809, = AG N=C3=BCrnberg --=20