From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linutronix.de (193.142.43.55:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 26 Feb 2020 21:13:16 -0000 Received: from mga11.intel.com ([192.55.52.93]) by Galois.linutronix.de with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1j73zW-0006M3-VB for speck@linutronix.de; Wed, 26 Feb 2020 22:13:15 +0100 Date: Wed, 26 Feb 2020 13:13:10 -0800 From: Andi Kleen Subject: [MODERATED] Re: [PATCH v2 1/2] v2: more sampling fun 1 Message-ID: <20200226211310.GT160988@tassilo.jf.intel.com> References: <20200226110737.GB17448@zn.tnic> <20200226171103.GA114268@mtg-dev.jf.intel.com> MIME-Version: 1.0 In-Reply-To: <20200226171103.GA114268@mtg-dev.jf.intel.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: speck@linutronix.de List-ID: > > > I implemented this in the way I did to avoid modifying x86_cpu_id as > > > that structure is an exported ABI and any change would impact user mode > > > code using the structure. > > > > Exported ABI? Which usermode code uses this? The module loading tools? > > Yeah, Andi pointed it out to me on an internal review. I don't know what tool > is using it. Yes it's modprobe to find which module to load. All of mod_devicetable.h is ABI -Andi