From: mark gross <mgross@linux.intel.com>
To: speck@linutronix.de
Subject: [MODERATED] Re: [PATCH v2 2/2] v2: more sampling fun 2
Date: Wed, 26 Feb 2020 14:37:00 -0800 [thread overview]
Message-ID: <20200226223700.GE116192@mtg-dev.jf.intel.com> (raw)
In-Reply-To: <20200226181325.GE17448@zn.tnic>
On Wed, Feb 26, 2020 at 07:13:25PM +0100, speck for Borislav Petkov wrote:
> On Wed, Feb 26, 2020 at 09:35:08AM -0800, speck for mark gross wrote:
> > > This "We" sounds like you mean Intel...?
> > yes, this instance of "we" is an intel statement from that white paper I'm
> > waiting on for the documentation patch.
>
> See how "we" means different things and how you should avoid it in
> commit messages?
yeah, the first instance of 'we' was an error. This second one was a copy and
paste from the whitepaper. Next time I'll tweak what I copy and replace "we"
with "intel" or just reword it.
> IOW, pls use passive voice.
ok.
>
> > I wrote it this way initially because at the time I expected there to be more
> > dynamic support for managing this mitigation WRT post boot changes to TSX
> > availability. The expectation I was later given was to make it a boot
> > commandline control only. I kept it this way mostly out of laziness and
> > simplification of the number of mitigation states to track.
>
> Drop it then.
Drop it: as in disregard your comment on this point
or
Drop it: as in rework it to avoid the extra check for TSX availability?
>
> > srb_sampling is no more readable to me and doesn't convay what the
> > command line is for. But, more readable is always better.
>
> Ok, let's see what better suggestions/preferences the others might have.
>
> > Perhaps changing into a single value, with any '=' like:
> > disable_srbs_mitigation or srbds_mitigation_off would be better?
>
> You don't need to have "disable" or "off" in the actual command line
> switch's name if you give it the on/off after the "=".
ok
>
> And as I said already, you don't need to have a tautology by putting
> "mitigation" in the mitigation option - it is a mitigation.
My initial version just had "srbds=off" as the commanline. But, I noticed
other mitigations included the "_mitigtion" and thought to mimic that. I like
dropping the "_mitigation" part of the option.
I will change it to just "srbds=off" for the next version.
Thank you for the help!
--mark
next prev parent reply other threads:[~2020-02-26 22:37 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 21:45 [MODERATED] [PATCH v2 0/2] v2: more sampling fun 0 mark gross
2020-01-16 22:16 ` [MODERATED] [PATCH v2 2/2] v2: more sampling fun 2 mark gross
2020-02-06 22:11 ` [MODERATED] [PATCH v2 1/2] v2: more sampling fun 1 mark gross
2020-02-25 16:55 ` [MODERATED] Re: [PATCH v2 0/2] v2: more sampling fun 0 Josh Poimboeuf
2020-02-25 17:43 ` mark gross
2020-02-25 20:47 ` Thomas Gleixner
2020-02-25 21:51 ` [MODERATED] " mark gross
[not found] ` <5e5595e6.1c69fb81.69e80.2880SMTPIN_ADDED_BROKEN@mx.google.com>
2020-02-26 7:27 ` [MODERATED] Re: [PATCH v2 2/2] v2: more sampling fun 2 Greg KH
2020-02-26 18:02 ` mark gross
2020-02-26 11:07 ` [MODERATED] Re: [PATCH v2 1/2] v2: more sampling fun 1 Borislav Petkov
2020-02-26 17:11 ` mark gross
2020-02-26 17:59 ` Borislav Petkov
2020-02-26 18:16 ` Thomas Gleixner
2020-02-26 22:13 ` [MODERATED] " mark gross
2020-02-26 23:53 ` Thomas Gleixner
2020-02-27 16:43 ` [MODERATED] " mark gross
2020-02-26 22:11 ` mark gross
2020-02-26 22:43 ` Borislav Petkov
2020-02-26 23:34 ` mark gross
2020-02-26 18:55 ` Thomas Gleixner
2020-02-26 22:23 ` [MODERATED] " mark gross
2020-02-26 21:13 ` Andi Kleen
2020-02-26 22:01 ` Thomas Gleixner
2020-02-27 7:08 ` [MODERATED] " Greg KH
2020-02-26 11:46 ` [MODERATED] Re: [PATCH v2 2/2] v2: more sampling fun 2 Borislav Petkov
2020-02-26 17:35 ` mark gross
2020-02-26 18:13 ` Borislav Petkov
2020-02-26 22:37 ` mark gross [this message]
2020-02-26 22:50 ` Borislav Petkov
2020-02-26 23:42 ` mark gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200226223700.GE116192@mtg-dev.jf.intel.com \
--to=mgross@linux.intel.com \
--cc=speck@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).