From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linutronix.de (193.142.43.55:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 11 Mar 2020 23:09:58 -0000 Received: from mga01.intel.com ([192.55.52.88]) by Galois.linutronix.de with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1jCAU7-000482-8w for speck@linutronix.de; Thu, 12 Mar 2020 00:09:56 +0100 Received: from localhost (mtg-dev.jf.intel.com [10.54.74.10]) by smtp.ostc.intel.com (Postfix) with ESMTP id AE4266367 for ; Wed, 11 Mar 2020 23:09:51 +0000 (UTC) Date: Wed, 11 Mar 2020 16:09:51 -0700 From: mark gross Subject: [MODERATED] Re: [PATCH 1/2] v3 more sampling fun 1 Message-ID: <20200311230951.GA78230@mtg-dev.jf.intel.com> Reply-To: mgross@linux.intel.com References: <5e690bea.1c69fb81.16d6d.4b78SMTPIN_ADDED_BROKEN@mx.google.com> <20200311172128.GB3952198@kroah.com> MIME-Version: 1.0 In-Reply-To: <20200311172128.GB3952198@kroah.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: speck@linutronix.de List-ID: On Wed, Mar 11, 2020 at 06:21:28PM +0100, speck for Greg KH wrote: > On Thu, Jan 16, 2020 at 02:16:07PM -0800, speck for mark gross wrote: > > --- a/drivers/base/cpu.c > > +++ b/drivers/base/cpu.c > > @@ -567,6 +567,12 @@ ssize_t __weak cpu_show_itlb_multihit(struct device *dev, > > return sprintf(buf, "Not affected\n"); > > } > > > > +ssize_t __weak cpu_show_special_register_data_sampling(struct device *dev, > > + struct device_attribute *attr, char *buf) > > +{ > > + return sprintf(buf, "Not affected\n"); > > +} > > + > > static DEVICE_ATTR(meltdown, 0444, cpu_show_meltdown, NULL); > > static DEVICE_ATTR(spectre_v1, 0444, cpu_show_spectre_v1, NULL); > > static DEVICE_ATTR(spectre_v2, 0444, cpu_show_spectre_v2, NULL); > > @@ -575,6 +581,7 @@ static DEVICE_ATTR(l1tf, 0444, cpu_show_l1tf, NULL); > > static DEVICE_ATTR(mds, 0444, cpu_show_mds, NULL); > > static DEVICE_ATTR(tsx_async_abort, 0444, cpu_show_tsx_async_abort, NULL); > > static DEVICE_ATTR(itlb_multihit, 0444, cpu_show_itlb_multihit, NULL); > > +static DEVICE_ATTR(special_register_data_sampling, 0444, cpu_show_special_register_data_sampling, NULL); > > > > static struct attribute *cpu_root_vulnerabilities_attrs[] = { > > &dev_attr_meltdown.attr, > > @@ -585,6 +592,7 @@ static struct attribute *cpu_root_vulnerabilities_attrs[] = { > > &dev_attr_mds.attr, > > &dev_attr_tsx_async_abort.attr, > > &dev_attr_itlb_multihit.attr, > > + &dev_attr_special_register_data_sampling.attr, > > NULL > > }; > > You forgot a Documentation/ABI/ entry for this new sysfs file like I > pointed out previously :( I thought you where talking about the command line arguments not being documented. I'll add this. --mark