From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linutronix.de (193.142.43.55:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 15 Apr 2020 12:58:43 -0000 Received: from p5de0bf0b.dip0.t-ipconnect.de ([93.224.191.11] helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1jOhco-0001kz-0a for speck@linutronix.de; Wed, 15 Apr 2020 14:58:42 +0200 From: Thomas Gleixner Subject: Re: [PATCH 3/4] V7 more sampling fun 3 In-Reply-To: <20200414215924.GE29751@mtg-dev.jf.intel.com> References: <20200414200544.zqhguchba3m2jhr6@treble> <20200414215924.GE29751@mtg-dev.jf.intel.com> Date: Wed, 15 Apr 2020 14:58:40 +0200 Message-ID: <873694oqgv.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: speck@linutronix.de List-ID: Mark, speck for mark gross writes: > On Tue, Apr 14, 2020 at 03:05:44PM -0500, speck for Josh Poimboeuf wrote: >> On Thu, Jan 16, 2020 at 02:16:07PM -0800, speck for mark gross wrote: >> > +static const struct x86_cpu_id cpu_vuln_blacklist[] __initconst = { >> > + VULNBL_INTEL_STEPPING(KABYLAKE_L, X86_STEPPINGS(0, 0xA), SRBDS), >> > + VULNBL_INTEL_STEPPING(KABYLAKE_L, X86_STEPPINGS(0xB, 0xC), SRBDS_IF_TSX), >> > + VULNBL_INTEL_STEPPING(KABYLAKE, X86_STEPPINGS(0, 0xB), SRBDS), >> > + VULNBL_INTEL_STEPPING(KABYLAKE, X86_STEPPINGS(0xC, 0xD), SRBDS_IF_TSX), >> >> Another readability tweak: "0x0" helps with vertical alignment: >> >> VULNBL_INTEL_STEPPING(KABYLAKE_L, X86_STEPPINGS(0x0, 0xA), SRBDS), >> VULNBL_INTEL_STEPPING(KABYLAKE_L, X86_STEPPINGS(0xB, 0xC), SRBDS_IF_TSX), >> VULNBL_INTEL_STEPPING(KABYLAKE, X86_STEPPINGS(0x0, 0xB), SRBDS), >> VULNBL_INTEL_STEPPING(KABYLAKE, X86_STEPPINGS(0xC, 0xD), SRBDS_IF_TSX), > > FWIW the white paper no longer calls out individual steppings as vulnerable > only if TSX so I'm losing the SRBDS_IF_TSX stuff. So we lose the complete TSX conditionals or do they now apply to all NO_MDS CPUs? Thanks, tglx