From: Thomas Gleixner <tglx@linutronix.de>
To: speck@linutronix.de
Subject: Re: [PATCH v2 1/2] v2: more sampling fun 1
Date: Wed, 26 Feb 2020 19:16:33 +0100 [thread overview]
Message-ID: <87h7zdi58e.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20200226175950.GD17448@zn.tnic>
speck for Borislav Petkov <speck@linutronix.de> writes:
> On Wed, Feb 26, 2020 at 09:11:03AM -0800, speck for mark gross wrote:
>> Yeah, Andi pointed it out to me on an internal review. I don't know what tool
>> is using it.
>
> Then how do you write a patch and state in the commit message that
> something is an ABI without knowing what the situation actually is?!
>
>> FWIW doing it this way made a cleaner patch without touching a dozen other
>> files using that structure. I'd rather stay with the way it is but, if you
>> feel strongly I can do a version of what I had before only adding the new
>> members to the end. Please let me know.
>
> Looking at that table again - cpu_vuln_whitelist - that is a
> *whitelist*. See how all the bits start with "NO_"? Except maybe
> MSBDS_ONLY.
Well, that was a decision to not have NO_MSDALL and NO_MDSSOMETHING as
it made some of logic in the code simpler.
> What you're doing is, you're misusing it to match models and steppings
> to set SRBDS* bug flags.
>
> What you should actually be doing is setting those bug flags in
> early_init_intel() where you can go wild with the steppings checking and
> then you won't need to touch x86_cpu_id at all.
Either that or add a new cpu_vuln_shitlist beside the whitelist and
stick the new stuff into that. It kinda makes sense to keep all this
vulnerability nonsense in one place.
Thanks,
tglx
next prev parent reply other threads:[~2020-02-26 18:16 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 21:45 [MODERATED] [PATCH v2 0/2] v2: more sampling fun 0 mark gross
2020-01-16 22:16 ` [MODERATED] [PATCH v2 2/2] v2: more sampling fun 2 mark gross
2020-02-06 22:11 ` [MODERATED] [PATCH v2 1/2] v2: more sampling fun 1 mark gross
2020-02-25 16:55 ` [MODERATED] Re: [PATCH v2 0/2] v2: more sampling fun 0 Josh Poimboeuf
2020-02-25 17:43 ` mark gross
2020-02-25 20:47 ` Thomas Gleixner
2020-02-25 21:51 ` [MODERATED] " mark gross
[not found] ` <5e5595e6.1c69fb81.69e80.2880SMTPIN_ADDED_BROKEN@mx.google.com>
2020-02-26 7:27 ` [MODERATED] Re: [PATCH v2 2/2] v2: more sampling fun 2 Greg KH
2020-02-26 18:02 ` mark gross
2020-02-26 11:07 ` [MODERATED] Re: [PATCH v2 1/2] v2: more sampling fun 1 Borislav Petkov
2020-02-26 17:11 ` mark gross
2020-02-26 17:59 ` Borislav Petkov
2020-02-26 18:16 ` Thomas Gleixner [this message]
2020-02-26 22:13 ` mark gross
2020-02-26 23:53 ` Thomas Gleixner
2020-02-27 16:43 ` [MODERATED] " mark gross
2020-02-26 22:11 ` mark gross
2020-02-26 22:43 ` Borislav Petkov
2020-02-26 23:34 ` mark gross
2020-02-26 18:55 ` Thomas Gleixner
2020-02-26 22:23 ` [MODERATED] " mark gross
2020-02-26 21:13 ` Andi Kleen
2020-02-26 22:01 ` Thomas Gleixner
2020-02-27 7:08 ` [MODERATED] " Greg KH
2020-02-26 11:46 ` [MODERATED] Re: [PATCH v2 2/2] v2: more sampling fun 2 Borislav Petkov
2020-02-26 17:35 ` mark gross
2020-02-26 18:13 ` Borislav Petkov
2020-02-26 22:37 ` mark gross
2020-02-26 22:50 ` Borislav Petkov
2020-02-26 23:42 ` mark gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7zdi58e.fsf@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=speck@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).