From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linus@torvalds.org>
Received: from mail.linutronix.de (146.0.238.70:993) by
  crypto-ml.lab.linutronix.de with IMAP4-SSL for <speck@linutronix.de>; 27 Feb
  2019 19:50:39 -0000
Received: from mail-lf1-x143.google.com ([2a00:1450:4864:20::143])
	by Galois.linutronix.de with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128)
	(Exim 4.80)
	(envelope-from <linus@torvalds.org>)
	id 1gz5Dy-0002Nb-Lv
	for speck@linutronix.de; Wed, 27 Feb 2019 20:50:38 +0100
Received: by mail-lf1-x143.google.com with SMTP id z23so1335109lfe.0
        for <speck@linutronix.de>; Wed, 27 Feb 2019 11:50:38 -0800 (PST)
References: <20190227150939.605235753@linutronix.de>
 <CAHk-=whCBZoMM=MtYwtgKiUD_Nm_JqM+xEgzoro=nUff3XBzEg@mail.gmail.com>
 <alpine.DEB.2.21.1902271850110.1644@nanos.tec.linutronix.de>
 <alpine.DEB.2.21.1902271912550.1644@nanos.tec.linutronix.de>
In-Reply-To: <alpine.DEB.2.21.1902271912550.1644@nanos.tec.linutronix.de>
From: Linus Torvalds <linus@torvalds.org>
Date: Wed, 27 Feb 2019 11:50:16 -0800
Message-ID: 
 <CAHk-=wjq5pSyzfv0Ghdrvxoo-JOMoOtV5TiyyqjECDVdW3fUmg@mail.gmail.com>
Subject: [MODERATED] Re: [patch V5 00/14] MDS basics 0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
To: speck@linutronix.de
List-ID: <speck.linutronix.de>

On Wed, Feb 27, 2019 at 10:14 AM speck for Thomas Gleixner
<speck@linutronix.de> wrote:
>
> Something like this:

That looks better to me.

If I had my choice, I'd get rid of the "FAM6" thing entirely from the
intel enumerations, but that's an independent thing

Although when I look at this, we actually already have a helper macro
for the Intel case, and you could do

    INTEL_CPU_FAM6(ATOM_SALTWELL, NO_SPECULATION),
    INTEL_CPU_FAM6(ATOM_SALTWELL_TABLET,   NO_SPECULATION),
    ...

using the existing INTEL_CPU_FAM6() helper macro.

It's clearly not the first case people looked at those nasty model
definitions and went "ugh. that's illegible".

               Linus