From: Thomas Gleixner <tglx@linutronix.de>
To: speck@linutronix.de
Subject: Re: The Annnoying Affair has No eXcuses - Bulletin #3
Date: Thu, 7 Nov 2019 21:11:34 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.1911072046400.27903@nanos.tec.linutronix.de> (raw)
In-Reply-To: <900659f3-b0d2-71ad-ae61-60d325efa709@redhat.com>
Paolo,
On Thu, 7 Nov 2019, speck for Paolo Bonzini wrote:
> On 07/11/19 16:16, speck for Thomas Gleixner wrote:
> > The TAA fix from Josh is now applied to master and to the stable branches,
> > which are still waiting for Paolos NX updates. Hint, hint...
>
> Looks like I have No Excuses for procrastinating. :) Bundles attached.
First of all thanks for providing that!
But now I really have to ask whether you actually ever looked how backports
into stable kernels are done? Obviously not, because your series is just
buggered:
1) All backport commits have to have
commit LOOOONGSHAAAAAA upstream
Right at the top of the changelog, not some randomly defined
(cherrypicked ....) thingy in the middle of the SOB chain
2) All backport commits have to be the same as the upstream
commit including change logs, except for eventual conflicts.
Instead of using the commits from the repo or the bundle you picked
your V9 version and backported it and of course you still have the
wrong default in the documentation of the command line parameter along
with different change logs.
3) All backport commits have to preserve the SOB/tag chain of the
upstream commit, plus your own if the committer was not yourself.
Of course all the ones which are in the master branch do not have that
because you used your V9 version as a base. Aside of missing my SOB's
the broken SOB chain from 'kvm: mmu: ITLB_MULTIHIT mitigation' which I
fixed up when merging the lot is still in your backports.
4) Random 'RHEL:' tags which are nowhere in the upstream commit have
really no place in stable kernels.
Groan, you are doing kernel development for how long now?
Sorry for my lousy mood, but after staring into futex code 3 days straight,
this was really what I needed - NOT. I really was hoping just to do a pull
and write a merge message and not wasting an hour for untinkering.
I fixed it all up and I'm going to send out a bulletin with complete
TAA/NX bundles in a few.
Yours grumpy
tglx
prev parent reply other threads:[~2019-11-07 20:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 15:16 The Annnoying Affair has No eXcuses - Bulletin #3 Thomas Gleixner
2019-11-07 17:10 ` [MODERATED] " Paolo Bonzini
2019-11-07 18:48 ` mark gross
2019-11-07 20:11 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1911072046400.27903@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=speck@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).