Re: [SPAM] [PATCH v1 5/5] media: ir-spi: Unify indentation and comment style

From: Andi Shyti <andi.shyti@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Sean Young <sean@mess.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [SPAM] [PATCH v1 5/5] media: ir-spi: Unify indentation and comment style
Date: Tue, 5 Mar 2024 23:52:15 +0100	[thread overview]
Message-ID: <hwtodfwrgonzzf2dpoqa3b5b3v66ypp7uu7upsnt6dx7weua2f@byxbgpxurhmf> (raw)
In-Reply-To: <20240305174933.1370708-6-andriy.shevchenko@linux.intel.com>

Hi Andy,

On Tue, Mar 05, 2024 at 07:48:30PM +0200, Andy Shevchenko wrote:
> Unify the indentation and multi-line comment style.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/media/rc/ir-spi.c | 12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/media/rc/ir-spi.c b/drivers/media/rc/ir-spi.c
> index 801de3d108cc..8fc8e496e6aa 100644
> --- a/drivers/media/rc/ir-spi.c
> +++ b/drivers/media/rc/ir-spi.c
> @@ -36,8 +36,7 @@ struct ir_spi_data {
>  	struct regulator *regulator;
>  };
>  
> -static int ir_spi_tx(struct rc_dev *dev,
> -		     unsigned int *buffer, unsigned int count)
> +static int ir_spi_tx(struct rc_dev *dev, unsigned int *buffer, unsigned int count)

this goes over 80 characters, though. Not an error, but not worth
a change either.

I'm not going block the patch as the rest is OK.

Reviewed-by: Andi Shyti <andi.shyti@kernel.org>

Andi

>  {
>  	int i;
>  	int ret;
> @@ -57,7 +56,7 @@ static int ir_spi_tx(struct rc_dev *dev,
>  			return -EINVAL;
>  
>  		/*
> -		 * the first value in buffer is a pulse, so that 0, 2, 4, ...
> +		 * The first value in buffer is a pulse, so that 0, 2, 4, ...
>  		 * contain a pulse duration. On the contrary, 1, 3, 5, ...
>  		 * contain a space duration.
>  		 */
> @@ -146,9 +145,9 @@ static int ir_spi_probe(struct spi_device *spi)
>  	if (ret)
>  		dc = 50;
>  
> -	/* ir_spi_set_duty_cycle cannot fail,
> -	 * it returns int to be compatible with the
> -	 * rc->s_tx_duty_cycle function
> +	/*
> +	 * ir_spi_set_duty_cycle() cannot fail, it returns int
> +	 * to be compatible with the rc->s_tx_duty_cycle function.
>  	 */
>  	ir_spi_set_duty_cycle(idata->rc, dc);
>  
> @@ -177,7 +176,6 @@ static struct spi_driver ir_spi_driver = {
>  		.of_match_table = ir_spi_of_match,
>  	},
>  };
> -
>  module_spi_driver(ir_spi_driver);
>  
>  MODULE_AUTHOR("Andi Shyti <andi@etezian.org>");
> -- 
> 2.43.0.rc1.1.gbec44491f096
> 