From: Bjorn Helgaas <helgaas@kernel.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: maz@kernel.org, tglx@linutronix.de, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org,
s.hauer@pengutronix.de, kw@linux.com, bhelgaas@google.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
peng.fan@nxp.com, aisheng.dong@nxp.com, jdmason@kudzu.us,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
kishon@ti.com, lorenzo.pieralisi@arm.com, ntb@lists.linux.dev,
lznuaa@gmail.com, imx@lists.linux.dev,
manivannan.sadhasivam@linaro.org
Subject: Re: [PATCH v11 5/6] PCI: endpoint: cleanup pci-epf-vntb.c
Date: Mon, 19 Sep 2022 12:02:53 -0500 [thread overview]
Message-ID: <20220919170253.GA1011825@bhelgaas> (raw)
In-Reply-To: <20220919154038.187168-6-Frank.Li@nxp.com>
In subject (I mentioned this last time, too):
PCI: endpoint: pci-epf-vntb: Clean up
On Mon, Sep 19, 2022 at 10:40:37AM -0500, Frank Li wrote:
> Remove unused field: epf_db_phy.
> Remove __iomem before epf_db.
> Change epf_db to u32* from void *
> Remove dupicate check if (readl(ntb->epf_db + i * 4)).
s/dupicate/duplicate/
> Using sizeof(u32) instead of number 4 at all place.
>
> Clean up sparse build warning
> Using epf_db[i] instead of readl() because epf_db is located in local memory
> and allocated by dma_alloc_coherent()
Is "Using epf_db[i] ..." an sparse warning? The indentation suggests
that it is, but it doesn't seem related.
> Replace pci_epc_mem_free_addr() with pci_epf_free_space() at error handle path
> to match pci_epf_alloc_space().
>
> Cleanup warning found by scripts/kernel-doc
> Fix indentation of the struct epf_ntb_ctrl
> Consildate term
s/Consildate/Consolidate/
> host, host1 to HOST
> vhost, vHost, Vhost, VHOST2 to VHOST
next prev parent reply other threads:[~2022-09-19 17:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 15:40 [PATCH v11 0/6] PCI EP driver support MSI doorbell from host Frank Li
2022-09-19 15:40 ` [PATCH v11 1/6] platform-msi: export symbol platform_msi_create_irq_domain() Frank Li
2022-09-19 15:40 ` [PATCH v11 2/6] irqchip: allow pass down .pm field at IRQCHIP_PLATFORM_DRIVER_END Frank Li
2022-09-19 15:40 ` [PATCH v11 3/6] irqchip: Add IMX MU MSI controller driver Frank Li
2022-09-19 15:40 ` [PATCH v11 4/6] dt-bindings: irqchip: imx mu work as msi controller Frank Li
2022-09-19 15:40 ` [PATCH v11 5/6] PCI: endpoint: cleanup pci-epf-vntb.c Frank Li
2022-09-19 17:02 ` Bjorn Helgaas [this message]
2022-09-19 17:07 ` [EXT] " Frank Li
2022-09-19 15:40 ` [PATCH v11 6/6] PCI: endpoint: Add vNTB MSI support Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220919170253.GA1011825@bhelgaas \
--to=helgaas@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=jdmason@kudzu.us \
--cc=kernel@pengutronix.de \
--cc=kishon@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=lznuaa@gmail.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=maz@kernel.org \
--cc=ntb@lists.linux.dev \
--cc=peng.fan@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).