* [Intel-gfx] [PATCH] drm/i915/display: Drop redundant debug print
@ 2021-08-12 12:58 Swati Sharma
2021-08-13 7:46 ` Jani Nikula
0 siblings, 1 reply; 10+ messages in thread
From: Swati Sharma @ 2021-08-12 12:58 UTC (permalink / raw)
To: intel-gfx
Cc: Swati Sharma, Ankit Nautiyal, Uma Shankar, Jani Nikula,
Ville Syrj_l_, Imre Deak, Manasi Navare, Jos_ Roberto de Souza,
Sean Paul, stable
drm_dp_dpcd_read/write already has debug error message.
Drop redundant error messages which gives false
status even if correct value is read in drm_dp_dpcd_read().
Fixes: 9488a030ac91 ("drm/i915: Add support for enabling link status and recovery")
Cc: Swati Sharma <swati2.sharma@intel.com>
Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Cc: Uma Shankar <uma.shankar@intel.com> (v2)
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: "Ville Syrj_l_" <ville.syrjala@linux.intel.com>
Cc: Imre Deak <imre.deak@intel.com>
Cc: Manasi Navare <manasi.d.navare@intel.com>
Cc: Uma Shankar <uma.shankar@intel.com>
Cc: "Jos_ Roberto de Souza" <jose.souza@intel.com>
Cc: Sean Paul <seanpaul@chromium.org>
Cc: <stable@vger.kernel.org> # v5.12+
Link: https://patchwork.freedesktop.org/patch/msgid/20201218103723.30844-12-ankit.k.nautiyal@intel.com
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index c386ef8eb200..5c84f51ad41d 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -3871,16 +3871,12 @@ static void intel_dp_check_link_service_irq(struct intel_dp *intel_dp)
return;
if (drm_dp_dpcd_readb(&intel_dp->aux,
- DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val) {
- drm_dbg_kms(&i915->drm, "Error in reading link service irq vector\n");
+ DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val)
return;
- }
if (drm_dp_dpcd_writeb(&intel_dp->aux,
- DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1) {
- drm_dbg_kms(&i915->drm, "Error in writing link service irq vector\n");
+ DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1)
return;
- }
if (val & HDMI_LINK_STATUS_CHANGED)
intel_dp_handle_hdmi_link_status_change(intel_dp);
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Drop redundant debug print
2021-08-12 12:58 [Intel-gfx] [PATCH] drm/i915/display: Drop redundant debug print Swati Sharma
@ 2021-08-13 7:46 ` Jani Nikula
2021-08-16 11:54 ` Sharma, Swati2
0 siblings, 1 reply; 10+ messages in thread
From: Jani Nikula @ 2021-08-13 7:46 UTC (permalink / raw)
To: Swati Sharma, intel-gfx
Cc: Swati Sharma, Ankit Nautiyal, Uma Shankar, Ville Syrj_l_,
Imre Deak, Manasi Navare, Jos_ Roberto de Souza, Sean Paul,
stable
On Thu, 12 Aug 2021, Swati Sharma <swati2.sharma@intel.com> wrote:
> drm_dp_dpcd_read/write already has debug error message.
> Drop redundant error messages which gives false
> status even if correct value is read in drm_dp_dpcd_read().
I guess the only problem is it gets harder to associate the preceding
low level error messages with intel_dp_check_link_service_irq(). *shrug*
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
> Fixes: 9488a030ac91 ("drm/i915: Add support for enabling link status and recovery")
> Cc: Swati Sharma <swati2.sharma@intel.com>
> Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> Cc: Uma Shankar <uma.shankar@intel.com> (v2)
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: "Ville Syrj_l_" <ville.syrjala@linux.intel.com>
> Cc: Imre Deak <imre.deak@intel.com>
> Cc: Manasi Navare <manasi.d.navare@intel.com>
> Cc: Uma Shankar <uma.shankar@intel.com>
> Cc: "Jos_ Roberto de Souza" <jose.souza@intel.com>
> Cc: Sean Paul <seanpaul@chromium.org>
> Cc: <stable@vger.kernel.org> # v5.12+
>
> Link: https://patchwork.freedesktop.org/patch/msgid/20201218103723.30844-12-ankit.k.nautiyal@intel.com
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index c386ef8eb200..5c84f51ad41d 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -3871,16 +3871,12 @@ static void intel_dp_check_link_service_irq(struct intel_dp *intel_dp)
> return;
>
> if (drm_dp_dpcd_readb(&intel_dp->aux,
> - DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val) {
> - drm_dbg_kms(&i915->drm, "Error in reading link service irq vector\n");
> + DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val)
> return;
> - }
>
> if (drm_dp_dpcd_writeb(&intel_dp->aux,
> - DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1) {
> - drm_dbg_kms(&i915->drm, "Error in writing link service irq vector\n");
> + DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1)
> return;
> - }
>
> if (val & HDMI_LINK_STATUS_CHANGED)
> intel_dp_handle_hdmi_link_status_change(intel_dp);
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Drop redundant debug print
2021-08-13 7:46 ` Jani Nikula
@ 2021-08-16 11:54 ` Sharma, Swati2
2021-08-16 12:10 ` Jani Nikula
0 siblings, 1 reply; 10+ messages in thread
From: Sharma, Swati2 @ 2021-08-16 11:54 UTC (permalink / raw)
To: Jani Nikula, intel-gfx
Cc: Ankit Nautiyal, Uma Shankar, Ville Syrj_l_, Imre Deak,
Manasi Navare, Jos_ Roberto de Souza, Sean Paul, stable
On 13-Aug-21 1:16 PM, Jani Nikula wrote:
> On Thu, 12 Aug 2021, Swati Sharma <swati2.sharma@intel.com> wrote:
>> drm_dp_dpcd_read/write already has debug error message.
>> Drop redundant error messages which gives false
>> status even if correct value is read in drm_dp_dpcd_read().
>
> I guess the only problem is it gets harder to associate the preceding
> low level error messages with intel_dp_check_link_service_irq(). *shrug*
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
>
Thanks Jani for the review. Can you please merge?
>>
>> Fixes: 9488a030ac91 ("drm/i915: Add support for enabling link status and recovery")
>> Cc: Swati Sharma <swati2.sharma@intel.com>
>> Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
>> Cc: Uma Shankar <uma.shankar@intel.com> (v2)
>> Cc: Jani Nikula <jani.nikula@intel.com>
>> Cc: "Ville Syrj_l_" <ville.syrjala@linux.intel.com>
>> Cc: Imre Deak <imre.deak@intel.com>
>> Cc: Manasi Navare <manasi.d.navare@intel.com>
>> Cc: Uma Shankar <uma.shankar@intel.com>
>> Cc: "Jos_ Roberto de Souza" <jose.souza@intel.com>
>> Cc: Sean Paul <seanpaul@chromium.org>
>> Cc: <stable@vger.kernel.org> # v5.12+
>>
>> Link: https://patchwork.freedesktop.org/patch/msgid/20201218103723.30844-12-ankit.k.nautiyal@intel.com
>> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_dp.c | 8 ++------
>> 1 file changed, 2 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
>> index c386ef8eb200..5c84f51ad41d 100644
>> --- a/drivers/gpu/drm/i915/display/intel_dp.c
>> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
>> @@ -3871,16 +3871,12 @@ static void intel_dp_check_link_service_irq(struct intel_dp *intel_dp)
>> return;
>>
>> if (drm_dp_dpcd_readb(&intel_dp->aux,
>> - DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val) {
>> - drm_dbg_kms(&i915->drm, "Error in reading link service irq vector\n");
>> + DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val)
>> return;
>> - }
>>
>> if (drm_dp_dpcd_writeb(&intel_dp->aux,
>> - DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1) {
>> - drm_dbg_kms(&i915->drm, "Error in writing link service irq vector\n");
>> + DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1)
>> return;
>> - }
>>
>> if (val & HDMI_LINK_STATUS_CHANGED)
>> intel_dp_handle_hdmi_link_status_change(intel_dp);
>
--
~Swati Sharma
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Drop redundant debug print
2021-08-16 11:54 ` Sharma, Swati2
@ 2021-08-16 12:10 ` Jani Nikula
2021-08-16 12:17 ` Sharma, Swati2
0 siblings, 1 reply; 10+ messages in thread
From: Jani Nikula @ 2021-08-16 12:10 UTC (permalink / raw)
To: Sharma, Swati2, intel-gfx
Cc: Ankit Nautiyal, Uma Shankar, Ville Syrj_l_, Imre Deak,
Manasi Navare, Jos_ Roberto de Souza, Sean Paul, stable
On Mon, 16 Aug 2021, "Sharma, Swati2" <swati2.sharma@intel.com> wrote:
> On 13-Aug-21 1:16 PM, Jani Nikula wrote:
>> On Thu, 12 Aug 2021, Swati Sharma <swati2.sharma@intel.com> wrote:
>>> drm_dp_dpcd_read/write already has debug error message.
>>> Drop redundant error messages which gives false
>>> status even if correct value is read in drm_dp_dpcd_read().
>>
>> I guess the only problem is it gets harder to associate the preceding
>> low level error messages with intel_dp_check_link_service_irq(). *shrug*
>>
>> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>>
>>
> Thanks Jani for the review. Can you please merge?
There was another version with open review?
BR,
Jani.
>
>>>
>>> Fixes: 9488a030ac91 ("drm/i915: Add support for enabling link status and recovery")
>>> Cc: Swati Sharma <swati2.sharma@intel.com>
>>> Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
>>> Cc: Uma Shankar <uma.shankar@intel.com> (v2)
>>> Cc: Jani Nikula <jani.nikula@intel.com>
>>> Cc: "Ville Syrj_l_" <ville.syrjala@linux.intel.com>
>>> Cc: Imre Deak <imre.deak@intel.com>
>>> Cc: Manasi Navare <manasi.d.navare@intel.com>
>>> Cc: Uma Shankar <uma.shankar@intel.com>
>>> Cc: "Jos_ Roberto de Souza" <jose.souza@intel.com>
>>> Cc: Sean Paul <seanpaul@chromium.org>
>>> Cc: <stable@vger.kernel.org> # v5.12+
>>>
>>> Link: https://patchwork.freedesktop.org/patch/msgid/20201218103723.30844-12-ankit.k.nautiyal@intel.com
>>> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
>>> ---
>>> drivers/gpu/drm/i915/display/intel_dp.c | 8 ++------
>>> 1 file changed, 2 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
>>> index c386ef8eb200..5c84f51ad41d 100644
>>> --- a/drivers/gpu/drm/i915/display/intel_dp.c
>>> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
>>> @@ -3871,16 +3871,12 @@ static void intel_dp_check_link_service_irq(struct intel_dp *intel_dp)
>>> return;
>>>
>>> if (drm_dp_dpcd_readb(&intel_dp->aux,
>>> - DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val) {
>>> - drm_dbg_kms(&i915->drm, "Error in reading link service irq vector\n");
>>> + DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val)
>>> return;
>>> - }
>>>
>>> if (drm_dp_dpcd_writeb(&intel_dp->aux,
>>> - DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1) {
>>> - drm_dbg_kms(&i915->drm, "Error in writing link service irq vector\n");
>>> + DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1)
>>> return;
>>> - }
>>>
>>> if (val & HDMI_LINK_STATUS_CHANGED)
>>> intel_dp_handle_hdmi_link_status_change(intel_dp);
>>
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Drop redundant debug print
2021-08-16 12:10 ` Jani Nikula
@ 2021-08-16 12:17 ` Sharma, Swati2
2021-08-16 12:28 ` Jani Nikula
0 siblings, 1 reply; 10+ messages in thread
From: Sharma, Swati2 @ 2021-08-16 12:17 UTC (permalink / raw)
To: Jani Nikula, intel-gfx
Cc: Ankit Nautiyal, Uma Shankar, Ville Syrj_l_, Imre Deak,
Manasi Navare, Jos_ Roberto de Souza, Sean Paul, stable
On 16-Aug-21 5:40 PM, Jani Nikula wrote:
> On Mon, 16 Aug 2021, "Sharma, Swati2" <swati2.sharma@intel.com> wrote:
>> On 13-Aug-21 1:16 PM, Jani Nikula wrote:
>>> On Thu, 12 Aug 2021, Swati Sharma <swati2.sharma@intel.com> wrote:
>>>> drm_dp_dpcd_read/write already has debug error message.
>>>> Drop redundant error messages which gives false
>>>> status even if correct value is read in drm_dp_dpcd_read().
>>>
>>> I guess the only problem is it gets harder to associate the preceding
>>> low level error messages with intel_dp_check_link_service_irq(). *shrug*
>>>
>>> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>>>
>>>
>> Thanks Jani for the review. Can you please merge?
>
> There was another version with open review?
Yes. https://patchwork.freedesktop.org/series/93025/#rev3
Should I add debug prints how Imre suggested in other IRQ func
to make it generic or should it be dropped from here too?
Quoting imre
"Yes, that's why I suggested to return for the '0 value read' case
without any message printed, but still keep the message for the case
when the drm_dp_dpcd_readb() fails."
"Ok, it's good to keep them in sync at least, so I'm ok with removing
the debug messages from here too."
Please let me know what is the better approach.
>
> BR,
> Jani.
>
>
>>
>>>>
>>>> Fixes: 9488a030ac91 ("drm/i915: Add support for enabling link status and recovery")
>>>> Cc: Swati Sharma <swati2.sharma@intel.com>
>>>> Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
>>>> Cc: Uma Shankar <uma.shankar@intel.com> (v2)
>>>> Cc: Jani Nikula <jani.nikula@intel.com>
>>>> Cc: "Ville Syrj_l_" <ville.syrjala@linux.intel.com>
>>>> Cc: Imre Deak <imre.deak@intel.com>
>>>> Cc: Manasi Navare <manasi.d.navare@intel.com>
>>>> Cc: Uma Shankar <uma.shankar@intel.com>
>>>> Cc: "Jos_ Roberto de Souza" <jose.souza@intel.com>
>>>> Cc: Sean Paul <seanpaul@chromium.org>
>>>> Cc: <stable@vger.kernel.org> # v5.12+
>>>>
>>>> Link: https://patchwork.freedesktop.org/patch/msgid/20201218103723.30844-12-ankit.k.nautiyal@intel.com
>>>> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
>>>> ---
>>>> drivers/gpu/drm/i915/display/intel_dp.c | 8 ++------
>>>> 1 file changed, 2 insertions(+), 6 deletions(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
>>>> index c386ef8eb200..5c84f51ad41d 100644
>>>> --- a/drivers/gpu/drm/i915/display/intel_dp.c
>>>> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
>>>> @@ -3871,16 +3871,12 @@ static void intel_dp_check_link_service_irq(struct intel_dp *intel_dp)
>>>> return;
>>>>
>>>> if (drm_dp_dpcd_readb(&intel_dp->aux,
>>>> - DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val) {
>>>> - drm_dbg_kms(&i915->drm, "Error in reading link service irq vector\n");
>>>> + DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val)
>>>> return;
>>>> - }
>>>>
>>>> if (drm_dp_dpcd_writeb(&intel_dp->aux,
>>>> - DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1) {
>>>> - drm_dbg_kms(&i915->drm, "Error in writing link service irq vector\n");
>>>> + DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1)
>>>> return;
>>>> - }
>>>>
>>>> if (val & HDMI_LINK_STATUS_CHANGED)
>>>> intel_dp_handle_hdmi_link_status_change(intel_dp);
>>>
>
--
~Swati Sharma
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Drop redundant debug print
2021-08-16 12:17 ` Sharma, Swati2
@ 2021-08-16 12:28 ` Jani Nikula
2021-08-19 14:09 ` Sharma, Swati2
0 siblings, 1 reply; 10+ messages in thread
From: Jani Nikula @ 2021-08-16 12:28 UTC (permalink / raw)
To: Sharma, Swati2, intel-gfx
Cc: Ankit Nautiyal, Uma Shankar, Ville Syrj_l_, Imre Deak,
Manasi Navare, Jos_ Roberto de Souza, Sean Paul, stable
On Mon, 16 Aug 2021, "Sharma, Swati2" <swati2.sharma@intel.com> wrote:
> On 16-Aug-21 5:40 PM, Jani Nikula wrote:
>> On Mon, 16 Aug 2021, "Sharma, Swati2" <swati2.sharma@intel.com> wrote:
>>> On 13-Aug-21 1:16 PM, Jani Nikula wrote:
>>>> On Thu, 12 Aug 2021, Swati Sharma <swati2.sharma@intel.com> wrote:
>>>>> drm_dp_dpcd_read/write already has debug error message.
>>>>> Drop redundant error messages which gives false
>>>>> status even if correct value is read in drm_dp_dpcd_read().
>>>>
>>>> I guess the only problem is it gets harder to associate the preceding
>>>> low level error messages with intel_dp_check_link_service_irq(). *shrug*
>>>>
>>>> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>>>>
>>>>
>>> Thanks Jani for the review. Can you please merge?
>>
>> There was another version with open review?
>
> Yes. https://patchwork.freedesktop.org/series/93025/#rev3
> Should I add debug prints how Imre suggested in other IRQ func
> to make it generic or should it be dropped from here too?
> Quoting imre
> "Yes, that's why I suggested to return for the '0 value read' case
> without any message printed, but still keep the message for the case
> when the drm_dp_dpcd_readb() fails."
> "Ok, it's good to keep them in sync at least, so I'm ok with removing
> the debug messages from here too."
>
> Please let me know what is the better approach.
IMO just nuke them.
BR,
Jani
>>
>> BR,
>> Jani.
>>
>>
>>>
>>>>>
>>>>> Fixes: 9488a030ac91 ("drm/i915: Add support for enabling link status and recovery")
>>>>> Cc: Swati Sharma <swati2.sharma@intel.com>
>>>>> Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
>>>>> Cc: Uma Shankar <uma.shankar@intel.com> (v2)
>>>>> Cc: Jani Nikula <jani.nikula@intel.com>
>>>>> Cc: "Ville Syrj_l_" <ville.syrjala@linux.intel.com>
>>>>> Cc: Imre Deak <imre.deak@intel.com>
>>>>> Cc: Manasi Navare <manasi.d.navare@intel.com>
>>>>> Cc: Uma Shankar <uma.shankar@intel.com>
>>>>> Cc: "Jos_ Roberto de Souza" <jose.souza@intel.com>
>>>>> Cc: Sean Paul <seanpaul@chromium.org>
>>>>> Cc: <stable@vger.kernel.org> # v5.12+
>>>>>
>>>>> Link: https://patchwork.freedesktop.org/patch/msgid/20201218103723.30844-12-ankit.k.nautiyal@intel.com
>>>>> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
>>>>> ---
>>>>> drivers/gpu/drm/i915/display/intel_dp.c | 8 ++------
>>>>> 1 file changed, 2 insertions(+), 6 deletions(-)
>>>>>
>>>>> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
>>>>> index c386ef8eb200..5c84f51ad41d 100644
>>>>> --- a/drivers/gpu/drm/i915/display/intel_dp.c
>>>>> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
>>>>> @@ -3871,16 +3871,12 @@ static void intel_dp_check_link_service_irq(struct intel_dp *intel_dp)
>>>>> return;
>>>>>
>>>>> if (drm_dp_dpcd_readb(&intel_dp->aux,
>>>>> - DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val) {
>>>>> - drm_dbg_kms(&i915->drm, "Error in reading link service irq vector\n");
>>>>> + DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val)
>>>>> return;
>>>>> - }
>>>>>
>>>>> if (drm_dp_dpcd_writeb(&intel_dp->aux,
>>>>> - DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1) {
>>>>> - drm_dbg_kms(&i915->drm, "Error in writing link service irq vector\n");
>>>>> + DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1)
>>>>> return;
>>>>> - }
>>>>>
>>>>> if (val & HDMI_LINK_STATUS_CHANGED)
>>>>> intel_dp_handle_hdmi_link_status_change(intel_dp);
>>>>
>>
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Drop redundant debug print
2021-08-16 12:28 ` Jani Nikula
@ 2021-08-19 14:09 ` Sharma, Swati2
0 siblings, 0 replies; 10+ messages in thread
From: Sharma, Swati2 @ 2021-08-19 14:09 UTC (permalink / raw)
To: Jani Nikula, intel-gfx
Cc: Ankit Nautiyal, Uma Shankar, Ville Syrj_l_, Imre Deak,
Manasi Navare, Jos_ Roberto de Souza, Sean Paul, stable
On 16-Aug-21 5:58 PM, Jani Nikula wrote:
> On Mon, 16 Aug 2021, "Sharma, Swati2" <swati2.sharma@intel.com> wrote:
>> On 16-Aug-21 5:40 PM, Jani Nikula wrote:
>>> On Mon, 16 Aug 2021, "Sharma, Swati2" <swati2.sharma@intel.com> wrote:
>>>> On 13-Aug-21 1:16 PM, Jani Nikula wrote:
>>>>> On Thu, 12 Aug 2021, Swati Sharma <swati2.sharma@intel.com> wrote:
>>>>>> drm_dp_dpcd_read/write already has debug error message.
>>>>>> Drop redundant error messages which gives false
>>>>>> status even if correct value is read in drm_dp_dpcd_read().
>>>>>
>>>>> I guess the only problem is it gets harder to associate the preceding
>>>>> low level error messages with intel_dp_check_link_service_irq(). *shrug*
>>>>>
>>>>> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>>>>>
>>>>>
>>>> Thanks Jani for the review. Can you please merge?
>>>
>>> There was another version with open review?
>>
>> Yes. https://patchwork.freedesktop.org/series/93025/#rev3
>> Should I add debug prints how Imre suggested in other IRQ func
>> to make it generic or should it be dropped from here too?
>> Quoting imre
>> "Yes, that's why I suggested to return for the '0 value read' case
>> without any message printed, but still keep the message for the case
>> when the drm_dp_dpcd_readb() fails."
>> "Ok, it's good to keep them in sync at least, so I'm ok with removing
>> the debug messages from here too."
>>
>> Please let me know what is the better approach.
>
> IMO just nuke them.
Thanks Jani N. Imre agrees on same. Can we merge now?
https://patchwork.freedesktop.org/series/93025/#rev3
>
> BR,
> Jani
>
>
>
>>>
>>> BR,
>>> Jani.
>>>
>>>
>>>>
>>>>>>
>>>>>> Fixes: 9488a030ac91 ("drm/i915: Add support for enabling link status and recovery")
>>>>>> Cc: Swati Sharma <swati2.sharma@intel.com>
>>>>>> Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
>>>>>> Cc: Uma Shankar <uma.shankar@intel.com> (v2)
>>>>>> Cc: Jani Nikula <jani.nikula@intel.com>
>>>>>> Cc: "Ville Syrj_l_" <ville.syrjala@linux.intel.com>
>>>>>> Cc: Imre Deak <imre.deak@intel.com>
>>>>>> Cc: Manasi Navare <manasi.d.navare@intel.com>
>>>>>> Cc: Uma Shankar <uma.shankar@intel.com>
>>>>>> Cc: "Jos_ Roberto de Souza" <jose.souza@intel.com>
>>>>>> Cc: Sean Paul <seanpaul@chromium.org>
>>>>>> Cc: <stable@vger.kernel.org> # v5.12+
>>>>>>
>>>>>> Link: https://patchwork.freedesktop.org/patch/msgid/20201218103723.30844-12-ankit.k.nautiyal@intel.com
>>>>>> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
>>>>>> ---
>>>>>> drivers/gpu/drm/i915/display/intel_dp.c | 8 ++------
>>>>>> 1 file changed, 2 insertions(+), 6 deletions(-)
>>>>>>
>>>>>> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
>>>>>> index c386ef8eb200..5c84f51ad41d 100644
>>>>>> --- a/drivers/gpu/drm/i915/display/intel_dp.c
>>>>>> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
>>>>>> @@ -3871,16 +3871,12 @@ static void intel_dp_check_link_service_irq(struct intel_dp *intel_dp)
>>>>>> return;
>>>>>>
>>>>>> if (drm_dp_dpcd_readb(&intel_dp->aux,
>>>>>> - DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val) {
>>>>>> - drm_dbg_kms(&i915->drm, "Error in reading link service irq vector\n");
>>>>>> + DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val)
>>>>>> return;
>>>>>> - }
>>>>>>
>>>>>> if (drm_dp_dpcd_writeb(&intel_dp->aux,
>>>>>> - DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1) {
>>>>>> - drm_dbg_kms(&i915->drm, "Error in writing link service irq vector\n");
>>>>>> + DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1)
>>>>>> return;
>>>>>> - }
>>>>>>
>>>>>> if (val & HDMI_LINK_STATUS_CHANGED)
>>>>>> intel_dp_handle_hdmi_link_status_change(intel_dp);
>>>>>
>>>
>
--
~Swati Sharma
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Drop redundant debug print
2021-07-26 18:51 Swati Sharma
2021-07-27 0:07 ` kernel test robot
@ 2021-08-12 5:47 ` Nautiyal, Ankit K
1 sibling, 0 replies; 10+ messages in thread
From: Nautiyal, Ankit K @ 2021-08-12 5:47 UTC (permalink / raw)
To: Swati Sharma, intel-gfx
Patch looks good to me.
I think we must add fixes tag with the below commit:
https://cgit.freedesktop.org/drm-tip/commit/?id=9488a030ac91447ea186ca3b7ec5c72ff03bc202
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
On 7/27/2021 12:21 AM, Swati Sharma wrote:
> drm_dp_dpcd_read/write already has debug error message.
> Drop redundant error messages which gives false
> status even if correct value is read in drm_dp_dpcd_read().
>
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index c386ef8eb200..5c84f51ad41d 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -3871,16 +3871,12 @@ static void intel_dp_check_link_service_irq(struct intel_dp *intel_dp)
> return;
>
> if (drm_dp_dpcd_readb(&intel_dp->aux,
> - DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val) {
> - drm_dbg_kms(&i915->drm, "Error in reading link service irq vector\n");
> + DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val)
> return;
> - }
>
> if (drm_dp_dpcd_writeb(&intel_dp->aux,
> - DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1) {
> - drm_dbg_kms(&i915->drm, "Error in writing link service irq vector\n");
> + DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1)
> return;
> - }
>
> if (val & HDMI_LINK_STATUS_CHANGED)
> intel_dp_handle_hdmi_link_status_change(intel_dp);
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Drop redundant debug print
2021-07-26 18:51 Swati Sharma
@ 2021-07-27 0:07 ` kernel test robot
2021-08-12 5:47 ` Nautiyal, Ankit K
1 sibling, 0 replies; 10+ messages in thread
From: kernel test robot @ 2021-07-27 0:07 UTC (permalink / raw)
To: Swati Sharma, intel-gfx; +Cc: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 4256 bytes --]
Hi Swati,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip v5.14-rc3 next-20210726]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Swati-Sharma/drm-i915-display-Drop-redundant-debug-print/20210727-024330
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-a013-20210727 (attached as .config)
compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/acb6cc54386ff61ebce42832ee7fe1d68bb82141
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Swati-Sharma/drm-i915-display-Drop-redundant-debug-print/20210727-024330
git checkout acb6cc54386ff61ebce42832ee7fe1d68bb82141
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/gpu/drm/i915/display/intel_dp.c: In function 'intel_dp_check_link_service_irq':
>> drivers/gpu/drm/i915/display/intel_dp.c:3867:27: error: unused variable 'i915' [-Werror=unused-variable]
3867 | struct drm_i915_private *i915 = dp_to_i915(intel_dp);
| ^~~~
cc1: all warnings being treated as errors
vim +/i915 +3867 drivers/gpu/drm/i915/display/intel_dp.c
9844bc87cb7a59 drivers/gpu/drm/i915/intel_dp.c Dhinakaran Pandiyan 2018-09-27 3864
9488a030ac9144 drivers/gpu/drm/i915/display/intel_dp.c Swati Sharma 2020-12-18 3865 static void intel_dp_check_link_service_irq(struct intel_dp *intel_dp)
9488a030ac9144 drivers/gpu/drm/i915/display/intel_dp.c Swati Sharma 2020-12-18 3866 {
9488a030ac9144 drivers/gpu/drm/i915/display/intel_dp.c Swati Sharma 2020-12-18 @3867 struct drm_i915_private *i915 = dp_to_i915(intel_dp);
9488a030ac9144 drivers/gpu/drm/i915/display/intel_dp.c Swati Sharma 2020-12-18 3868 u8 val;
9488a030ac9144 drivers/gpu/drm/i915/display/intel_dp.c Swati Sharma 2020-12-18 3869
9488a030ac9144 drivers/gpu/drm/i915/display/intel_dp.c Swati Sharma 2020-12-18 3870 if (intel_dp->dpcd[DP_DPCD_REV] < 0x11)
9488a030ac9144 drivers/gpu/drm/i915/display/intel_dp.c Swati Sharma 2020-12-18 3871 return;
9488a030ac9144 drivers/gpu/drm/i915/display/intel_dp.c Swati Sharma 2020-12-18 3872
9488a030ac9144 drivers/gpu/drm/i915/display/intel_dp.c Swati Sharma 2020-12-18 3873 if (drm_dp_dpcd_readb(&intel_dp->aux,
acb6cc54386ff6 drivers/gpu/drm/i915/display/intel_dp.c Swati Sharma 2021-07-27 3874 DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val)
9488a030ac9144 drivers/gpu/drm/i915/display/intel_dp.c Swati Sharma 2020-12-18 3875 return;
9488a030ac9144 drivers/gpu/drm/i915/display/intel_dp.c Swati Sharma 2020-12-18 3876
9488a030ac9144 drivers/gpu/drm/i915/display/intel_dp.c Swati Sharma 2020-12-18 3877 if (drm_dp_dpcd_writeb(&intel_dp->aux,
acb6cc54386ff6 drivers/gpu/drm/i915/display/intel_dp.c Swati Sharma 2021-07-27 3878 DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1)
9488a030ac9144 drivers/gpu/drm/i915/display/intel_dp.c Swati Sharma 2020-12-18 3879 return;
9488a030ac9144 drivers/gpu/drm/i915/display/intel_dp.c Swati Sharma 2020-12-18 3880
9488a030ac9144 drivers/gpu/drm/i915/display/intel_dp.c Swati Sharma 2020-12-18 3881 if (val & HDMI_LINK_STATUS_CHANGED)
9488a030ac9144 drivers/gpu/drm/i915/display/intel_dp.c Swati Sharma 2020-12-18 3882 intel_dp_handle_hdmi_link_status_change(intel_dp);
9488a030ac9144 drivers/gpu/drm/i915/display/intel_dp.c Swati Sharma 2020-12-18 3883 }
9488a030ac9144 drivers/gpu/drm/i915/display/intel_dp.c Swati Sharma 2020-12-18 3884
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31047 bytes --]
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/display: Drop redundant debug print
@ 2021-07-26 18:51 Swati Sharma
2021-07-27 0:07 ` kernel test robot
2021-08-12 5:47 ` Nautiyal, Ankit K
0 siblings, 2 replies; 10+ messages in thread
From: Swati Sharma @ 2021-07-26 18:51 UTC (permalink / raw)
To: intel-gfx
drm_dp_dpcd_read/write already has debug error message.
Drop redundant error messages which gives false
status even if correct value is read in drm_dp_dpcd_read().
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index c386ef8eb200..5c84f51ad41d 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -3871,16 +3871,12 @@ static void intel_dp_check_link_service_irq(struct intel_dp *intel_dp)
return;
if (drm_dp_dpcd_readb(&intel_dp->aux,
- DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val) {
- drm_dbg_kms(&i915->drm, "Error in reading link service irq vector\n");
+ DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val)
return;
- }
if (drm_dp_dpcd_writeb(&intel_dp->aux,
- DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1) {
- drm_dbg_kms(&i915->drm, "Error in writing link service irq vector\n");
+ DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1)
return;
- }
if (val & HDMI_LINK_STATUS_CHANGED)
intel_dp_handle_hdmi_link_status_change(intel_dp);
--
2.25.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-08-19 14:09 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-12 12:58 [Intel-gfx] [PATCH] drm/i915/display: Drop redundant debug print Swati Sharma
2021-08-13 7:46 ` Jani Nikula
2021-08-16 11:54 ` Sharma, Swati2
2021-08-16 12:10 ` Jani Nikula
2021-08-16 12:17 ` Sharma, Swati2
2021-08-16 12:28 ` Jani Nikula
2021-08-19 14:09 ` Sharma, Swati2
-- strict thread matches above, loose matches on Subject: below --
2021-07-26 18:51 Swati Sharma
2021-07-27 0:07 ` kernel test robot
2021-08-12 5:47 ` Nautiyal, Ankit K
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).