From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 2/3] drm/i915: split irq handling into per-chipset functions Date: Thu, 07 Apr 2011 22:50:42 +0100 Message-ID: <0d30dc$lom25v@orsmga001.jf.intel.com> References: <1302211980-10089-1-git-send-email-jbarnes@virtuousgeek.org> <1302211980-10089-3-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id C86159F0E7 for ; Thu, 7 Apr 2011 14:50:45 -0700 (PDT) In-Reply-To: <1302211980-10089-3-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, 7 Apr 2011 14:32:59 -0700, Jesse Barnes wrote: > Set the IRQ handling functions in driver load so they'll just be used > directly, rather than branching over most of the code in the chipset > functions. This is the direction we definitely need to go in. However, it is still a tangled mess of which functions are called for which chipset. Is it any clearer to have a display vfunc table for each chipset? It would still be a mess, but at least there will be an overview of how each chipset works in a single spot. Invaluable for tracing through the function pointers later. One thing we need to be careful is to move the common code into small helper routines to avoid unnecessarily duplicating it. -Chris -- Chris Wilson, Intel Open Source Technology Centre