From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: Relinquish any fence when changing cache levels Date: Wed, 13 Apr 2011 22:42:54 +0100 Message-ID: <0d30dc$lr13nf@orsmga001.jf.intel.com> References: <87bp0ahzwn.fsf@pollan.anholt.net> <1302717671-1914-1-git-send-email-chris@chris-wilson.co.uk> <20110413204646.GL3660@viiv.ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id E46FD9E74D for ; Wed, 13 Apr 2011 14:42:57 -0700 (PDT) In-Reply-To: <20110413204646.GL3660@viiv.ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, 13 Apr 2011 22:46:47 +0200, Daniel Vetter wrote: > set_cache_level is rather unused on pre-snb. Can't we just hold off with > such complexity before we actually use it in e.g. the vmap code? Maybe add > a WARN_ON(gen < 6) instead? You might argue that set_cache_level is not used even on SNB at the point at which we are writing the interface for it... Once you've finished reviewing this code, I have another batch... ;-) -Chris -- Chris Wilson, Intel Open Source Technology Centre