From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH 1/2] drm/i915: Combine pinning after setting
	to the display plane
Date: Sat, 16 Apr 2011 07:26:36 +0100
Message-ID: <0d30dc$ls6be9@orsmga001.jf.intel.com>
References: <1302771827-26112-9-git-send-email-chris@chris-wilson.co.uk>
	<1302847454-716-1-git-send-email-chris@chris-wilson.co.uk>
	<20110415121123.GA3503@viiv.ffwll.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
	by gabe.freedesktop.org (Postfix) with ESMTP id 5565E9E828
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 15 Apr 2011 23:26:40 -0700 (PDT)
In-Reply-To: <20110415121123.GA3503@viiv.ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Fri, 15 Apr 2011 14:11:25 +0200, Daniel Vetter <daniel@ffwll.ch> wrote:
> But in that version you're calling set_to_gtt_domain which calls
> flush_gpu_write_domain and then waits synchronously when
> obj->pending_gpu_write is set. Which is almost guaranteed to happen for
> pageflips.

Gah. Completely destroying the sole reason why set_to_display_plane()
was first introduced.

I've slept, had some coffee, even felt inspired to add some more
comments...

Thanks,
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre