From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Anholt <eric@anholt.net>
Subject: Splitting HAS_PCH_SPLIT code in intel_crtc_mode_set().
Date: Wed, 30 Mar 2011 13:01:01 -0700
Message-ID: <1301515270-3768-1-git-send-email-eric@anholt.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from annarchy.freedesktop.org (annarchy.freedesktop.org
	[131.252.210.176])
	by gabe.freedesktop.org (Postfix) with ESMTP id C17E79E79C
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 30 Mar 2011 13:01:17 -0700 (PDT)
Received: from pollan.anholt.net (annarchy.freedesktop.org [127.0.0.1])
	by annarchy.freedesktop.org (Postfix) with ESMTP id 698DF130052
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 30 Mar 2011 13:01:17 -0700 (PDT)
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

In doing new chipset enablement for the first time in quite a while,
it sunk in just how bad the spaghetti in our modeset path was these
days.  I think that splitting the crtc_mode_set up a bit gets us a
more readable path for whichever generation you're trying to look at,
while not duplicating too much code -- note that patch 1/9 is +675
LOC, while after 8/9 we're down to +299 overall.

To atone for about +300LOC, patch 9/9 does another cleanup I think is
appropriate and cuts almost 300 lines of used-once #define spam.

This is only tested on my Ironlake so far, and only for LVDS.