Intel-GFX Archive on
 help / color / Atom feed
From: Chris Wilson <>
Cc: Daniel Vetter <>
Subject: [PATCH 3/3] drm/i915: Only enable the plane after setting the fb base (pre-ILK)
Date: Tue, 19 Apr 2011 21:32:03 +0100
Message-ID: <> (raw)
In-Reply-To: <>

When enabling the plane, it is helpful to have already pointed that
plane to valid memory or else we may incur the wrath of a PGTBL_ER.
This code preserved the behaviour from the bad old days for unknown

Found by assert_fb_bound_for_plane().

Signed-off-by: Chris Wilson <>
Cc: Daniel Vetter <>
Cc: Jesse Barnes <>
 drivers/gpu/drm/i915/intel_display.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index b9bb20d..f503ad0 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -5212,8 +5212,6 @@ static int intel_crtc_mode_set(struct drm_crtc *crtc,
 	I915_WRITE(DSPCNTR(plane), dspcntr);
-	if (!HAS_PCH_SPLIT(dev))
-		intel_enable_plane(dev_priv, plane, pipe);
 	ret = intel_pipe_set_base(crtc, x, y, old_fb);

  parent reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-19 20:32 Modesetting fixes for pre-ILK, 915GM especially Chris Wilson
2011-04-19 20:32 ` [PATCH 1/3] drm/i915: Check that the plane points to the pipe's framebuffer before enabling Chris Wilson
2011-04-19 20:40   ` Jesse Barnes
2011-04-19 20:32 ` [PATCH 2/3] drm/i915: Attach a fb to the load-detect pipe Chris Wilson
2011-04-19 21:26   ` Keith Packard
2011-04-20  9:25     ` Chris Wilson
2011-04-19 20:32 ` Chris Wilson [this message]
2011-04-19 20:39   ` [PATCH 3/3] drm/i915: Only enable the plane after setting the fb base (pre-ILK) Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Intel-GFX Archive on

Archives are clonable:
	git clone --mirror intel-gfx/git/0.git
	git clone --mirror intel-gfx/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 intel-gfx intel-gfx/ \
	public-inbox-index intel-gfx

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone