From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: [PATCH 3/5] drm/i915: check gpu_write_list in move_to_flushing Date: Tue, 19 Apr 2011 22:46:02 +0200 Message-ID: <1303245964-3022-4-git-send-email-daniel.vetter@ffwll.ch> References: <1303245964-3022-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wy0-f177.google.com (mail-wy0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 2E3809EEDE for ; Tue, 19 Apr 2011 12:51:58 -0700 (PDT) Received: by mail-wy0-f177.google.com with SMTP id 28so50785wyb.36 for ; Tue, 19 Apr 2011 12:51:57 -0700 (PDT) In-Reply-To: <1303245964-3022-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org The corresponding WARN_ON with opposite sign already exists in move_to_inactive, hence add it here for symmetry. I've actually hit this while hunting down bugs in various pipelined fencing patches. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_gem.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 5c900d3..f658f4f 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i915_gem.c @@ -1749,6 +1749,7 @@ i915_gem_object_move_to_flushing(struct drm_i915_gem_object *obj) drm_i915_private_t *dev_priv = dev->dev_private; WARN_ON(!obj->active); + WARN_ON(list_empty(&obj->gpu_write_list)); list_move_tail(&obj->mm_list, &dev_priv->mm.flushing_list); i915_gem_object_move_off_active(obj); -- 1.7.4.1