From: Paul Menzel <paulepanter@users.sourceforge.net>
To: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Seperate fence pin counting from normal bind pin counting
Date: Sat, 09 Jul 2011 12:23:02 +0200 [thread overview]
Message-ID: <1310206982.4123.98.camel@mattotaupa> (raw)
In-Reply-To: <1310199904-17359-1-git-send-email-chris@chris-wilson.co.uk>
[-- Attachment #1.1: Type: text/plain, Size: 1222 bytes --]
Am Samstag, den 09.07.2011, 09:25 +0100 schrieb Chris Wilson:
Whoever pushes this, please correct
s/Seperate/Separate/
in the commit summary.
> In order to correctly account for reserving space in the GTT and fences
> for a batch buffer, we need to independently track whether the fence is
> pinned due to a fenced GPU access in the batch from from whether the
> buffer is pinned in the aperture. Currently we count the fenced as
»the fenced« sounds strange. Probably I need to read up the code to
grasp that. Or is the »d« at the end a typo?
> pinned if the buffer has already been seen in the execbuffer. This leads
> to a false accounting of available fence registers, causing frequent
> mass evictions. Worse, if coupled with the change to make
> i915_gem_object_get_fence() report EDADLK upon fence starvation, the
> batchbuffer can fail with only one fence required...
>
> Fixes intel-gpu-tools/tests/gem_fenced_exec_thrash
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=38735
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Tested-by: Paul Neumann <paul104x@yahoo.de>
[…]
Thanks,
Paul
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2011-07-09 10:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-09 8:25 [PATCH] drm/i915: Seperate fence pin counting from normal bind pin counting Chris Wilson
2011-07-09 10:23 ` Paul Menzel [this message]
2011-07-09 10:32 ` Chris Wilson
2011-11-23 10:49 ` Daniel Vetter
-- strict thread matches above, loose matches on Subject: below --
2011-06-04 8:55 Chris Wilson
2011-06-04 17:38 ` Keith Packard
2011-06-04 18:31 ` Chris Wilson
2011-06-05 1:07 ` Keith Packard
2011-06-04 22:18 ` Chris Wilson
2011-06-05 20:55 ` Daniel Vetter
2011-11-13 11:00 ` Chris Wilson
2011-11-13 11:21 ` Paul Menzel
2011-11-23 12:38 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1310206982.4123.98.camel@mattotaupa \
--to=paulepanter@users.sourceforge.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).