From: Chris Wilson <chris@chris-wilson.co.uk>
To: Eric Anholt <eric@anholt.net>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Disable the BLT on pre-production SNB hardware
Date: Thu, 05 Jul 2012 23:27:28 +0100 [thread overview]
Message-ID: <1341527310_183440@CP5-2952> (raw)
In-Reply-To: <87sjd5swfe.fsf@eliezer.anholt.net>
On Thu, 05 Jul 2012 14:57:41 -0700, Eric Anholt <eric@anholt.net> wrote:
> Chris Wilson <chris@chris-wilson.co.uk> writes:
>
> > It never quite worked despite the numerous workarounds, yet I still see
> > people trying to use this hardware and filing bug reports. As we no
> > longer even try to implement the workarounds, since 6a233c78878
> > (drm/i915/ringbuffer: kill snb blt workaround), simply disable the ring.
>
> Do we have something elsewhere that's very verbose telling them to get
> real hardware? Userland isn't going to do very well when the ring
> doesn't work.
The DDX already checks for the pre-production hardware and forces the
shadow buffer if it detects the broken blitter. We can easily add a
message there to remind them to return their SDV and get themselves a
real computer.
So I had actually forgotten about that check. The only question is then
whether that is better in the kernel so that all clients are protected
from pathological users, or left in the DDX?
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-07-05 22:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-05 20:01 [PATCH] drm/i915: Disable the BLT on pre-production SNB hardware Chris Wilson
2012-07-05 21:57 ` Eric Anholt
2012-07-05 22:27 ` Chris Wilson [this message]
2012-07-05 22:49 ` Chris Wilson
2012-07-09 16:39 ` Eric Anholt
2012-07-09 18:05 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341527310_183440@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=eric@anholt.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).