From: Chris Wilson <chris@chris-wilson.co.uk>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 1/2] drm/i915: check whether we actually received an edid in detect_ddc
Date: Wed, 11 Jul 2012 11:44:36 +0100 [thread overview]
Message-ID: <1342003482_250546@CP5-2952> (raw)
In-Reply-To: <1342002713-12628-1-git-send-email-daniel.vetter@ffwll.ch>
On Wed, 11 Jul 2012 12:31:52 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Somehow detect_ddc manages to fall through all checks when we think
> that something responds on the ddc i2c address, but the edid read
> failed. Fix this up by explicitly checking for this case.
>
> This fixes a regression on newer chips because since
>
> commit aaa377302b2994fcc2c66741b47da33feb489dca
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date: Sat Jun 16 15:30:32 2012 +0200
>
> drm/i915/crt: Do not rely upon the HPD presence pin
>
> we use ddc detection also on hotplug capable platforms. And one of
> these reads all 0s for any i2c transaction if nothing is connected to
> the vga port.
>
> v2: Implement Chris Wilson's review:
> - simplify logic, default to "nothing detected"
> - kill stale comment
> - BUG_ON(!crt->type != ANALOG)
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=51900
> Tested-by: Yang Guang <guang.a.yang@intel.com>
> Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
I'm happy with that, and thanks for the extra clarification in the debug
messages.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-07-11 10:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-11 9:47 [PATCH] drm/i915: check whether we actually received an edid in detect_ddc Daniel Vetter
2012-07-11 9:58 ` Chris Wilson
2012-07-11 10:31 ` [PATCH 1/2] " Daniel Vetter
2012-07-11 10:31 ` [PATCH 2/2] drm/i915: kill intel_ddc_probe Daniel Vetter
2012-07-11 10:43 ` Chris Wilson
2012-07-11 10:44 ` Chris Wilson [this message]
2012-07-11 20:02 ` [PATCH 1/2] drm/i915: check whether we actually received an edid in detect_ddc Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342003482_250546@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).