From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 01/13] drm/i915: Flush the context object from the CPU caches upon creation Date: Sat, 14 Jul 2012 10:38:24 +0100 Message-ID: <1342258716_7110@CP5-2952> References: <1342185256-16024-1-git-send-email-chris@chris-wilson.co.uk> <1342185256-16024-2-git-send-email-chris@chris-wilson.co.uk> <20120713155454.GH5721@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id B7F5C9F00B for ; Sat, 14 Jul 2012 02:38:43 -0700 (PDT) In-Reply-To: <20120713155454.GH5721@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Fri, 13 Jul 2012 17:54:54 +0200, Daniel Vetter wrote: > I think only the first hunk should be part of this patch - the later two > hunks make more sense squashed together with the last patch. At least that > would avoid me going a bit wtf here and then again on the last patch where > the from_obj->dirty=1 gets removed and smashed into move_to_active. Until > I've realized what's going on here ;-) When I've rewritten this patch to be more correct (handle the swap-in case as well), it will make more sense the way it is in this patch. Honestly. :) -Chris -- Chris Wilson, Intel Open Source Technology Centre