From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 2/2] drm/i915: Add simulator's host bridge Date: Sat, 21 Jul 2012 10:42:13 +0100 Message-ID: <1342863733_22403@CP5-2952> References: <1342806210-4807-1-git-send-email-ben@bwidawsk.net> <1342806210-4807-2-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id 64AF49E70A for ; Sat, 21 Jul 2012 02:42:21 -0700 (PDT) In-Reply-To: <1342806210-4807-2-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Fri, 20 Jul 2012 10:43:30 -0700, Ben Widawsky wrote: > Add the host bridge ID used by the simulator. This was added in a > previous patch for the agp layer, but wasn't preserved here. It also > gives us an opportunity to let the rest of the driver know we're running > as the simulator for various workarounds. I like how minimal this looks, though it does worry me that is a little too easy... (Not least the question why the simulator doesn't work with forcewake... Doesn't that strike you as odd that we have rc6 bugs and the simulator dies... ;-) I think I would rather see this as an intel_info so that it can be expanded upon simply for future/past simulators. However, the fundamental question is do we ever ship simulators? If we try to avoid carrying pre-production w/a, shouldn't that mean that we don't even contemplate pushing simulator interfaces. Having said, carrying these patches centrally does mean that will be reviewed and kept in mind for future iterations. -Chris -- Chris Wilson, Intel Open Source Technology Centre