From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: [PATCH 0/6] reduce register save/restoring accross suspend/resume
Date: Thu, 11 Oct 2012 20:08:22 +0200 [thread overview]
Message-ID: <1349978908-7687-1-git-send-email-daniel.vetter@ffwll.ch> (raw)
Hi all,
This is a start at stopping to use the register save/restore stuff with kms
enabled. Imo we've had too many bugs in the resume code because no one seems to
care about this code and check whether it still makes sense for new platforms.
Or to check whether a bugfix to a reg write sequence also needs to be applied
there. Or whether restoring some random register is a good idea at all.
So I've started to audit all the register write/restores and check whether our
normal setup code could possible rely on this. If I haven't found anything, I've
braketed the respective block with a if (!KMS) check.
I probably need a few more days of utter boredom to work through it all.
Comments, flames and review highly welcome.
Cheers, Daniel
Daniel Vetter (6):
drm/i915/crt: don't set HOTPLUG bits on !PCH
drm/i915/crt: explicitly set up HOTPLUG_BITS on resume
drm/i915: don't save/restor ADPA for kms
drm/i915: don't save/restore DP regs for kms
drm/i915: don't save/restore irq regs for kms
drm/i915: don't save/restore HWS_PGA reg for kms
drivers/gpu/drm/i915/i915_drv.c | 1 -
drivers/gpu/drm/i915/i915_suspend.c | 154 +++++++++++++++++++----------------
drivers/gpu/drm/i915/intel_crt.c | 32 ++++----
drivers/gpu/drm/i915/intel_display.c | 2 +
4 files changed, 103 insertions(+), 86 deletions(-)
--
1.7.11.2
next reply other threads:[~2012-10-11 19:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-11 18:08 Daniel Vetter [this message]
2012-10-11 18:08 ` [PATCH 1/6] drm/i915/crt: don't set HOTPLUG bits on !PCH Daniel Vetter
2012-10-12 2:47 ` Paulo Zanoni
2012-10-12 8:45 ` Daniel Vetter
2012-10-12 17:17 ` Paulo Zanoni
2012-10-12 17:26 ` Daniel Vetter
2012-10-17 21:31 ` Paulo Zanoni
2012-10-11 18:08 ` [PATCH 2/6] drm/i915/crt: explicitly set up HOTPLUG_BITS on resume Daniel Vetter
2012-10-17 21:42 ` Paulo Zanoni
2012-10-11 18:08 ` [PATCH 3/6] drm/i915: don't save/restor ADPA for kms Daniel Vetter
2012-10-17 21:49 ` Paulo Zanoni
2012-10-18 12:34 ` Daniel Vetter
2012-10-11 18:08 ` [PATCH 4/6] drm/i915: don't save/restore DP regs " Daniel Vetter
2012-10-11 18:08 ` [PATCH 5/6] drm/i915: don't save/restore irq " Daniel Vetter
2012-10-11 18:08 ` [PATCH 6/6] drm/i915: don't save/restore HWS_PGA reg " Daniel Vetter
2012-10-17 9:32 ` [PATCH 1/3] drm/i915: don't save/restore DP regs " Daniel Vetter
2012-10-17 9:32 ` [PATCH 2/3] drm/i915: don't save/restore irq " Daniel Vetter
2012-10-17 9:32 ` [PATCH 3/3] drm/i915: don't save/restore HWS_PGA reg " Daniel Vetter
2012-10-17 19:52 ` [PATCH 1/3] drm/i915: don't save/restore DP regs " Paulo Zanoni
2012-10-17 20:39 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349978908-7687-1-git-send-email-daniel.vetter@ffwll.ch \
--to=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).