From: Imre Deak <imre.deak@intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 02/10] drm/i915: don't handle PIPE_LEGACY_BLC_EVENT_STATUS on vlv
Date: Tue, 04 Dec 2012 16:37:55 +0200 [thread overview]
Message-ID: <1354631875.746.1.camel@localhost> (raw)
In-Reply-To: <1354366429-2324-3-git-send-email-daniel.vetter@ffwll.ch>
On Sat, 2012-12-01 at 13:53 +0100, Daniel Vetter wrote:
> This is for legacy legacy stuff, and checking with the leftover
> pipe from the previous loop is propably not what we want. Since
> pipe == 2 after the loop ...
This doesn't seem to match the change, blc_event is simply never used
here.
>
> Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/i915/i915_irq.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index ff78818..2028137 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -533,7 +533,6 @@ static irqreturn_t valleyview_irq_handler(int irq, void *arg)
> unsigned long irqflags;
> int pipe;
> u32 pipe_stats[I915_MAX_PIPES];
> - bool blc_event;
>
> atomic_inc(&dev_priv->irq_received);
>
> @@ -590,9 +589,6 @@ static irqreturn_t valleyview_irq_handler(int irq, void *arg)
> I915_READ(PORT_HOTPLUG_STAT);
> }
>
> - if (pipe_stats[pipe] & PIPE_LEGACY_BLC_EVENT_STATUS)
> - blc_event = true;
> -
> if (pm_iir & GEN6_PM_DEFERRED_EVENTS)
> gen6_queue_rps_work(dev_priv, pm_iir);
>
next prev parent reply other threads:[~2012-12-04 14:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-01 12:53 [PATCH 00/10] gmbus/dp aux irqfication Daniel Vetter
2012-12-01 12:53 ` [PATCH 01/10] drm/i915: haswell has the same irq handlers as ivb Daniel Vetter
2012-12-01 12:53 ` [PATCH 02/10] drm/i915: don't handle PIPE_LEGACY_BLC_EVENT_STATUS on vlv Daniel Vetter
2012-12-03 15:49 ` Jesse Barnes
2012-12-04 14:37 ` Imre Deak [this message]
2012-12-04 15:13 ` Daniel Vetter
2012-12-01 12:53 ` [PATCH 03/10] drm/i915: reorder setup sequence to have irqs for output setup Daniel Vetter
2012-12-01 20:03 ` [PATCH 1/2] drm/i915: setup the hangcheck timer early Daniel Vetter
2012-12-01 20:03 ` [PATCH 2/2] drm/i915: reorder setup sequence to have irqs for output setup Daniel Vetter
2012-12-01 12:53 ` [PATCH 04/10] drm/i915: extract gmbus_wait_hw_status Daniel Vetter
2012-12-01 12:53 ` [PATCH 05/10] drm/i915: wire up gmbus irq handler Daniel Vetter
2012-12-01 12:53 ` [PATCH 06/10] drm/i915: use the gmbus irq for waits Daniel Vetter
2012-12-01 12:53 ` [PATCH 07/10] drm/i915: use gmbus irq to wait for gmbus idle Daniel Vetter
2012-12-01 12:53 ` [PATCH 08/10] drm/i915: wire up do aux channel done interrupt Daniel Vetter
2012-12-01 12:53 ` [PATCH 09/10] drm/i915: irq-drive the dp aux communication Daniel Vetter
2012-12-01 12:53 ` [PATCH 10/10] drm/i915: use _NOTRACE for gmbus/dp aux wait loops Daniel Vetter
2012-12-01 16:35 ` Chris Wilson
2012-12-01 20:03 ` [PATCH] " Daniel Vetter
2012-12-01 16:47 ` [PATCH 00/10] gmbus/dp aux irqfication Chris Wilson
2012-12-01 18:01 ` Chris Wilson
2012-12-01 20:15 ` Daniel Vetter
2012-12-04 9:20 ` Chris Wilson
2012-12-04 16:04 ` Imre Deak
2012-12-05 10:59 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354631875.746.1.camel@localhost \
--to=imre.deak@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).