Re: [Intel-gfx] [PATCH 10/19] drm/i915: Nuke arguments to eb_pin_engine

From: "Ruhl, Michael J" <michael.j.ruhl@intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 10/19] drm/i915: Nuke arguments to eb_pin_engine
Date: Fri, 14 Feb 2020 20:07:08 +0000	[thread overview]
Message-ID: <14063C7AD467DE4B82DEDB5C278E8663F4FC3C3F@FMSMSX108.amr.corp.intel.com> (raw)
In-Reply-To: <20200214103055.2117836-11-maarten.lankhorst@linux.intel.com>

>-----Original Message-----
>From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of
>Maarten Lankhorst
>Sent: Friday, February 14, 2020 5:31 AM
>To: intel-gfx@lists.freedesktop.org
>Subject: [Intel-gfx] [PATCH 10/19] drm/i915: Nuke arguments to
>eb_pin_engine
>
>Those arguments are already set as eb.file and eb.args, so kill off
>the extra arguments. This will allow us to move eb_pin_engine() to
>after we reserved all BO's.

"move eb_pin_engine() to"

I think you mean "too"? (as in "move eb_pin_engine also"

Or do you mean "move_eb_pin_engine to <somewhere else>, after we"?

Other than that,

Acked-by: Michael J. Ruhl <michael.j.ruhl@intel.com>

Mike

>
>Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>---
> drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 17 +++++++----------
> 1 file changed, 7 insertions(+), 10 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
>b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
>index a27aa85985bd..d96e7649314c 100644
>--- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
>+++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
>@@ -2393,11 +2393,10 @@ static void eb_unpin_engine(struct
>i915_execbuffer *eb)
> }
>
> static unsigned int
>-eb_select_legacy_ring(struct i915_execbuffer *eb,
>-		      struct drm_file *file,
>-		      struct drm_i915_gem_execbuffer2 *args)
>+eb_select_legacy_ring(struct i915_execbuffer *eb)
> {
> 	struct drm_i915_private *i915 = eb->i915;
>+	struct drm_i915_gem_execbuffer2 *args = eb->args;
> 	unsigned int user_ring_id = args->flags & I915_EXEC_RING_MASK;
>
> 	if (user_ring_id != I915_EXEC_BSD &&
>@@ -2412,7 +2411,7 @@ eb_select_legacy_ring(struct i915_execbuffer *eb,
> 		unsigned int bsd_idx = args->flags & I915_EXEC_BSD_MASK;
>
> 		if (bsd_idx == I915_EXEC_BSD_DEFAULT) {
>-			bsd_idx = gen8_dispatch_bsd_engine(i915, file);
>+			bsd_idx = gen8_dispatch_bsd_engine(i915, eb->file);
> 		} else if (bsd_idx >= I915_EXEC_BSD_RING1 &&
> 			   bsd_idx <= I915_EXEC_BSD_RING2) {
> 			bsd_idx >>= I915_EXEC_BSD_SHIFT;
>@@ -2437,18 +2436,16 @@ eb_select_legacy_ring(struct i915_execbuffer
>*eb,
> }
>
> static int
>-eb_pin_engine(struct i915_execbuffer *eb,
>-	      struct drm_file *file,
>-	      struct drm_i915_gem_execbuffer2 *args)
>+eb_pin_engine(struct i915_execbuffer *eb)
> {
> 	struct intel_context *ce;
> 	unsigned int idx;
> 	int err;
>
> 	if (i915_gem_context_user_engines(eb->gem_context))
>-		idx = args->flags & I915_EXEC_RING_MASK;
>+		idx = eb->args->flags & I915_EXEC_RING_MASK;
> 	else
>-		idx = eb_select_legacy_ring(eb, file, args);
>+		idx = eb_select_legacy_ring(eb);
>
> 	ce = i915_gem_context_get_engine(eb->gem_context, idx);
> 	if (IS_ERR(ce))
>@@ -2681,7 +2678,7 @@ i915_gem_do_execbuffer(struct drm_device *dev,
> 	if (unlikely(err))
> 		goto err_destroy;
>
>-	err = eb_pin_engine(&eb, file, args);
>+	err = eb_pin_engine(&eb);
> 	if (unlikely(err))
> 		goto err_context;
>
>--
>2.25.0.24.g3f081b084b0
>
>_______________________________________________
>Intel-gfx mailing list
>Intel-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx