From: "Srivatsa, Anusha" <anusha.srivatsa@intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Cc: "Roper, Matthew D" <matthew.d.roper@intel.com>,
"De Marchi, Lucas" <lucas.demarchi@intel.com>
Subject: Re: [Intel-gfx] [CI 1/2] drm/i915/step: Add macro magic for handling steps
Date: Thu, 12 Aug 2021 16:05:29 +0000 [thread overview]
Message-ID: <14f8c2ebed0c4fe8b48421cecd6b2e84@intel.com> (raw)
In-Reply-To: <87a6lnm1ag.fsf@intel.com>
> -----Original Message-----
> From: Jani Nikula <jani.nikula@linux.intel.com>
> Sent: Thursday, August 12, 2021 2:59 AM
> To: Srivatsa, Anusha <anusha.srivatsa@intel.com>; intel-
> gfx@lists.freedesktop.org
> Cc: Roper, Matthew D <matthew.d.roper@intel.com>; De Marchi, Lucas
> <lucas.demarchi@intel.com>
> Subject: Re: [Intel-gfx] [CI 1/2] drm/i915/step: Add macro magic for handling
> steps
>
> On Mon, 19 Jul 2021, Anusha Srivatsa <anusha.srivatsa@intel.com> wrote:
> > With the addition of stepping info for all platforms, lets use macros
> > for handling them and autogenerating code for all steps at a time.
> >
> > Suggested-by: Matt Roper <matthew.d.roper@intel.com>
> > Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> > Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> > Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_step.c | 14 ++++++++++++
> > drivers/gpu/drm/i915/intel_step.h | 37 +++++++++++++++++++------------
> > 2 files changed, 37 insertions(+), 14 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_step.c
> > b/drivers/gpu/drm/i915/intel_step.c
> > index 9fcf17708cc8..d150d138e889 100644
> > --- a/drivers/gpu/drm/i915/intel_step.c
> > +++ b/drivers/gpu/drm/i915/intel_step.c
> > @@ -182,3 +182,17 @@ void intel_step_init(struct drm_i915_private
> > *i915)
> >
> > RUNTIME_INFO(i915)->step = step;
> > }
> > +
> > +#define STEP_NAME_CASE(name) \
> > + (case STEP_##name: \
> > + return #name)
> > +
> > +const char *intel_step_name(enum intel_step step) {
> > + switch (step) {
> > + STEP_NAME_LIST(STEP_NAME_CASE);
> > +
> > + default:
> > + return "**";
> > + }
> > +}
> > diff --git a/drivers/gpu/drm/i915/intel_step.h
> > b/drivers/gpu/drm/i915/intel_step.h
> > index 88a77159703e..f6641e2a3c77 100644
> > --- a/drivers/gpu/drm/i915/intel_step.h
> > +++ b/drivers/gpu/drm/i915/intel_step.h
> > @@ -15,30 +15,39 @@ struct intel_step_info {
> > u8 display_step;
> > };
> >
> > +#define STEP_ENUM_VAL(name) STEP_##name,
> > +
> > +#define STEP_NAME_LIST(func) \
> > + func(A0) \
> > + func(A1) \
> > + func(A2) \
> > + func(B0) \
> > + func(B1) \
> > + func(B2) \
> > + func(C0) \
> > + func(C1) \
> > + func(D0) \
> > + func(D1) \
> > + func(E0) \
> > + func(F0) \
> > + func(G0) \
> > + func(H0) \
> > + func(I0) \
> > + func(I1) \
> > + func(J0)
> > +
> > /*
> > * Symbolic steppings that do not match the hardware. These are valid
> both as gt
> > * and display steppings as symbolic names.
> > */
> > enum intel_step {
> > STEP_NONE = 0,
> > - STEP_A0,
> > - STEP_A2,
> > - STEP_B0,
> > - STEP_B1,
> > - STEP_C0,
> > - STEP_D0,
> > - STEP_D1,
> > - STEP_E0,
> > - STEP_F0,
> > - STEP_G0,
> > - STEP_H0,
> > - STEP_I0,
> > - STEP_I1,
> > - STEP_J0,
> > + STEP_NAME_LIST(STEP_ENUM_VAL)
> > STEP_FUTURE,
> > STEP_FOREVER,
> > };
>
> It's been merged already, and so be it.
>
> I'll just note that the main reason I don't like adding this kind of macro
> abstractions is that it throws off source code tagging tools like ctags and gnu
> global. I can no longer navigate the definition and all the references of
> STEP_* using the tools, and it degenerates to git grep which is much worse as
> it doesn't know about C syntax or semantics. It's not always about how the
> code looks, it's also about how people can navigate the code base.
Had not considered that :-/ will keep this in mind from now on.
Thanks for the feedback.
Anusha
> BR,
> Jani.
>
>
> >
> > void intel_step_init(struct drm_i915_private *i915);
> > +const char *intel_step_name(enum intel_step step);
> >
> > #endif /* __INTEL_STEP_H__ */
>
> --
> Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2021-08-12 16:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 21:38 [Intel-gfx] [CI 1/2] drm/i915/step: Add macro magic for handling steps Anusha Srivatsa
2021-07-19 21:38 ` [Intel-gfx] [CI 2/2] drm/i915/dmc: Change intel_get_stepping_info() Anusha Srivatsa
2021-07-19 22:02 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [CI,1/2] drm/i915/step: Add macro magic for handling steps Patchwork
2021-08-12 9:59 ` [Intel-gfx] [CI 1/2] " Jani Nikula
2021-08-12 16:05 ` Srivatsa, Anusha [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-07-19 22:13 Anusha Srivatsa
2021-07-19 20:00 Anusha Srivatsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14f8c2ebed0c4fe8b48421cecd6b2e84@intel.com \
--to=anusha.srivatsa@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=lucas.demarchi@intel.com \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).