From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Chris Wilson" <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Inject a cond_resched() into long drm_clflush_sg()
Date: Wed, 15 Jan 2020 21:28:22 -0000 [thread overview]
Message-ID: <157912370202.2007.10473864620618910437@emeril.freedesktop.org> (raw)
In-Reply-To: <20200115205245.2772800-1-chris@chris-wilson.co.uk>
== Series Details ==
Series: drm: Inject a cond_resched() into long drm_clflush_sg()
URL : https://patchwork.freedesktop.org/series/72085/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
f1c4f0dc10f6 drm: Inject a cond_resched() into long drm_clflush_sg()
-:41: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#41: FILE: drivers/gpu/drm/drm_cache.c:124:
+ s.max = s.curr = s.sgp->offset;
-:62: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__iter' - possible side-effects?
#62: FILE: drivers/gpu/drm/drm_cache.c:145:
+#define for_each_sgt_page(__pp, __iter, __sgt) \
+ for ((__iter) = __sgt_iter((__sgt)->sgl); \
+ ((__pp) = (__iter).pfn == 0 ? NULL : \
+ pfn_to_page((__iter).pfn + ((__iter).curr >> PAGE_SHIFT))); \
+ (((__iter).curr += PAGE_SIZE) >= (__iter).max) ? \
+ (__iter) = __sgt_iter(__sg_next_resched((__iter).sgp)), 0 : 0)
total: 0 errors, 0 warnings, 2 checks, 68 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-01-15 21:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 20:52 [Intel-gfx] [PATCH] drm: Inject a cond_resched() into long drm_clflush_sg() Chris Wilson
2020-01-15 21:28 ` Patchwork [this message]
2020-01-15 21:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-01-15 21:57 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork
2020-01-16 6:52 ` [Intel-gfx] [PATCH] " Daniel Vetter
2020-01-16 7:40 ` Chris Wilson
2020-01-16 12:26 ` David Laight
2020-01-16 12:28 ` Chris Wilson
2020-01-16 13:58 ` David Laight
2020-01-16 14:01 ` Chris Wilson
2020-01-16 14:40 ` David Laight
2020-01-16 15:04 ` David Laight
2020-01-18 10:45 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
2020-01-23 14:36 ` [Intel-gfx] [PATCH] " David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157912370202.2007.10473864620618910437@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).